D23518: Disable media controls and tabsrunner in Firefox again

2020-11-09 Thread Radoslav Georgiev
rgeorgiev added a comment. I think media controls should be enabled by default in private mode in Firefox. The reason why I think so is that Firefox has an option which allows the user to enable or disable each individual extension in incognito mode. It even asks the user about this explic

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-23 Thread Radoslav Georgiev
rgeorgiev abandoned this revision. rgeorgiev added a comment. @broulik Hmm, now I think that I understood the rationale why SoundCloud support is activated using the **Enhanced Media Controls** option. As you commented on my other revision (D22632 ), Soun

D22632: Implement support for the "next" and "previous" actions in SoundCloud

2019-07-23 Thread Radoslav Georgiev
rgeorgiev added a comment. In D22632#499813 , @broulik wrote: > -1 > Site-specific workarounds are not in scope for this extension. > Also, SoundCloud uses Media Session API and provides callbacks on its own. I'm sorry; I was not awa

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-23 Thread Radoslav Georgiev
rgeorgiev planned changes to this revision. rgeorgiev added a comment. In D22631#499815 , @broulik wrote: > I'm confused - what does this change? There's no context, so I can't tell where it's being moved to. Soundcloud works fine here. You might

D22632: Implement support for the "next" and "previous" actions in SoundCloud

2019-07-21 Thread Radoslav Georgiev
rgeorgiev updated this revision to Diff 62251. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22632?vs=62244&id=62251 REVISION DETAIL https://phabricator.kde.org/D22632 AFFECTED FILES extension/content-script.js To: rgeorgiev Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-21 Thread Radoslav Georgiev
rgeorgiev updated this revision to Diff 62249. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22631?vs=62241&id=62249 REVISION DETAIL https://phabricator.kde.org/D22631 AFFECTED FILES extension/content-script.js To: rgeorgiev Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB

D22632: Implement support for the "next" and "previous" actions in SoundCloud

2019-07-21 Thread Radoslav Georgiev
rgeorgiev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rgeorgiev requested review of this revision. REVISION SUMMARY Implement support for the "next" and "previous" actions in SoundCloud. REPOSITORY R856 Plasma Browser Integration REVISION D

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-21 Thread Radoslav Georgiev
rgeorgiev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rgeorgiev requested review of this revision. REVISION SUMMARY Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud