D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn added a comment. In D14988#320052 , @hein wrote: > And @phuongn, I'm guessing you set all of these options to disabling wrap-around, right? I wasn't the original author of the very first wrap-around option for KWin, which only wo

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

phuongn updated this revision to Diff 40792. phuongn added a comment. Agree! Updated 🙂 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14989?vs=40791&id=40792 REVISION DETAIL https://phabricator.kde.org/D14989 AFFECTED FILES containmentactions

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

phuongn updated this revision to Diff 40791. phuongn added a comment. Ok! I updated the string, it's now "Enable desktop navigation wraps around" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14989?vs=40619&id=40791 REVISION DETAIL https://phab

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

phuongn updated this revision to Diff 40619. phuongn added a comment. Correct the erroneous logic for determining the next and previous desktop index REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14989?vs=40555&id=40619 REVISION DETAIL https:/

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn updated this revision to Diff 40618. phuongn added a comment. Correct the erroneous logic for determining the next and previous desktop index REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14988?vs=40549&id=40618 REVISION DETAIL https://p

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn added a comment. F6220957: image.png Currently there is already "Desktop navigation wraps around" option for Virtual Desktops, which serve exact same purpose as this patch, but only for keyboard shortcut. I used "Page navigation wraps arou

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn added a comment. Hi, it's just the default desktop changing effect. Activated by scrolling with the cursor hovering on the pager. I haven't changed the effect, just added an option to toggle page wrapping F6220920: simplescreenrecorder-2018-08-28_17.44.42.mp4

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

phuongn updated this revision to Diff 40555. phuongn added a comment. Use standard min max functions to make code more readable for desktopswitch no-wrap option REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14989?vs=40192&id=40555 REVISION DETAI

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn updated this revision to Diff 40549. phuongn marked an inline comment as done. phuongn added a comment. Utilize Math methods (min, max) to make the code more readable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14988?vs=40188&id=40549 REV

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn marked an inline comment as done. phuongn added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:130 > would > > var nextPage = plasmoid.configuration.wrapPage? > (pagerModel.currentPage + 1) % repeater.count : > Math.max(page

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn added a comment. I couldn't find an easy way to access KWindowSystem config from there. On the other hand, I personally prefer wrapping when using keyboard shortcut and no wrapping when using mouse or touchpad gesture. I figured some people might need the same flexibility. REPOSITO

D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action

phuongn created this revision. phuongn added a reviewer: Plasma. phuongn added a project: Plasma. Herald added a subscriber: plasma-devel. phuongn requested review of this revision. REVISION SUMMARY BUG: 361672 This patch implement an option to disable navigation wraps around for the switc

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

phuongn created this revision. phuongn added a project: Plasma. Herald added a subscriber: plasma-devel. phuongn requested review of this revision. REVISION SUMMARY BUG: 361672 This patch implement an option to disable navigation wraps around for the pager plasmoid, which potentially cause