Re: [PATCH] fixing krazy2 issues in kdeplasma-addons

2009-01-16 Thread Philipp Klaffert
Am 16. Januar 2009 16:54 schrieb Aaron J. Seigo : > On Friday 16 January 2009, Philipp Klaffert wrote: > > Since I had some time I patched some of the minor krazy2 issues in > > kdeplasma-addons. Mostly the QLatin1String and double-quote issues. > > I attached the patch to t

[PATCH] fixing krazy2 issues in kdeplasma-addons

2009-01-16 Thread Philipp Klaffert
Since I had some time I patched some of the minor krazy2 issues in kdeplasma-addons. Mostly the QLatin1String and double-quote issues. I attached the patch to this mail so feel free to look over it and if its Ok, please commit it since I am not able to do so... --- Regards Philipp Klaffert Index

Re: [Kourse 3] Fixing krazy2 issues

2009-01-16 Thread Philipp Klaffert
Am 16. Januar 2009 00:21 schrieb Aaron J. Seigo : > On Thursday 15 January 2009, Philipp Klaffert wrote: > > I've now swapped all the Strings with constants and so, just 3 objects an > > no more krazy complaining for at least these issues. > > great; ready to commit! =

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert
Am 15. Januar 2009 17:39 schrieb Aaron J. Seigo : > On Thursday 15 January 2009, Philipp Klaffert wrote: > > thanks for your reply and for the link. For fixing the krazy2 issues > > correctly I changed QString to QLatin1String. I understand your point of > > view with &quo

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert
standing of the code not so much harder... You can find the modified patch in the attachment. 2009/1/15 Dominik Haumann > Hi Philipp, > > On Thursday 15 January 2009, Philipp Klaffert wrote: > > @@ -54,7 +53,7 @@ > > return true; > > } &

RE: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert
> Hey > 2009/1/15 Philipp Klaffert <https://mail.kde.org/mailman/listinfo/plasma-devel>>: >*> license and copyright issues and you can find the patch in the attachement *>*> of this Mail. * > I think you forgot to attach the patch hehe =) > Cheers and

[PATCH] fixing krazy2 issues in "dataengines"

2009-01-15 Thread Philipp Klaffert
Hi, according to the Kourse on kde.org [1] I fixed some of the issues in "kdeplasma-addons/dataengines" found on EBN. The only issues left are the license and copyright issues and you can find the patch in the attachement of this Mail. Regards Philipp Klaffert [1] http://forum.kde.org