Re: Review Request 125161: Make the classic module optional and thus the dependencie to khtml.

2015-09-11 Thread Patrick von Reth
marked as submitted. Review request for Plasma. Changes --- Submitted with commit b78ceaf804d5d1137bf3fe3f429886879d4b5954 by Patrick von Reth to branch master. Repository: systemsettings Description --- Make the classic module optional and thus the dependencie to khtml. Diffs

Review Request 125161: Make the classic module optional and thus the dependencie to khtml.

2015-09-11 Thread Patrick von Reth
--- Make the classic module optional and thus the dependencie to khtml. Diffs - CMakeLists.txt 6bcd1b1b419a222350957b09bf715b6f88744889 Diff: https://git.reviewboard.kde.org/r/125161/diff/ Testing --- Windows Thanks, Patrick von Reth

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
marked as submitted. Review request for Plasma. Changes --- Submitted with commit e50c6d5d6072c734113a57d47db6c7308b2aed76 by Patrick von Reth to branch master. Repository: kde-cli-tools Description --- Update dependencies and fix build on Windows. Diffs - CMakeLists.txt

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
Su. - Patrick --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/#review85161 --- On Sept. 11, 2015, 9:34 vorm., Patrick

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
/ Testing --- Windows Thanks, Patrick von Reth ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
--- Update dependencies and fix build on Windows. Diffs - CMakeLists.txt ca5c6bba4d44953a254d182e097221956b79b252 kcmshell/CMakeLists.txt a867539b92ddaebee1c6e8f7055f48383ce60f4c Diff: https://git.reviewboard.kde.org/r/125155/diff/ Testing --- Windows Thanks, Patrick von Reth

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

2014-05-15 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/#review58006 --- Ship it! Ship It! - Patrick von Reth On May 15, 2014, 3

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/#review58007 --- Ship it! Ship It! - Patrick von Reth On May 15, 2014, 2