Re: Review Request 126417: don't rely on char* to QString implicit conversion

2015-12-18 Thread Patrick Spendrin
marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 54736e262f80b62686c11d542d5d239233243d1f by Patrick Spendrin to branch master. Repository: plasma-framework Description --- my Qt won't cast char* to QString, so explicitl

Review Request 126417: don't rely on char* to QString implicit conversion

2015-12-18 Thread Patrick Spendrin
-framework Description --- my Qt won't cast char* to QString, so explicitly use QStringLiteral here. Diffs - src/plasmaquick/appletquickitem.cpp 614b793fa724e7be0fb2dd8151374303fcc6ec18 Diff: https://git.reviewboard.kde.org/r/126417/diff/ Testing --- Windows. Thanks, Pa

Re: KCM's and Plasma-desktop

2015-10-09 Thread Patrick Spendrin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 09.10.2015 um 13:30 schrieb Vishesh Handa: > On Mon, Oct 5, 2015 at 5:20 PM, Hannah von Reth > wrote: >> Baloo could be useful. > > Baloo is only for linux. Windows has its own search solution far > superior to ours. Well, I wouldn't remove the

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

2015-02-12 Thread Patrick Spendrin
/118155/diff/ Testing --- mingw Thanks, Patrick Spendrin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma-desktop on non Xorg (X11/Wayland) windowing systems?

2014-06-11 Thread Patrick Spendrin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 11.06.2014 12:25, schrieb Marco Martin: > On Wednesday 11 June 2014, Martin Gräßlin wrote: >> Hi all! >> >> The review request [1] raised the question whether it makes sense >> that we have any support for building without X11 support. Right >> n

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/118153/diff/ Testing --- mingw Thanks, Patrick Spendrin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118155: adapt to ecm_add_tests so that tests can be found

2014-05-15 Thread Patrick Spendrin
-framework Description --- adapt to ecm_add_tests so that tests can be found Diffs - autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 Diff: https://git.reviewboard.kde.org/r/118155/diff/ Testing --- mingw Thanks, Patrick Spendrin

Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick Spendrin
-framework Description --- remove unneeded file which collides with kf5plasma exports Diffs - autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 Diff: https://git.reviewboard.kde.org/r/118153/diff/ Testing --- mingw Thanks, Patrick Spendrin

Re: Review Request 118119: remove unneeded header

2014-05-15 Thread Patrick Spendrin
--- mingw windows Thanks, Patrick Spendrin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118119: remove unneeded header

2014-05-13 Thread Patrick Spendrin
-framework Description --- remove unneeded header Diffs - src/plasma/theme.cpp aed5b98609d8502f05ca8b8404d92efd4eedf8d4 Diff: https://git.reviewboard.kde.org/r/118119/diff/ Testing --- mingw windows Thanks, Patrick Spendrin

Review Request: windows port of taskmanager library

2009-07-22 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1101/ --- Review request for Plasma. Summary --- I want to add some missing functiona

Re: How know if desktop effects (composition) is enabled?

2008-09-02 Thread Patrick Spendrin
Aaron J. Seigo schrieb: > On Tuesday 02 September 2008, Gustavo Pichorim Boiko wrote: >> Em 02/09/2008, às 20:32, Aaron J. Seigo escreveu: >>> what we primarily use KWindowSystem::compositingActive() is to pick >>> whether >>> we'll be rendering a square block for the background or something >>> wi