D11235: [DrKonqi] Request change of ptrace scope from KCrash

maximilianocuria added inline comments. INLINE COMMENTS > queryptrace.cpp:26 > +server.sun_family = AF_UNIX; > +sprintf(server.sun_path, "/tmp/kcrash_%lld", > QCoreApplication::applicationPid()); > +if (::connect(sfd, (struct sockaddr *)&server, sl) == 0) { Please honour TMPDIR or,

D12781: Fix filetypestest

maximilianocuria closed this revision. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D12781 To: maximilianocuria, #plasma, kossebau, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12780: Avoid including the generated config-X11 private header

maximilianocuria closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12780 To: maximilianocuria, #plasma, mlaurent, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12781: Fix filetypestest

maximilianocuria created this revision. maximilianocuria added reviewers: Plasma, kossebau. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. maximilianocuria requested review of this revision. REVISION SUMMARY Concatenating strings results

D12780: Avoid including the generated config-X11 private header

maximilianocuria created this revision. maximilianocuria added reviewers: Plasma, mlaurent. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. maximilianocuria requested review of this revision. TEST PLAN building the installed headers no lon

D12702: Avoid giving an stderr to kwallet

maximilianocuria added a comment. Btw, Debian users confirmed that this fixes the issue: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897687 And in the "Kwallet does not work" thread here: https://lists.debian.org/debian-kde/2018/05/threads.html#1 REPOSITORY R107 KWallet PAM

D12702: Avoid giving an stderr to kwallet

maximilianocuria added a comment. I'm not sure, but I think that pam could be called from a process that has the stdin/stdout/stderr redirected to pipes, so disconnecting those for a long lived process would avoid a possible broken pipe. Now, if that's so, why it's not clossing stdin and std

D12702: Avoid giving an stderr to kwallet

This revision was automatically updated to reflect the committed changes. Closed by commit R107:8da1a47035fc: Avoid giving an stderr to kwallet (authored by maximilianocuria). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12702?vs=33675&id=336

D12702: Avoid giving an stderr to kwallet

maximilianocuria updated this revision to Diff 33675. maximilianocuria added a comment. Update comments as suggested. I'll push this, and ask the users that reported the issue to also test the fixed version. Thanks. REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPD

D12702: Avoid giving an stderr to kwallet

maximilianocuria added a comment. I can reproduce the issue in openbox and cinnamon. I think this is related to qt5ct which always tries to print things to stderr. I guess having the debug messages enabled would also trigger the issue. The problem is no longer present with either version

D12702: Avoid giving an stderr to kwallet

maximilianocuria updated this revision to Diff 33663. maximilianocuria added a comment. A somewhat simpler version, just delay the close(2) call. I was testing this and trying to look for some documentation about the use of the fds in pam modules. I'm pretty sure that you can't keep them, b

D12702: Avoid giving an stderr to kwallet

maximilianocuria created this revision. maximilianocuria added reviewers: Plasma, aacid. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. maximilianocuria requested review of this revision. REVISION SUMMARY The fixes for CVE-2018-10380 intr

D12658: Migrate to ecm_qt_declare_logging_category

maximilianocuria closed this revision. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D12658 To: maximilianocuria, #plasma, ivan, lbeltrame, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seba

D12658: Migrate to ecm_qt_declare_logging_category

maximilianocuria created this revision. maximilianocuria added reviewers: Plasma, ivan, lbeltrame. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. maximilianocuria requested review of this revision. REVISION SUMMARY During D12656

D12656: Use category logging

maximilianocuria closed this revision. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D12656 To: maximilianocuria, #plasma, lbeltrame, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12656: WIP: Use category logging

maximilianocuria created this revision. maximilianocuria added reviewers: Plasma, lbeltrame, ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. maximilianocuria requested review of this revision. REVISION SUMMARY Without this kactivitym

Re: Kscreenlocker 5.10.5.1

¡Hola David! El 2017-08-31 a las 18:12 +0100, David Edmundson escribió: Kscreenlocker has a feature that doesn't play nicely with the latest nvidia driver making the entire thing crash. Given locking the screen is quite an important operation, we've made an immediate release that works round

Re: KWin 5.10.3.1 update

¡Hola Martin! El 2017-07-09 a las 14:52 +0200, Martin Flöser escribió: If there are changes which can be backported we will do. Please do not cherry pick changes, that makes it impossible for us to ensure the quality or investigate bugs. That's not what I was trying to do here. With my Deb

Re: KWin 5.10.3.1 update

¡Hola Martin! El 2017-07-08 a las 14:45 +0200, Martin Flöser escribió: Am 2017-07-07 15:54, schrieb Maximiliano Curia: El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió: KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a fix for https://bugs.kde.org/show_bug.cgi

Re: KWin 5.10.3.1 update

¡Hola Jonathan! El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió: KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a fix for https://bugs.kde.org/show_bug.cgi?id=381870 Freeze in KWin::checkGLError on startup which affects machines with an NVidia card. The chan

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

Diff: https://git.reviewboard.kde.org/r/129528/diff/ Testing --- Thanks, Maximiliano Curia

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

ed as long as it's an > > int as this will be hidden anyway, this can be just: > > > > percent: pmSource.data["Battery"]["Percent"] || 0 > > > > without a function. > > Maximiliano Curia wrote: > I've change

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

rd.kde.org/r/129528/#review101053 --- On Nov. 22, 2016, 10:50 a.m., Maximiliano Curia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

: https://git.reviewboard.kde.org/r/129528/diff/ Testing --- Thanks, Maximiliano Curia

Review Request 129528: Fix "Unable to assign [undefined] to int" log

://gist.github.com/Zren/4e5709d842965227088f6e1d3fd42016 Debian-Bug: https://bugs.debian.org/844194 Diffs - lookandfeel/contents/components/Battery.qml c4a94ebb6e3ca2f7b46e768f2c9bde22c9d6bbdf Diff: https://git.reviewboard.kde.org/r/129528/diff/ Testing --- Thanks, Maximiliano

Re: Review Request 127963: Adding missing license

src/plasma/private/package_p.h src/plasma/private/packagestructure_p.h src/plasma/private/servicejob_p.h Diffs - COPYING.LGPL-2 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127963/diff/ Testing --- Thanks, Maximiliano Curia

Review Request 127963: Adding missing license

/servicejob_p.h Diffs - COPYING.LGPL-2 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127963/diff/ Testing --- Thanks, Maximiliano Curia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

On 10/12/15 17:45, Martin Klapetek wrote: > However if I'm not mistaken, that set_target_properties call does not > do what you imply it does. Setting empty PREFIX means that it will > not prepend "lib" to the filename, eg. "libpam_kwallet.so", but will instead > name it "pam_kwallet.so". Oh, you a

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

Hi, On 28/08/15 04:39, Pinak Ahuja wrote: > https://git.reviewboard.kde.org/r/124962/ > By Pinak Ahuja. > > /Updated Aug. 28, 2015, 7:39 a.m./ > > *Repository: * kwallet-pam > > pam_kwallet5.so was being installed to /lib(64) irrespective of what the > installation prefix was set to. This patch

Re: Review Request 124290: Add missing licenses

marked as submitted. Review request for Plasma. Changes --- Submitted with commit dc41d66cb4422ce97c97c9ac71a0c1cd894e0bcd by Diane Trout on behalf of Maximiliano Curia to branch master. Repository: plasma-desktop Description --- There are quite a number of files under the LGPL-2.1

Review Request 124290: Add missing licenses

/2015/07/msg00269.html) Diffs - COPYING.LGPL-2 PRE-CREATION COPYING.LIB PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124290/diff/ Testing --- Thanks, Maximiliano Curia ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: No co-installability of plasma 1 and 2

In article <25673324.XNmJUoyzAe@martin-desktop> you wrote: > in todays hangout Alex asked whether kwin binary is going to be renamed to > kwin5 to make it possible to co-install plasma 1 and plasma 2. > My opinion of that is, that we don't need to have things co-installable. > After > all kde-wo