Re: Review Request 124659: Fix segfaults in kcm_keyboard

2015-08-08 Thread Maxim Mikityanskiy
marked as submitted. Review request for Plasma. Changes --- Submitted with commit a20e1e5c41d41fac4b6a2fc4d6fba7e0b9637615 by David Edmundson on behalf of Maxim Mikityanskiy to branch Plasma/5.4. Repository: plasma-desktop Description --- There are two scenarios that lead to

Re: Review Request 124659: Fix segfaults in kcm_keyboard

2015-08-08 Thread Maxim Mikityanskiy
> On Авг. 8, 2015, 10:51 д.п., David Edmundson wrote: > > are there any bug reports on those crashes? > > > > Do you have commit access, can you push to Plasma/5.4 branch too > > Maxim Mikityanskiy wrote: > I don't know if there are any bug re

Re: Review Request 124659: Fix segfaults in kcm_keyboard

2015-08-08 Thread Maxim Mikityanskiy
onChanged is needed, > but at least it fixes two segfaults. > > > Diffs > - > > kcms/keyboard/kcm_keyboard_widget.cpp 78ec60b > > Diff: https://git.reviewboard.kde.org/r/124659/diff/ > > > Testing > --- > > > Thanks, > > Maxim Mikityanskiy > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124659: Fix segfaults in kcm_keyboard

2015-08-08 Thread Maxim Mikityanskiy
t least it fixes two segfaults. Diffs - kcms/keyboard/kcm_keyboard_widget.cpp 78ec60b Diff: https://git.reviewboard.kde.org/r/124659/diff/ Testing --- Thanks, Maxim Mikityanskiy ___ Plasma-devel mailing list Plasma-devel@kde.org https://ma