Re: Review Request: Checking the return value of gps_open() as condition instead of checking m_gpsdata for prevent crash when no gpsd running

2011-11-03 Thread Max Lin
sit: http://git.reviewboard.kde.org/r/103035/#review7888 --- On Nov. 3, 2011, 4:15 a.m., Max Lin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.

Review Request: Checking the return value of gps_open() as condition instead of checking m_gpsdata for prevent crash when no gpsd running

2011-11-02 Thread Max Lin
th gps device plugged. Thanks, Max Lin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: The tooltip's tag are mismatch on krandrtray

2011-05-24 Thread Max Lin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101430/ --- (Updated May 24, 2011, 2:55 p.m.) Review request for Plasma. Changes ---

Re: Review Request: The tooltip's tag are mismatch on krandrtray

2011-05-24 Thread Max Lin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101430/ --- (Updated May 24, 2011, 9:26 a.m.) Review request for Plasma. Summary ---

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-24 Thread Max Lin
2011/4/22 Aaron J. Seigo > On Thursday, April 21, 2011 23:19:18 Max Lin wrote: > > Sure! I am filling the request application form :) > > BTW, an additional question, I seem the question "Who supports this > > request?" in application form, is that necessary? >

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Max Lin
2011/4/21 Aaron J. Seigo > On Thursday, April 21, 2011 22:35:38 Max Lin wrote: > > Direct commit to git? but I haven't KDE git write access permission, do I > > ah, ok; i'll push this commit for you then :) > Thanks for your help. > > > need request d

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Max Lin
your feedback :) 2011/4/21 Luca Beltrame > In data giovedì 21 aprile 2011 12:49:51, Max Lin ha scritto: > > > Thanks :) > > Does means change status to "Submitted", I am new for use reviewboard. > > Put REVIEW: on a single line at the end of your commit > mess

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Max Lin
e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101159/#review2802 --- On April 21, 2011, 8:40 a.m., Max Lin wrote: > > --- > This is an automatically generated

Re: Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-21 Thread Max Lin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101159/ --- (Updated April 21, 2011, 8:40 a.m.) Review request for Plasma. Changes -

Review Request: Fix bug197654: do not save config again when Apply button disabled

2011-04-20 Thread Max Lin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101159/ --- Review request for Plasma. Summary --- Ignore save config again after