D29481: Fix blurry icons in KColorSchemeEditor

mthw added a comment. If everything is fine, can you land this, please? Also into 5.18? I am guessing 5.12 is already EOL and 5.19 is not branched yet. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D29481 To: mthw, #plasma, ngraham Cc: plasm

D29481: Fix blurry icons in KColorSchemeEditor

mthw created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mthw requested review of this revision. REVISION SUMMARY When using fractional scaling, bottom icons are blurred. This patch fixes the issue. TEST PLAN No side effects. REPOSITORY R119 Pla

D29333: Don't show an empty error dialog when canceling the sync password prompt

mthw added a comment. Now there is no error message at all. Instead of removing the dialog, shouldn't there be a message added to inform the user, that they have to enter a password to do the action and also that no changes were made? Something like Kate does when you try to save changes to

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. Are you asking for my approval? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. In D24070#594840 , @ngraham wrote: > Maybe we can land it early in the 5.19 cycle? Do we really have to? That would delay this by additional 5 months., which is really unfortunate since work (a very slow work but sti

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ngraham How does it look with this patch? Will it make it in? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh

D26655: show a thin separator between view and scrollbar

mthw added a comment. In D26655#594149 , @mart wrote: > In D26655#594135 , @mthw wrote: > > > It does look better but looking at this (image) it looks like a st

D26655: show a thin separator between view and scrollbar

mthw added a comment. It does look better but looking at this (image) it looks like a step backwards. Wouldn't it be better to have the scrollbar floating above the content? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26655

D26392: Add option to easily configure and start a hotspot

mthw added a comment. @meven But we already know it's too late for the icon, at least for distros that won't update to KF5 5.67 before Plasma 5.18. Are you saying this can't go forward without an icon? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.

D26392: Add option to easily configure and start a hotspot

mthw added a comment. Is is possible to check if a hotspot icon exists, and if it does, show it, otherwise show a text? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D26392 To: jgrulich, #plasma, ngraham, #vdg Cc: cblack, alexde, mthw, apol

D26392: Add option to easily configure and start a hotspot

mthw added a comment. A checkbox with a tooltip "Create hotspot" and an icon next to it should be enought, right? Just like Wifi and Airplane mode... REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D26392 To: jgrulich, #plasma, ngraham, #vdg

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

mthw accepted this revision. mthw added a comment. Anyway, anytime you feel like this is finished you can land it. You don't have to wait for me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. Power management disabled message is not show anymore if there is no battery present. Is that intentional? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis, broulik, plasma

D26392: Add option to easily configure and start a hotspot

mthw added a comment. @apol You are right, it is not possible to create a hotspot if one is already connected to a WiFi network. Currently enabling hotspot disables your previous connection (WiFi) and hides available WiFi networks. REPOSITORY R116 Plasma Network Management Applet REVISION

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ngraham Sorry to bother you again, but tomorrow is repo freeze and it would be unfortunate if this doesn't make it in. I mean it's finished and it works correctly, right? If needed we can still do small polishing during the Beta period, correct? REPOSITORY R120 Plas

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ngraham could you please look at this? I would say it's finished and there isn't much time left until the next freeze. I also don't expect you to do this during the holidays, so it would be nice to have it finished, before them. I am sorry for being impatient. REPOSIT

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. What does it mean? Can this patch still go forward? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 71222. mthw added a comment. Tried to implement your suggestion, hopefully correctly, works correctly so far. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=71175&id=71222 BRANCH master REVISION DETA

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 71175. mthw added a comment. The second line is everywhere now. I guessed it would make more sense. But if you dont't like it that way, I can remove it. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=699

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added inline comments. INLINE COMMENTS > broulik wrote in batterymonitor.qml:56 > You still haven't addressed this. Don't just `return` when > `powermanagementDisabled`, I would still want to see my battery state when > this is the case? OK, would you like to see: MainText: Power manageme

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. Is everything fine now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Zren

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 69910. mthw added a comment. Done REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=69869&id=69910 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applets/batterymoni

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 69869. mthw added a comment. Added i18n() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=69854&id=69869 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applets/bat

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 69854. mthw added a comment. Secondly if you wait long enough, the description will change, meaning the remaining time isn't calculated imediately after plug/un-plug which looks like a bug somewhere else. This change only adds a message that remaining time i

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. In D24070#563390 , @ndavis wrote: > Here's what I see when the power cable is plugged in: F7766890: Screenshot_20191116_125846.png > > Here's when I unplug it: F7766893: Screenshot_

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. From previous comments: In D24070#534832 , @ngraham wrote: > The logic looks sane to me and the UI is good, but the time-to-empty/time-to-full values still don't always update correctly for me after a state change. I s

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ngraham When does that happen? I am guessing, when batery is being charged, right? This is how it looks for me: https://imgur.com/a/vSkdDmo REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, b

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 69737. mthw added a comment. Issue above fixed and some stuff removed. I do have a question though, what info should be shown when "Power management" is disabled? With this patch it shows: - Battery level + managemet disabled (with battery) - Widget n

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 69693. mthw added a comment. I think I made all the changes you wanted. Hopefully I didn't break anything. It works correctly on first glance. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66959&id=6969

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ndavis Unless this needs a rebase, all I need is review/approval. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, j

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @broulik Any other changes needed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ra

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66959. mthw marked an inline comment as done. mthw added a comment. > Also, what's the reason for not showing percentage when power management is disabled? This isn't about the service not running or being a desktop PC, this is true when screens are forced o

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66958. mthw added a comment. Like this? Don't we need to return something when "remainingTime <= 0"? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66487&id=66958 BRANCH master REVISION DETAIL https

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. Is there still something that needs to be fixed, or can this go in? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ngraham Do you still have issues with this? @ndavis could you try this too? Or anyone else? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66487. mthw added a comment. Re-order again REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66485&id=66487 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applets/b

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. In D24070#534771 , @ngraham wrote: > Heh, how I get this every time my battery is discharging: F7387261: Screenshot_20190919_102717.png Not here: F7387375: Screenshot_20190919_1

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66485. mthw added a comment. Remove ";", reorder and simplify if clauses REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66482&id=66485 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2407

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw marked 6 inline comments as done. mthw added a comment. Is the formatting OK? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66482. mthw added a comment. Switch lines REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66480&id=66482 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applets/bat

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66480. mthw added a comment. Use battery at X% REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66476&id=66480 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applet

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. I can do that if @ngraham agrees. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, al

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ndavis So, generally, you would like to switch the two lines? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouka

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66476. mthw added a comment. un-capitalize REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66474&id=66476 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applets/ba

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. In D24070#534676 , @ngraham wrote: > Uh-oh, looks like there's a binding that isn't getting updated properly; the "time to charge/time to empty" number always reads as 0:00 for me: F7386917: Screenshot_20190919_092713.png <

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66474. mthw added a comment. re-added powermanagementDisabled and fixed white spaces REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66470&id=66474 BRANCH master REVISION DETAIL https://phabricator.k

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 66470. mthw added a comment. Made changes, according to instructions, tested, should work correctly REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66431&id=66470 BRANCH master REVISION DETAIL https:

D24070: Don't use Main text in Tooltip to show info, rather use second line

mthw created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mthw requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24070 AFFECTED FILES applets/batterymonitor/package/co

D22452: Fix text color in non-selected tabs in Firefox

mthw abandoned this revision. mthw added a comment. Someone else is working on this issue now, here: https://phabricator.kde.org/D23079 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: rikshaw, cblack, ndavis,

D22728: Provide a link to KInfoCenter

mthw added a comment. I personally like the alternative aproach, as it is what I had in mind when submitting the bug report. > - There isn't really a 100% appropriate parent category to put it in It could be the last item in the Hardware section. Also, IIRC Gnome does it like this (

D22452: Fix text color in non-selected tabs in Firefox

mthw added a comment. In D22452#495325 , @ngraham wrote: > Whether or not it's better is not relevant for this patch, which right now is only about fixing the text color. It's best not to mix multiple changes like this, unless you want to expand

D22452: Fix text color in non-selected tabs in Firefox

mthw updated this revision to Diff 61740. mthw added a comment. Replace hardcoding REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22452?vs=61733&id=61740 BRANCH fix-firefox-tab-text-color (branched from master) REVISION DETAIL https://phabricato

D22452: Fix text color in non-selected tabs in Firefox

mthw added a comment. Yes, I see it is different, but isn't it better now (after the patch)? https://imgur.com/a/aauVgPp REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: ndavis, zzag, plasma-devel, LeGast00n, j

D22452: Fix text color in non-selected tabs in Firefox

mthw added a comment. In D22452#495286 , @ndavis wrote: > This causes a problem with Breeze and Breeze Dark when the titlebar is enabled. > > With Patch > == > Breeze: F7021382: Screenshot_20190714_080027.png

D22452: Fix text color in non-selected tabs in Firefox

mthw added a comment. > ... it seems to do nothing ... The problem was that I tried to use a color name instead of a hex code and put a wrong name there (still don't know the correct one). REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To: mt

D22452: Fix text color in non-selected tabs in Firefox

mthw updated this revision to Diff 61733. mthw added a comment. Fixed wrong color name. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22452?vs=61731&id=61733 BRANCH fix-firefox-tab-text-color (branched from master) REVISION DETAIL https://phabr

D22452: Fix text color in non-selected tabs in Firefox

mthw planned changes to this revision. mthw added a comment. I seem to have some problems building this, I guess I need to change something in build files. Could you help me find it, I am new at this? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To: m

D22452: Fix text color in non-selected tabs in Firefox

mthw marked an inline comment as done. mthw added a comment. Yes I have tried with Breeze Dark, it works correctly. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To: mthw, #vdg, #breeze Cc: ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22452: Fix text color in non-selected tabs in Firefox

mthw added a comment. In D22452#495240 , @ndavis wrote: > Can you post a picture of what this change is supposed to do? Before: https://imgur.com/a/MqqgUQm After: https://imgur.com/a/gu5RV6M REPOSITORY R98 Breeze for Gtk REVISION DET

D22452: Fix text color in non-selected tabs in Firefox

mthw updated this revision to Diff 61731. mthw added a comment. Formatting REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22452?vs=61730&id=61731 BRANCH fix-firefox-tab-text-color (branched from master) REVISION DETAIL https://phabricator.kde.or

D22452: Fix text color in non-selected tabs in Firefox

mthw updated this revision to Diff 61730. mthw added a comment. Fixed duplicate. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22452?vs=61729&id=61730 BRANCH fix-firefox-tab-text-color (branched from master) REVISION DETAIL https://phabricator.

D22452: Fix text color in non-selected tabs in Firefox

mthw updated this revision to Diff 61729. mthw added a comment. Separate file and avoid hard-conding color. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22452?vs=61728&id=61729 BRANCH fix-firefox-tab-text-color (branched from master) REVISION DE

D22452: Fix text color in non-selected tabs in Firefox

mthw created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mthw requested review of this revision. REVISION SUMMARY Currently labels on tabs in firefox that are not selected are hard to read (black text on dark background). This fixes it. TEST PLAN L

D21869: Border for "separator_menu_item" should be 0

mthw added a comment. In D21869#481761 , @vzapod wrote: > In D21869#481760 , @mthw wrote: > > > Could this also land in Plasma/5.16? It's a crash fix after all. > > > Yeah, it should also land i

D21869: Border for "separator_menu_item" should be 0

mthw added a comment. Could this also land in Plasma/5.16? It's a crash fix after all. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21869 To: vzapod, #breeze, mthw, gepardo, jackg, ngraham Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, G

D21869: Border for "separator_menu_item" should be 0

mthw added a comment. In D21869#481734 , @ngraham wrote: > - A clear description of the problem to be solved, if this patch does not result in visual changes Sequencer64 crashes with the following message: (seq64:25899): WARNING **

D21869: Border for "separator_menu_item" should be 0

mthw added a comment. In D21869#481314 , @vzapod wrote: > In D21869#481305 , @mthw wrote: > > > Your change does fix the issue mentioned, so as long as this doesn't break anything, I would say it's g

D21869: Border for "separator_menu_item" should be 0

mthw accepted this revision. mthw added a comment. This revision is now accepted and ready to land. Your change does fix the issue mentioned, so as long as this doesn't break anything, I would say it's good enough. On the other hand, I only made one code change before, so I don't think, I a

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. Can you tell me why it didn't work for me? Was it some kind of permission issue or was I doing something wrong? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: filipf, ngraham, ndavis, pl

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. I tried to land this patch but I got this error: fatal: remote error: service not enabled: /breeze-gtk Usage Exception: Push failed! Fix the error and run "arc land" again. Could you help me with this? > Very nice first patch. May it be the first of ma

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59614. mthw added a comment. Formating REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59613&id=59614 BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION DETAIL https://phabricator

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59613. mthw added a comment. Sliders are now grey, and when hovered blue and bigger. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59383&id=59613 BRANCH breeze-gtk-scrollbar-no-background (branched from

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. > Firefox's scrollbar still does not have the correct appearance... Do you mean Firefox having blue scroollbar now, instead of grey it had before? Is that a real problem? I mean, couldn't it stay like this? The problem roots from default color now being blue instead

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. @ngraham Can you please review this? It's as good as I can make it. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: filipf, ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh,

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59383. mthw added a comment. There are lines that 'git diff' says are different altough shows them exactly the same and I don't know what to do with that. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=5938

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59382. mthw added a comment. Hopefully the final version REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59364&id=59382 BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION DETAIL h

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#476035 , @ngraham wrote: > In D21639#476019 , @mthw wrote: > > > I changed the color to always blue so it looked more like Dolphin. But I can change it back tomorrow.

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. I changed the color to always blue so it looked more like Dolphin. But I can change it back tomorrow. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: filipf, ngraham, ndavis, plasma-devel

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59364. mthw added a comment. Few more changes REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59362&id=59364 BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION DETAIL https://phab

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59362. mthw added a comment. I tried to make some changes but I doubt I caught all problems. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59352&id=59362 BRANCH breeze-gtk-scrollbar-no-background (branch

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. Is there an easy way to find all spots that need editing? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: filipf, ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragr

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. About that scrollbar hiding, after some googling it looks like it's a known problem in GTK+. It would seem that it cannot be changed by a theme or otherwise. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze,

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59352. mthw added a comment. An attempt to fix the number of lines. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59350&id=59352 BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59350. mthw added a comment. Scrollbars now should work exactly like in Dolphin, please review. Hope there are no problems with the file like last time. Everything looks fine here. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabrica

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#475884 , @filipf wrote: > You can also turn on the option to show trailing whitespace in Kate: > > F6876354: image.png I have set this and everything looks fine, I

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#475864 , @ngraham wrote: > Ah, this change only affects those horrible scrollbars that disappear when not being used and leave you unable to see at a glance what position you're at in the view or even that the vie

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#475858 , @ngraham wrote: > I didn't notice any difference with Firefox or GIMP. What app should I use to test this? GTK3-demo or pamac-manager, Firefox doesn't seem to be affected by this. And for Gtk 3.18

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. Another question is whether we don't want to keep the scrollbar background after all. That would make it look exactly like in Dolphin/Qt. See: https://imgur.com/a/2EeF7pp . The problem is I don't seem to be able to fix the horizontal scrollbar, see: https://imgur.com/a/

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59336. mthw added a comment. Made changes to Gtk 3.18 hopefully they work REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59324&id=59336 BRANCH breeze-gtk-scrollbar-no-background (branched from master) RE

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. I made that change, but I don't know if it works. I don't know a way to test it. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jrale

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#475790 , @ngraham wrote: > `src/gtk/widgets/_scrollbar.scss` needs the same change as well. Do you mean 'src/gtk318/widgets/_scrollbar.scss'? There is no 'src/gtk/widgets/_scrollbar.scss' REPOSITORY R98

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59324. mthw added a comment. None is not a valid color warning REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59317&id=59324 BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION DETA

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#475649 , @ndavis wrote: > This seems inconsistent with our Qt Widget scrollbars... Do you mean by this, that there should be a "rail" behind the scrollbar? Or what else seems to be the problem? REPOSITORY

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. The original idea was to make the scrollbar look more like in Dolphin and other Qt apps. I tested this with gtk3-demo, pamac-manager and Firefox. Everything works correctly and Firefox doesn't seem to be affected at all. Also Breeze dark doesn't seem to be affected/chan

D21639: First commit

mthw created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mthw requested review of this revision. REVISION SUMMARY Current gtk scrollbars have background that doesn't look very good and removing it makes scrollbars look better/more smilar to scrollbars