D12536: [timer applet] Change how time is tracked

2018-04-26 Thread Mariusz Mazur
mmazur added a comment. In D12536#254280 , @davidedmundson wrote: > > I was hoping the reviewer wouldn't notice. > > :/ > Had you said it explicitly I probably would have been fine with it. I'm operating on the assumption that work

D12536: [timer applet] Change how time is tracked

2018-04-26 Thread Mariusz Mazur
mmazur added inline comments. INLINE COMMENTS > mmazur wrote in TimerView.qml:56 > I wasn't aware that Date().getTime() wasn't in UTC. I can change it to a UTC > call if there is one. > > I'm aware of the sleep behavior change, however I do not know how to handle > it. (I was hoping the review

D12536: [timer applet] Change how time is tracked

2018-04-26 Thread Mariusz Mazur
mmazur added inline comments. INLINE COMMENTS > davidedmundson wrote in TimerView.qml:54 > that's a lot of wakeups. Do you really need to do this? Typical display is 60Hz, so 16.6 ms per frame. A 20ms interval means each clock tick will be displayed between 58-62 frames after the previous one,

D12535: [timer applet] disable animation on timer pause

2018-04-26 Thread Mariusz Mazur
mmazur added a comment. Initially a few years ago when I went kde5 I made this patch because of the cpu usage, which was stupid high (and it seems I'm not the only one that noticed). Some time later it occurred to me that it has the added benefit of my desktop not blinking at me when I want

D12536: [timer applet] Change how time is tracked

2018-04-26 Thread Mariusz Mazur
mmazur created this revision. mmazur added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mmazur requested review of this revision. REVISION SUMMARY Stop relying on QtQuicks Timer type to be precise and instead use s

D12535: [timer applet] disable animation on timer pause

2018-04-26 Thread Mariusz Mazur
mmazur created this revision. mmazur added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mmazur requested review of this revision. REVISION SUMMARY The animation is surprisingly cpu heavy at times and really distracti

D12534: [timer applet] Fix internal function calls

2018-04-26 Thread Mariusz Mazur
mmazur created this revision. mmazur added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mmazur requested review of this revision. REVISION SUMMARY root.digitChanged() doesn't exist, main.digitChanged() does REPOSITO

D12533: [timer applet] Unify QtQuick imports

2018-04-26 Thread Mariusz Mazur
mmazur created this revision. mmazur added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mmazur requested review of this revision. REVISION SUMMARY Import 2.2 everywhere REPOSITORY R114 Plasma Addons BRANCH time

Review Request 108458: Fix webslice's handling of page resizes

2013-01-18 Thread Mariusz Mazur
sting --- I've been using it on my desktop for a month now, no problems noticed. Thanks, Mariusz Mazur ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel