D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mbehrendt added a comment. Okay. I just tested with other themes. Was so used to Materia that I forgot about them. Yeah an option would make sense then. I'd like to look into this but that will probably take some time. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mbehrendt added a comment. In D27939#624440 , @mvourlakos wrote: > I think it is better to have an option for this in order to not be applied always when the user reverses the indicator.. > > And also are you sure that this way the growing c

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mbehrendt created this revision. mbehrendt added a reviewer: mvourlakos. mbehrendt added a project: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mbehrendt requested review of this revision. REVISION SUMMARY The triangle indicating window grouping would not

D17467: digital-clock: Show events on initial expansion for all time zones

mbehrendt added inline comments. INLINE COMMENTS > mart wrote in CalendarView.qml:60 > another way you can try is to do it on Component.onCompleted: { } Yes I laready considered that. But when I tried your suggestion, I figured out what the real problem was that the events are initially not sh

D17467: digital-clock: Show events on initial expansion for all time zones

mbehrendt marked an inline comment as done. mbehrendt added inline comments. INLINE COMMENTS > mart wrote in CalendarView.qml:60 > instead of storing a local hasExpanded, could you just check for > holidaysList.model not being null? No, the model initially seems to be an empty list. REPOSITORY

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47409. mbehrendt added a comment. remove local variable "currentDate" and use "getDate" instead of "getDay" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17467?vs=47407&id=47409 REVISION DETAIL https://ph

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47407. mbehrendt added a comment. Total overhaul of the patch. I think I found the root cause for the events not being displayed. I also inserted some if clauses to reduce calculations. I also removed setting holidaysList.model = null as I could n

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47317. mbehrendt added a comment. more simplifications REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17467?vs=47256&id=47317 REVISION DETAIL https://phabricator.kde.org/D17467 AFFECTED FILES applets/di

D17467: digital-clock: Show events on expanding applet

mbehrendt added a reviewer: Plasma. mbehrendt added a comment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17467 To: mbehrendt, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47256. mbehrendt marked an inline comment as done. mbehrendt added a comment. fix typos REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17467?vs=47255&id=47256 REVISION DETAIL https://phabricator.kde.org/D1

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47255. mbehrendt added a comment. only once set hasExpanded = true REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17467?vs=47252&id=47255 REVISION DETAIL https://phabricator.kde.org/D17467 AFFECTED FILES

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47252. mbehrendt added a comment. This should even be lighter REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17467?vs=47248&id=47252 REVISION DETAIL https://phabricator.kde.org/D17467 AFFECTED FILES app

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47248. mbehrendt added a comment. Besides checking for isExpanded this prevents from updating the holidaysList twice by checking if the date needs to be reset. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D17467: digital-clock: Show events on expanding applet

mbehrendt created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mbehrendt requested review of this revision. REVISION SUMMARY When expanding the digital-clock applet the holidayList is not updated, so that events for the current day are not shown. In