D11482: Export Translations to right filename

leszeklesner added a comment. In D11482#229987 , @davidedmundson wrote: > ... > Leszek which were the strings that renderered incorrectly? > Have you tried renaming your local .po file to see if it does fix things? The issue actual

D11482: Export Translations to right filename

leszeklesner created this revision. leszeklesner added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. leszeklesner requested review of this revision. REVISION SUMMARY It exports its qml translations to plasmavault-kde

D5942: Check if plymouth file is known to update-alternatives before setting

leszeklesner updated this revision to Diff 14776. leszeklesner added a comment. Fixed qDebug typo. REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5942?vs=14772&id=14776 REVISION DETAIL https://phabricator.kde.org/D5942 AFFECTED FILES src/helper.c

D5943: Set kauth timeout to timeout for the update-initramfs -u process

leszeklesner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We need to set the timeout for kauth to at least the same as that for the update-initramfs -u process (which is 6msec) otherwise DBUS

D5942: Check if plymouth file is known to update-alternatives before setting

leszeklesner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If the plymouth theme is not known to update-alternatives trying to execute update-alternatives --set will always fail. As plymouth kc

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner updated this revision to Diff 13771. leszeklesner added a comment. Updated to solution by qi437103 which implements a mousehelper to get the global mouse position so we can distinguish between mouse being inside the resultslistview or outside REPOSITORY R112 Milou CHANGES SIN

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner added a comment. In https://phabricator.kde.org/D5490#103680, @qi437103 wrote: > what about set moved variable according to global mousre position instead? I know this is possible with QCursor, but not sure if it's possible at qml side, though. I haven't looked at the code y

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner added a comment. In https://phabricator.kde.org/D5490#103642, @davidedmundson wrote: > If I have the mouse outside the window, and then deliberately move the mouse in to select something, by design, this won't update the index the first time. > > It'll fix your bug, sure

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner edited the summary of this revision. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, ab

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner added a comment. In https://phabricator.kde.org/D5490#103059, @lfurmetz wrote: > In https://phabricator.kde.org/D5490#103053, @anthonyfieroni wrote: > > > You can do this: > > > > property bool moved: false > > onMovedChanged: if (moved) { > > listView.cu

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner updated this revision to Diff 13568. leszeklesner edited the summary of this revision. REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5490?vs=13561&id=13568 REVISION DETAIL https://phabricator.kde.org/D5490 AFFECTED FILES lib/qml/ResultDelegate

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner added a comment. In https://phabricator.kde.org/D5490#103049, @davidedmundson wrote: > Yes, and you have this boolean separately for each delegate. > > So I can see how this supresses that initial selection in your bug report; but surely it will also supress every other n

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner added a comment. In https://phabricator.kde.org/D5490#103036, @davidedmundson wrote: > Yes, I can see what the code is doing, but I don't see how that means it works. > > > will be then set to true so that when you move the mouse on an item onContainsMouseChanged is call

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner added a comment. In https://phabricator.kde.org/D5490#103017, @davidedmundson wrote: > Copying my reply from RB, to keep this in one place: > > Sorry for being dim, but I don't understand how this is meant to work. Basically it should not set the currentIndex to in

D5490: Only follow mouse when moved (Fixes Bug #372635)

leszeklesner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use a new variable __moved to detect if mouse moved and only change index if the mouse moved. This helps preventing index changes when on

Re: Review Request 124727: Documentation for PlasmaComponents Menu

marked as submitted. Review request for Plasma. Changes --- Submitted with commit a7b438ece49547be07ea10c1ed3e06dd92591967 by David Edmundson on behalf of Leszek Lesner to branch master. Repository: plasma-framework Description --- Add documentation for declarative menu

Review Request 124727: Documentation for PlasmaComponents Menu

--- Add documentation for declarative menu (PlasmaComponents.Menu) Diffs - src/declarativeimports/plasmacomponents/qmenu.h 6cf0096 Diff: https://git.reviewboard.kde.org/r/124727/diff/ Testing --- Thanks, Leszek Lesner ___ Plasma

Re: Review Request 117481: Remove "Open Wallpaper Image" entry on the menu

> On April 10, 2014, 3:01 p.m., Vishesh Handa wrote: > > Ship It! Ship it and remove the entry also for slideshow. Add instead a Open slideshow folder button in slideshow settings dialog which opens selected slideshow folder. - Leszek --

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

and you don't give you a ship it to > > yourself and then maybe others will have a look at it. > > Leszek Lesner wrote: > If I would know hot to attach the diff properly I would have done it. It > is just not recognizing the patch. > > Albert Astals Cid wrote: >

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

and you don't give you a ship it to > > yourself and then maybe others will have a look at it. > > Leszek Lesner wrote: > If I would know hot to attach the diff properly I would have done it. It > is just not recognizing the patch. > > Albert Astals Cid wrote: >

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108325/#review30476 --- On Jan. 10, 2013, 3:18 p.m., Leszek Lesner wrote: > > --- > This i

Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108325/#review25831 --- Ship it! Ship It! - Leszek Lesner On Jan. 10, 2013, 3:18

Review Request: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

reen. Thanks, Leszek Lesner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel