lisin updated this revision to Diff 63407.
lisin added a comment.
Sure, I've added the comment
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23039?vs=63398&id=63407
REVISION DETAIL
https://phabricator.kde.org/D23039
AFFECTED FILES
applets/kick
lisin updated this revision to Diff 63398.
lisin added a comment.
Added `isChildOf(source, favoritesView)` which is probably needed.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23039?vs=63397&id=63398
REVISION DETAIL
https://phabricator.kde.org
lisin added a comment.
I was reluctant to introduce a new variable with such a broad scope
(`kickoff.dragStartRow`) but using the `startRow` from `DropArea` would
sometimes still mess up the order - the item would get the new value of
`startRow` if the user moved the cursor back inside `Drop
lisin created this revision.
lisin added reviewers: Plasma, ngraham, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
lisin requested review of this revision.
REVISION SUMMARY
This fixes the undesired reordering of the favorites which could happen when
dragging an
lisin added a comment.
Yes, getting into it was pretty straightforward and quick, KDE team did a
great job!
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D22988
To: lisin, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragr
lisin added a comment.
Thank you, this was my first ever contribution to FOSS!
I have submitted the fix for the TabBar here:
https://phabricator.kde.org/D23036
I'm not quite sure about who to add as reviewers though.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.
lisin updated this revision to Diff 63369.
lisin edited the summary of this revision.
lisin edited the test plan for this revision.
lisin added a comment.
Removed line 435.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22988?vs=63264&id=63369
REVIS
lisin added a comment.
I also couldn't reproduce the gray overlay (which is caused by
`tabBarSeparator` having a wrong size and taking the whole view - yesterday I
could reproduce it but no more) that is shown in the comment 16 here:
https://bugs.kde.org/show_bug.cgi?id=395390#c16
So it m
lisin created this revision.
lisin added reviewers: Plasma, hein, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
lisin requested review of this revision.
REVISION SUMMARY
This fixes the incorrect initial positioning of the tab bar (first tab is
placed out of b
lisin added a comment.
Line `onHeightChanged: onWidthChanged()` fixes BUG: 395390
I'm not sure if this is the best solution. For some reason,
`plasmacomponents/qml/TabBar.qml` lacks an `onHeightChanged()` function but it
has `onWidthChanged()` that seems to do what needs to happen here. May
10 matches
Mail list logo
