Re: CI Utilisation and system efficiency

2025-04-22 Thread Konstantin Kharlamov
On Tue, 2025-04-22 at 07:15 +1200, Ben Cooksley wrote: > On Tue, Apr 22, 2025 at 5:57 AM Dmitry Kazakov > wrote: > > Hi, Ben! > > > > > Hey Dmitry, >   > > > > As for Krita, most of CI time is spent on the Windows pipeline, > > which build extremely slowly due to done obscure filesystem issues

How Plasma/Kickoff app launcher always opening aligned horizontally to the center of the screen

2024-01-01 Thread Konstantin Makarov
Hello, How can I make the Plasma/Kickoff app launcher always opening aligned horizontally to the center of the screen? I know that if I place the app launcher icon (button) on a center aligned panel, the app launcher opens in the center position of the screen. But if the app launcher icon ha

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

2023-08-30 Thread Konstantin Kharlamov
https://bugs.kde.org/show_bug.cgi?id=304696 --- Comment #24 from Konstantin Kharlamov --- (In reply to Paul Gideon Dann from comment #23) > Is there some migration so that the currently-configured timeout doesn't > suddenly double at the next upgrade? Some of us have since con

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

2023-08-29 Thread Konstantin Kharlamov
https://bugs.kde.org/show_bug.cgi?id=304696 Konstantin Kharlamov changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

2023-08-22 Thread Konstantin Kharlamov
https://bugs.kde.org/show_bug.cgi?id=304696 Konstantin Kharlamov changed: What|Removed |Added CC||hi-an...@yandex.ru --- Comment #19 from

Re: “Application Launcher 2.0” - New (simple) Feature Request

2021-03-24 Thread Konstantin Kharlamov
On Tue, 2021-03-16 at 10:35 +0100, Marco Uguccioni wrote: > Dear Mr. Martin Graesslin & Mr. Mikel Johnson, > > I am writing you to kindly request a new feature  > in the new version of the Kickoff Menu which will be released with Plasma 5.21 > Stable: Should this suggestion go to a bugtracker ins

D23039: Make Kickoff restore favorites order when dragging an item to desktop

2019-08-09 Thread Konstantin Lisin
lisin updated this revision to Diff 63407. lisin added a comment. Sure, I've added the comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23039?vs=63398&id=63407 REVISION DETAIL https://phabricator.kde.org/D23039 AFFECTED FILES applets/kick

D23039: Make Kickoff restore favorites order when dragging an item to desktop

2019-08-09 Thread Konstantin Lisin
lisin updated this revision to Diff 63398. lisin added a comment. Added `isChildOf(source, favoritesView)` which is probably needed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23039?vs=63397&id=63398 REVISION DETAIL https://phabricator.kde.org

D23039: Make Kickoff restore favorites order when dragging an item to desktop

2019-08-09 Thread Konstantin Lisin
lisin added a comment. I was reluctant to introduce a new variable with such a broad scope (`kickoff.dragStartRow`) but using the `startRow` from `DropArea` would sometimes still mess up the order - the item would get the new value of `startRow` if the user moved the cursor back inside `Drop

D23039: Make Kickoff restore favorites order when dragging an item to desktop

2019-08-09 Thread Konstantin Lisin
lisin created this revision. lisin added reviewers: Plasma, ngraham, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lisin requested review of this revision. REVISION SUMMARY This fixes the undesired reordering of the favorites which could happen when dragging an

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

2019-08-08 Thread Konstantin Lisin
lisin added a comment. Yes, getting into it was pretty straightforward and quick, KDE team did a great job! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22988 To: lisin, #plasma, hein, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragr

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

2019-08-08 Thread Konstantin Lisin
lisin added a comment. Thank you, this was my first ever contribution to FOSS! I have submitted the fix for the TabBar here: https://phabricator.kde.org/D23036 I'm not quite sure about who to add as reviewers though. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

2019-08-08 Thread Konstantin Lisin
lisin updated this revision to Diff 63369. lisin edited the summary of this revision. lisin edited the test plan for this revision. lisin added a comment. Removed line 435. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22988?vs=63264&id=63369 REVIS

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

2019-08-07 Thread Konstantin Lisin
lisin added a comment. I also couldn't reproduce the gray overlay (which is caused by `tabBarSeparator` having a wrong size and taking the whole view - yesterday I could reproduce it but no more) that is shown in the comment 16 here: https://bugs.kde.org/show_bug.cgi?id=395390#c16 So it m

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

2019-08-07 Thread Konstantin Lisin
lisin created this revision. lisin added reviewers: Plasma, hein, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lisin requested review of this revision. REVISION SUMMARY This fixes the incorrect initial positioning of the tab bar (first tab is placed out of b

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

2019-08-07 Thread Konstantin Lisin
lisin added a comment. Line `onHeightChanged: onWidthChanged()` fixes BUG: 395390 I'm not sure if this is the best solution. For some reason, `plasmacomponents/qml/TabBar.qml` lacks an `onHeightChanged()` function but it has `onWidthChanged()` that seems to do what needs to happen here. May

Re: CI system maintainability

2019-03-28 Thread Konstantin Kharlamov
On Чт, Mar 28, 2019 at 19:40, Ben Cooksley wrote: Hi all, We currently have a rather substantial issue, in that the CI system has been once again left in a position where it isn't possible to make any changes to the system. This means we can't update to newer versions of packages, add new p

D10461: GMenu-DBusMenu-Proxy

2018-02-14 Thread Konstantin
rilian added a comment. UPD: disabled an exporting of empty menubar on X11. Try latest appmenu-gtk-module master, please. I do not know how to do it in GTK Wayland. Can you explain me KDE Wayland Global Menu architecture? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://ph

D10461: GMenu-DBusMenu-Proxy

2018-02-14 Thread Konstantin
rilian added a comment. If you need help, I will provide it for you, because for me there is 2 features which should be in KDE for me: 1. Global Menu (for all protocols) 2. QGtkStyle (with GTK3 themes) > Okay. Problem is that for example LibreOffice doesn't have a menu right

D10461: GMenu-DBusMenu-Proxy

2018-02-14 Thread Konstantin
rilian added a comment. What about FIXME unity, what are you mean? I can fix appmenu-gtk-module for you. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10461 To: broulik, #plasma Cc: rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, progwolff, lesliezha

D10461: GMenu-DBusMenu-Proxy

2018-02-14 Thread Konstantin
rilian added a comment. O, some another note: You can generate menubar from appmenu. For example, Nautilus: It have 4 sections 1. New Window 2. Sidebar 3. Preferences 4. Keyboard Shortcuts Help About Quit. You can add New Window and Quit to File menu, Sidebar to View, Prefer

D10461: GMenu-DBusMenu-Proxy

2018-02-14 Thread Konstantin
rilian added a comment. 1. Yes, menubar may be empty with appmenu-gtk-module or unity-gtk-module, and if I can fix appmenu-gtk-module, unity-gtk-module will not be fixed. So, I think it is preferred to check on your side. 2. GTK3 applications (file-roller, for example) can use both appmenu

D10461: GMenu-DBusMenu-Proxy

2018-02-14 Thread Konstantin
rilian added a comment. Thanks so much) 1. Unity is dead, but I forked unity-gtk-module, patched it for all distros, fixed some bugs and called appmenu-gtk-module. So, Unity is dead, but unity action prefixes is live. 2. To use unity-gtk-module or appmenu-gtk-module you need to install

D10461: GMenu-DBusMenu-Proxy

2018-02-13 Thread Konstantin
rilian added a comment. Hello, I am Konstantin, developer of vala-panel-appmenu. I have some comments about your application. MenuModel protocol consitsts for 5 items: AppMenu - with property _GTK_APPMENU_OBJECT_PATH MenuBar - with property _GTK_MENUBAR_OBJECT_PATH It is a

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-26 Thread Konstantin Shtepa
konstantinshtepa added a comment. In https://phabricator.kde.org/D4204#80553, @davidedmundson wrote: > Though really any max > min on the client is undefined behaviour, so it's hard to say any is "right". You are right. It's undefined behaviour. At current state there is a hole in

[Differential] [Updated, 305 lines] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-26 Thread Konstantin Shtepa
konstantinshtepa updated this revision to Diff 10599. konstantinshtepa added a comment. Fixed littke bug which would happend with code plasmoid.Layout.minimumHeight = 150 plasmoid.Layout.maximumHeight = 130 plasmoid.Layout.maximumHeight = 150 Bug led to maximumHeight = 150 w

[Differential] [Updated] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-26 Thread Konstantin Shtepa
konstantinshtepa updated the summary for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4204 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: konstantinshtepa, #plasma Cc: mart, davidedmundson, plasma-devel, les

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-26 Thread Konstantin Shtepa
konstantinshtepa added inline comments. INLINE COMMENTS > davidedmundson wrote in AppletAppearance.qml:445 > Edit, maybe it won't - that's why you have the separate Binding. > > However changing this to: > minimumWidth: Math.min(minimumSize.width, maximumSize.width); > > for all 4 > > would st

[Differential] [Updated, 297 lines] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-26 Thread Konstantin Shtepa
konstantinshtepa updated this revision to Diff 10593. konstantinshtepa marked an inline comment as done. konstantinshtepa added a comment. Removed Bindings REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4204?vs=10453&id=10593 BRANCH plasmoid_size_

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-25 Thread Konstantin Shtepa
konstantinshtepa added a comment. In https://phabricator.kde.org/D4204#80142, @mart wrote: > what i would like to have logically splitted is the management of the floating property (and having positionItem()/releasePosition used around) > > and on the other hand the signal handlers of

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-25 Thread Konstantin Shtepa
konstantinshtepa added inline comments. INLINE COMMENTS > davidedmundson wrote in AppletAppearance.qml:445 > Edit, maybe it won't - that's why you have the separate Binding. > > However changing this to: > minimumWidth: Math.min(minimumSize.width, maximumSize.width); > > for all 4 > > would st

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-25 Thread Konstantin Shtepa
konstantinshtepa added inline comments. INLINE COMMENTS > davidedmundson wrote in AppletAppearance.qml:445 > Edit, maybe it won't - that's why you have the separate Binding. > > However changing this to: > minimumWidth: Math.min(minimumSize.width, maximumSize.width); > > for all 4 > > would st

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-25 Thread Konstantin Shtepa
konstantinshtepa added inline comments. INLINE COMMENTS > davidedmundson wrote in AppletAppearance.qml:101 > this is broken. > > if I'm an applet and do: > Plasmoid.Layout.maximumWidth = 50 > > this appletItem.maximumWidth == 58 (assuming 4px margins) > which is correct > > Now if I do: > >

[Differential] [Updated] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-25 Thread Konstantin Shtepa
konstantinshtepa updated the summary for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4204 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: konstantinshtepa, #plasma Cc: mart, davidedmundson, plasma-devel, les

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-25 Thread Konstantin Shtepa
konstantinshtepa added a comment. In https://phabricator.kde.org/D4204#80106, @mart wrote: > can this be splitted in multiple reviews/commits? It can be splitted into multiple commits inside one branch so you can view what exactly fix what. But multiple reviews based on master? I

[Differential] [Updated, 305 lines] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-23 Thread Konstantin Shtepa
konstantinshtepa updated this revision to Diff 10453. konstantinshtepa added a comment. Rewrited some code to better understanding Fixed background-handle animation in plasmoidBackground. It was a little bug, but I don't see any sense to report it now when patch are ready. Fixed it by chang

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-23 Thread Konstantin Shtepa
konstantinshtepa added a comment. A detailed explanation of bugs, fixes and mechanics changes === Before anything else I'd like to explain why I need this patch. At winter holidays I had a free time and decided to rewrite plasma-si

[Differential] [Updated] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-23 Thread Konstantin Shtepa
konstantinshtepa updated the summary for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4204 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: konstantinshtepa, #plasma Cc: davidedmundson, plasma-devel, lesliezha

[Differential] [Updated, 310 lines] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-23 Thread Konstantin Shtepa
konstantinshtepa updated this revision to Diff 10447. konstantinshtepa added a comment. Fix commit message REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4204?vs=10446&id=10447 BRANCH plasmoid_size_restraints REVISION DETAIL https://phabricator

[Differential] [Updated, 310 lines] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-23 Thread Konstantin Shtepa
konstantinshtepa updated this revision to Diff 10446. konstantinshtepa added a comment. Turn on background width animation again. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4204?vs=10408&id=10446 BRANCH plasmoid_size_restraints REVISION DETAI

[Differential] [Updated, 318 lines] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-21 Thread Konstantin Shtepa
konstantinshtepa updated this revision to Diff 10408. konstantinshtepa added a comment. Rewrited commit message in according to kde commit polititcs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4204?vs=10407&id=10408 BRANCH plasmoid_size_restrai

[Differential] [Updated] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-21 Thread Konstantin Shtepa
konstantinshtepa updated the summary for this revision. konstantinshtepa updated the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4204 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: konstantins

[Differential] [Updated, 318 lines] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-21 Thread Konstantin Shtepa
konstantinshtepa updated this revision to Diff 10407. konstantinshtepa added a comment. Summary: reworked set of patches to plasma-desktop/containments/desktop to fix bugs in plasmoid. Fix for - plasmoid applet missing maximum size handler - plasmoid can't be set to declared minimumW

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-20 Thread Konstantin Shtepa
konstantinshtepa added a comment. WARNING: Found a bug with plasmoid don't free all his space in LayoutManager when changed from compactRepresentation to fullRepresentation. Don't push this patch before I fix this bug. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.k

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-19 Thread Konstantin Shtepa
konstantinshtepa added a comment. In https://phabricator.kde.org/D4204#78701, @davidedmundson wrote: > That's quite a huge patch. > Can you give a much bigger explanation on exactly what it's doing and why. > "Fixes bug N" doesn't really explain what the original problem was.

[Differential] [Changed Policy] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

2017-01-19 Thread Konstantin Shtepa
konstantinshtepa changed the visibility from "konstantinshtepa (Konstantin Shtepa)" to "Public (No Login Required)". konstantinshtepa changed the edit policy from "konstantinshtepa (Konstantin Shtepa)" to "All Users". REPOSITORY R119

[Differential] [Request, 320 lines] D4204: Added max size restrictions handlers for plasmoids

2017-01-19 Thread Konstantin Shtepa
konstantinshtepa created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Signed-off-by: Konstantin Shtepa first step release commit. Bugs fixed, plasmoid behaves as expected. Signed-off-by

Re: [Development] Qt Quick Controls Calendar

2014-01-07 Thread Konstantin Ritt
I've missed that, sorry. Can we discuss the code right in the https://codereview.qt-project.org/#change,73340 's diff? Regards, Konstantin 2014/1/2 Mitch Curtis > On 12/22/2013 05:51 AM, Konstantin Ritt wrote: > >> During the testing, we've found a bunch of