vitali added a comment.
*ping* :)
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D5729
To: vitali, sebas
Cc: Zren, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
vitali added a comment.
So, what do we want to do with this patch?
I've been using it for a week now, and didn't notice any problems. Has anyone
else been testing it?
As for the link, I am for keeping the http version, as it is the one used by
NatGeo, so it would be less likely to be b
vitali planned changes to this revision.
vitali added inline comments.
INLINE COMMENTS
> natgeoprovider.cpp:61
> +
> +
> re.setPattern("^$");
> +
An alternative regex may be
`"^$"`, so to match any
possible future fields before `property`, and between `property` and `content`.
> sebas wro
https://bugs.kde.org/show_bug.cgi?id=379003
--- Comment #10 from Juri Vitali ---
(In reply to Sebastian Kügler from comment #9)
Sure thing!
I cleaned the patch up a bit, and posted it on Phabricator.
Here it is: https://phabricator.kde.org/D5729
--
You are receiving this mail because:
You
vitali created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The current parsing mechanism to obtain the current NatGeo POTD based on XML
is broken, this patch proposes an alternative mechanism using
QRe
https://bugs.kde.org/show_bug.cgi?id=379003
--- Comment #8 from Juri Vitali ---
Created attachment 105363
--> https://bugs.kde.org/attachment.cgi?id=105363&action=edit
NatGeo POTD patch
I implemented a quick and dirty patch to parse the page using
QRegularExpression, and it seem
https://bugs.kde.org/show_bug.cgi?id=369676
Juri Vitali changed:
What|Removed |Added
CC||j...@dbzero.it
--- Comment #3 from Juri Vitali
