ouwerkerk abandoned this revision.
ouwerkerk added a comment.
With the move to gitlab/invent.kde.org it seems better to abandon this in
favour of a straightforward MR using the new shiny :)
See: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/1
REPOSITORY
R116 Plasma Network Man
ouwerkerk created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
ouwerkerk requested review of this revision.
REVISION SUMMARY
It is possible for key-direction to be specified *after* .
Previously the code always expec
On Fri, May 1, 2020 at 6:38 AM Nate Graham wrote:
>
> On 4/30/20 5:59 PM, Aleix Pol wrote:
> > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid
> >> Am I the only person that just has all the repos on the same folder? I
> >> thought it was the common thing to do :?
> >
> > I do too
>
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:57c63e7ceeb9: Couple of 'trivial' fixes for
broken code (authored by ouwerkerk).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28730?vs=79789&id=80413
REVISION D
On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk wrote:
>
> >
> > We may need to do on-the-fly conversion of the kde: repo paths if they
> > won't be expressible as 'kde:foo' in the future, but we should have the
> > information needed to do this in kdesr
On Sun, Apr 12, 2020 at 1:06 AM Ben Cooksley wrote:
>
> On Sun, Apr 12, 2020 at 11:04 AM Johan Ouwerkerk
> wrote:
> >
> > On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk
> > wrote:
> > >
> > > Yes the only reason why a cleanup script might b
On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk wrote:
>
> Yes the only reason why a cleanup script might be needed is if the
> logical path used to express the repo in dependency information
> changes at the same time. E.g. suppose a `frameworks/kf5foo` gets
> remapped to `fra
On Sat, Apr 11, 2020 at 11:03 PM Michael Pyne wrote:
>
> On Sat, Apr 11, 2020 at 09:25:11PM +0200, Johan Ouwerkerk wrote:
>
> >
> > A cleanup script could be handy. I think kdesrc-build will
> > automatically pick up new repo paths from metadata and that should
> >
On Sat, Apr 11, 2020 at 9:01 PM Nicolás Alvarez
wrote:
>
> How would it work during the "grace period"? Keeping an outdated read-only
> mirror on the old URL? I have done some research into redirecting or
> remapping from the old URL to the new one so we can keep it working for a
> longer perio
On Sat, Apr 11, 2020 at 8:39 PM Ben Cooksley wrote:
>
> Yes, the hostname git.kde.org will be fully retired as part of this
> transition.
>
> From my understanding kdesrc-build will automatically pick this up
> once we update sysadmin/repo-metadata to show the new repository
> paths.
> This is so
On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote:
>
> Should anyone have any questions on the above, please let us know.
>
Does the migration also mean that `git.kde.org` push URL will be
retired and would need to be remapped to `invent.kde.org`?
In that case, it would be good to have a grace
On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote:
>
> To help assist with this, it would be appreciated if all holders of a
> KDE Developer account could please login on our Gitlab instance (at
> https://invent.kde.org/) and ensure they are listed as a 'Developer'
> of the KDE group. You can do
ouwerkerk created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ouwerkerk requested review of this revision.
REVISION SUMMARY
Issues were found by running code with QT_QUICK_CONTROLS_MOBILE=1
- `Units` does not exist in SwipeListItem due to how Ki
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:c9bbe6dea5a1: Add useful input method hints to password
field by default (authored by ouwerkerk).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28316?vs=78579&id=
ouwerkerk created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ouwerkerk requested review of this revision.
REVISION SUMMARY
Hint that input methods should treat the password as sensitive and avoid
applying "auto-correct" features as well.
REPOSITO
On Sun, Mar 22, 2020 at 3:20 AM Ben Cooksley wrote:
>
> We already do have a repository of artifacts :)
> You can find the public view of this at
> https://build-artifacts.kde.org/production/
>
>
> We already use Virtual Machines for both FreeBSD and Windows.
>
> The main problem here is that the
On Sat, Mar 21, 2020 at 10:27 PM Ben Cooksley wrote:
>
> On Sun, Mar 22, 2020 at 3:27 AM Johan Ouwerkerk
> wrote:
> >
> > On Sat, Mar 21, 2020 at 1:32 AM Ben Cooksley wrote:
> > >
> > > Comments welcome. Please note that simply fixing the dependency
>
On Sat, Mar 21, 2020 at 1:32 AM Ben Cooksley wrote:
>
> Comments welcome. Please note that simply fixing the dependency
> breakage in this case is not enough to resolve this - there are
> underlying issues which need to be addressed here.
>
> Regards,
> Ben Cooksley
> KDE Sysadmin
I cannot commen
ouwerkerk abandoned this revision.
ouwerkerk added a comment.
Cleanup.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D24193
To: ouwerkerk, mart, #plasma, ngraham
Cc: ngraham, anthonyfieroni, plasma-devel, fbampaloukas, GB_2, domson,
dkardarakos, apol, ahiemstra, d
ouwerkerk abandoned this revision.
ouwerkerk added a comment.
Superseded by: https://phabricator.kde.org/D26367
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26344
To: ouwerkerk, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1c43e1b4f7b1: Make the lookandfeel KCM build without
XCursor support (authored by ouwerkerk).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26367?vs=72617&i
ouwerkerk created this revision.
ouwerkerk added a reviewer: davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ouwerkerk requested review of this revision.
REVISION SUMMARY
With this change the lookandfeel KCM can be built without X11 cursor
development he
ouwerkerk added a comment.
Are we certain about naming here: `SwipeAction.isDelete`? Maybe
`SwipeAction.remove` or `SwipeAction.removeFromList` ? It doesn't necessarily
have to be a real "delete" action that is backing this, maybe all you want to
convey with the name of this setting is that
ouwerkerk added a comment.
Right now the KCM CmakeListst does stuff like:
set(kcm_lookandfeel_SRCS
kcmmain.cpp
kcm.cpp
../krdb/krdb.cpp
../cursortheme/xcursor/cursortheme.cpp
../cursortheme/xcursor/xcursortheme.cpp
)
And the main `kcm.cpp` simply in
ouwerkerk updated this revision to Diff 72544.
ouwerkerk added a comment.
Fixed commit message typo
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26344?vs=72542&id=72544
BRANCH
fix-build-without-cursors
REVISION DETAIL
https://phabricator.kde.
ouwerkerk created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ouwerkerk requested review of this revision.
REVISION SUMMARY
The lookandfeel KCM has a hard dependency on xcursor code of the cursor KCM.
This change updates the CMake code to reflect thi
ouwerkerk added a comment.
This completely alters one of the core propositions of how a Kirigami UX
works. I may be mistaken, but if I understand it correctly drawers are supposed
to be accessible via buttons. If gestures conflict, why remove page row
navigation by gesture rather than drawer
ouwerkerk added a comment.
Also side note, as a non-native English speaker I find "grossly" to be a bit
of an odd adjective to use here -- "coarsely" would be more familiar: as in
fine/coarse grained. Perhaps something to keep in mind when this lands and you
start blogging about it :)
REPOS
ouwerkerk added a comment.
Ideally you would also warn if the reciprocal times the horizontal, vertical
resolution yields a non-integer output, not just if some value is chosen which
cannot be represented in floating point exactly.
E.g. on a 4K (3840 × 2160) a scaling factor of 1.5 is fi
ouwerkerk added a comment.
And if so, sure I can 'fix' this by downgrading to QQC 2.4 instead but in
that case: is this 'safe'? I.e. does this introduce bugs/regressions?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D24193
To: ouwerkerk, mart, #plasma
Cc: anthony
ouwerkerk added a comment.
If Kirigami is supposed to depend on Qt 5.11, then *why* were these old
imports there in the first place? They cannot work with Qt 5.11, because then
the max QQC version is 2.4
Maybe I am misunderstanding something here? Are you saying the old Kirigami
code ef
ouwerkerk created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ouwerkerk requested review of this revision.
REVISION SUMMARY
It is a bad idea to depend on non-existent versions: we should more clearly
mark our intended QQC dependency version (ie. Qt
running `which kcmshell5` style as
well as `kcmshell5 style`: the icon of the window matches that in system
settings (as expected).
Thanks,
Johan Ouwerkerk
>
> So the noto fonts are not to blame, just the noto package is.
> That does match with what i said and a couple of people said in here, i just
> didn't expect it to end up this way.
> - I've said: "just having the fonts installed cripples chrome"
> - Some in here: "The fonts are fine and the best
27;m working on a series of changes to make the panel and Task Manager
> finally pixel-perfect - fix the theme, fix the panel controller when
> resizing, fix the panel default size, and fix something in FrameSVG/the panel
> containment.
>
> Johan Ouwerkerk wrote:
> In an
:
> On Fri, Dec 18, 2015 at 7:12 PM, Johan Ouwerkerk
> wrote:
>> Does anybody know where I can find the sources (Debian control files
>> etc.) for the packaging of the reference image for Plasma Mobile?
>
> http://anonscm.debian.org/cgit/?q=pkg-kde
>
> partially ov
> On Dec. 20, 2015, 8:45 p.m., Eike Hein wrote:
> > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo
> > that cleans up all the random margins and inconsistent corner styles in it
> > that currently mess up alignments inside and outside of task buttons as
> > well as
Does anybody know where I can find the sources (Debian control files
etc.) for the packaging of the reference image for Plasma Mobile?
My goal is to put together a bootable image of Plasma Mobile for
aarch64, based on a plain Debian aarch64 base + added Plasma Mobile
packages on top.
I am rather h
uld be...? `[m_thread,m_connection,&m_syncLoop] {...}`
- Johan Ouwerkerk
On Dec. 17, 2015, 6:53 p.m., Sebastian Kügler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
> It is a very hard forced dependency on that font.
At build time, yes. At run time, you can simply reconfigure your
preferences in System Settings, uninstall both Oxygen and Noto
completely (with package manager) and still continue to use Plasma.
On Thu, Dec 17, 2015 at 11:09 PM, Mark Gaiser wr
to improve this in
> > Plasma 5.5 and scratch the code completely.
>
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them
>
> Johan Ouwerkerk wrote:
> > With KF 5.16 we will have all that's needed available. Let's try to
> improve
-desktop.git
Diffs
-
kcms/CMakeLists.txt 321fbebba49dad32d237f3941dea9fedaf1a8e5a
Diff: https://git.reviewboard.kde.org/r/126014/diff/
Testing
---
Built without XInput development files, using kdesrc-build.
Thanks,
Johan Ouwerkerk
___
Plasma
being present and
properly detected during the cmake configure stage.
Diffs
-
CMakeLists.txt 193238a8dcbb2c6e2bda01c390c57ff2ecfebeb0
Diff: https://git.reviewboard.kde.org/r/126013/diff/
Testing
---
Built without xkb header, using kdesrc-build
Thanks,
Johan Ouwerkerk
> On Nov. 10, 2015, 1:26 a.m., David Edmundson wrote:
> > Ship It!
>
> Johan Ouwerkerk wrote:
> Forgot to mention that the patch can be pulled from the fix-cmake-xkb-dep
> branch at: g...@github.com:cmacq2/plasma-desktop.git
>
> Johan Ouwerkerk wrote:
>
to improve this in
> > Plasma 5.5 and scratch the code completely.
>
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them
>
> Johan Ouwerkerk wrote:
> > With KF 5.16 we will have all that's needed available. Let's try to
> improve
matically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126014/#review88217
---
On Nov. 10, 2015, 2:22 p.m., Johan Ouwerkerk wrote:
>
> ---
> This i
> On Nov. 10, 2015, 1:26 a.m., David Edmundson wrote:
> > Ship It!
>
> Johan Ouwerkerk wrote:
> Forgot to mention that the patch can be pulled from the fix-cmake-xkb-dep
> branch at: g...@github.com:cmacq2/plasma-desktop.git
Please note: I do not have commit access
-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
-------
On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
>
> ---
> This is an autom
://git.reviewboard.kde.org/r/126016/#review88236
-------
On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
>
> ---
> This is an automatically generated e-mail. To
well as `kcmshell5 style`: the icon of the window matches that in system
settings (as expected).
Thanks,
Johan Ouwerkerk
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
window matches that in system
settings (as expected).
Thanks,
Johan Ouwerkerk
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
kcms/CMakeLists.txt 321fbebba49dad32d237f3941dea9fedaf1a8e5a
Diff: https://git.reviewboard.kde.org/r/126014/diff/
Testing
---
Built without XInput development files, using kdesrc-build.
Thanks,
Johan Ouwerkerk
___
Plasma-devel mailing list
Plasma-
.
Thanks,
Johan Ouwerkerk
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
matically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126013/#review88208
---
On Nov. 10, 2015, 12:52 a.m., Johan Ouwerkerk wrote:
>
> ---
> This i
without xkb header, using kdesrc-build
Thanks,
Johan Ouwerkerk
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
55 matches
Mail list logo
