D20035: Set autofocus to child KPluginSelector on UI load

2019-03-26 Thread Jayesh Bhoot
jayeshbhoot added a comment. This is my first patch. So I will need someone to land it. INLINE COMMENTS > ngraham wrote in kcm.cpp:41 > Don't need to include `QTimer` anymore. Fixed > ngraham wrote in kcm.cpp:89 > I'm not thrilled about this workaround. Any chance you can figure out why >

D20035: Set autofocus to child KPluginSelector on UI load

2019-03-26 Thread Jayesh Bhoot
jayeshbhoot updated this revision to Diff 54855. jayeshbhoot added a comment. - Remove unused dependency REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20035?vs=54853&id=54855 BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched from master)

D20035: Set autofocus to child KPluginSelector on UI load

2019-03-26 Thread Jayesh Bhoot
jayeshbhoot updated this revision to Diff 54853. jayeshbhoot added a comment. - Fix autofocus on searchbar on UI load REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20035?vs=54744&id=54853 BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched f

D20035: Set autofocus to child KPluginSelector on UI load

2019-03-24 Thread Jayesh Bhoot
jayeshbhoot added a comment. True. The description isn't quite clear. The 'sibling commit' is this: https://phabricator.kde.org/D20034. But at the time of `arc diff`, I didn't know how to link to it. So I just linked them both via the BUG tag. Let me know what to correct here. REPOSITORY

D20035: Set autofocus to child KPluginSelector on UI load

2019-03-24 Thread Jayesh Bhoot
jayeshbhoot created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jayeshbhoot requested review of this revision. REVISION SUMMARY A sibling commit to this commit in frameworks/kcmutils passes down the focus to the searchbar in KPluginSelector. CCB