.
If you want to commit as-is to get it in before the freeze, I don't
have issue though. That'd at least get any necessary strings in.
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/264/
---
(Updated 2008-11-08 19:40:24.687531)
Review request for Plasma.
Summary
-
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/264/
---
(Updated 2008-11-08 19:40:17.960183)
Review request for Plasma.
Summary
-
called 10 times.
Nope, only once. A guard was already in place so I didn't need to add one.
- Jason
-------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/264/#review255
-
Jason Stubbs wrote:
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/264/
> ---
>
> (Updated 2008-11-08 04:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/264/
---
Review request for Plasma.
Summary
---
There are some situations - suc
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/264/
---
(Updated 2008-11-08 04:00:45.525789)
Review request for Plasma.
Summary
-
Rob Scheepmaker wrote:
> On Wednesday 05 November 2008 15:18:02 Jason Stubbs wrote:
>> Rob Scheepmaker wrote:
>>> * The icon us quite large and takes up a lot of space.
>>> Solution: remove the icon from the notification itself and use it as the
>>> icon of th
close a detached
notification.
You might want to check the behaviour of for each of the various
combinations of with/without buttons, with/without a timeout and
with/without being detached.
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/247/#review239
---
Ship it!
Looks fine to me.
- Jason
On 2008-10-31 06:42:16, Mar
e of https://bugs.kde.org/show_bug.cgi?id=170283.
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
in this thread. note what
> the component is in your message, and you can include more than one component
> in your message =)
I'm happy for the systray to move.
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
I missed this mail. Mixed feelings about gmail's interface.
2008/10/10 Aaron J. Seigo <[EMAIL PROTECTED]>:
> On Saturday 04 October 2008, Jason Stubbs wrote:
>> Aaron J. Seigo wrote:
>> > On Friday 03 October 2008, Rob Scheepmaker wrote:
>> >> On Thursda
(Let's try to the mailing list this time)
On Thu, Oct 9, 2008 at 10:01 PM, Rob Scheepmaker
<[EMAIL PROTECTED]> wrote:
> On Sunday 05 October 2008 04:40:47 Jason Stubbs wrote:
>> This is definitely a possibility, but I'm not sure it's really possible
>> to accom
2008/10/6 Aaron J. Seigo <[EMAIL PROTECTED]>:
> On Sunday 05 October 2008, Jason Stubbs wrote:
>> SVN commit 868140 by jstubbs:
>>
>> Overriding the default hoverEnterEvent and hoverLeaveEvent handlers as they
>> call update(), which is not required.
>>
&g
SVN commit 868140 by jstubbs:
Overriding the default hoverEnterEvent and hoverLeaveEvent handlers as they
call update(), which is not required.
There is still a pointless update when the mouse cursor enters the panel,
though. It appears to be coming from Plasma::Containment and is causing
everyth
en that the systray is a fairly core piece of the workspace, I'd
really prefer to spend the alpha/beta stage ironing out any regressions
from 4.1 rather than forcing in changes that weren't designed for...
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
(), the documentation says it "returns true if
the thread has not been started yet". ie, it doesn't wait at all.
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
mething that the widget should be doing that it isn't? The widget
hasn't really changed from extendified_notify...
Also, I'd like to add:
* Sizing is wrong (again) when in the panel.
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
2008/10/1 Aaron J. Seigo <[EMAIL PROTECTED]>
> On Tuesday 30 September 2008, Jason Stubbs wrote:
> > * The correct icon isn't being set on notifications (internal API issue)
>
> internal to the systray-refactor widget .. or?
Yep. It's a TODO.
> > * Detached n
ight forward to
simply tack it on to the systray applet without any big changes in
either code base. Yay/nay?
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
ications disappear (possible
fix locally)
* Detached notifications don't close. (What to do about this?)
* Notifications aren't grouped by application. (Not critical but
preferred)
* Misbehavior of certain applets within the plasmoid protocol or
vic
Aaron J. Seigo wrote:
> On Monday 22 September 2008, Jason Stubbs wrote:
>> Hmm.. Actually, asking the Task object for a widget of a certain
>> orientation should be enough. eg. task->widget(Qt::Horizontal)
>
> or Plasma::Horizontal =)
I took a look at doing this, bu
e should be no more than one widget per task. Should the plasmoids
applet be able to display a task in separate areas of the screen, it
would need to be different applets or some fancy
QGraphicsProxyGraphicsWidget. ;)
Also, what is the orientation when on the desktop? If horizontal, should
it sti
Petri Damstén wrote:
> If we are looking root of that package (It's equal to path() but needed in
> dashboard to set "root" to this) then basepath is /some/path/ and canonical
> is
> /some/path and startsWith does not match. Is it ok to add '/' to
> canonicalPath?
What you probably want is QDi
Jason Stubbs wrote:
> The kdelibs coding style on techbase[1] only says "For pointers or
> references, use a single space before '*' or '&', but not after". When
> looking through applet.h and applet.cpp, I see this rule being broken in
> some circu
>
> and it's the way the compiler interprets it
>
With the rule of having only one definition per line, this reasoning is
mostly irrelevant. But I'm not really interested in arguing the merits of X
or Y. I'd just like to confirm that I'm correctly understanding where
g * Blah::foo();
Assuming the above are all correct, is it "correct" to put the asterisk
next to the variable (but not function) name when one is present and
next to the class/struct name otherwise?
[1] http://techbase.kde.org/Policies/Kdelibs_Coding_Style
--
Jason Stubbs
__
Aaron J. Seigo wrote:
> On Sunday 17 August 2008, Jason Stubbs wrote:
>> I'm fairly happy with the state of the rewrite and so am requesting that
>> it be reviewed for moving into trunk/kdebase. There's not much that it
>> doesn't fix and not much work left t
ay them. It seems that the
notifications display code could be reused for this? It also seems like
a good idea to separate the notion of a tray icon and an application
message as far as the systray/core stuff goes...
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
nd (commented out in
subversion) but it is breaking when exiting the dashboard. More strange
behaviour that I can't explain. :(
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
, what should be done will probably be more a bit more obvious. :)
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Replying to myself...
Jason Stubbs wrote:
> Sebastian Kügler wrote:
>> Positioning and background seem to be messed up here. See the screenshot.
>
> I've reproduced the positioning issue (it depends on the theme) so will
> work on a fix for that,
There's actually tw
et will work just
fine.
[1]
http://standards.freedesktop.org/systemtray-spec/systemtray-spec-latest.html
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Sebastian Kügler wrote:
> On Sunday 17 August 2008 19:53:33 Jason Stubbs wrote:
>> I won't be around much over the next week as I'm moving, but I should be
>> back to my regular "squeeze in an hour or two each day" by next weekend.
It seems I'll con
r or two each day" by next weekend.
Ok, I'll keep it short and sweet.
--
Jason Stubbs
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Jason Stubbs wrote:
> Diff: http://reviewboard.vidsolbach.de/r/137/diff
It seems I screwed up the base diff path so, for those that tried to
access it earlier and only got a python traceback, the above URL now
works correctly.
--
Jason Stu
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/137/
---
(Updated 2008-08-17 08:43:00.845896)
Review request for Plasma.
Summary
-
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/137/
---
Review request for Plasma.
Summary
---
Adds transparency to system tra
SVN commit 848034 by jstubbs:
This code doesn't serve it's purpose, but I'd like others to have a look at it
so I'm throwing it into subversion for the time being.
The purpose is to do ParentRelative background-pixmap manually. No X errors
are mentioned on the console and there's no crashes but n
40 matches
Mail list logo
