D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#534169 <https://phabricator.kde.org/D23849#534169>, @ngraham wrote: > +1. Do you wanna commit this, or should I? Are you referring to me? I assume not, just making sure... > @jfranklin can we use `Jason Franklin ` as your e

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#534154 , @romangg wrote: > Or let's just get it in. It's a small change and we still have the beta phase to test it. Fantastic. Yep, sooner is better in our case. REPOSITORY R133 KScreenLocker REV

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#534126 , @romangg wrote: > Thanks for the patch Jason. So the `GSendStr(nullptr)` is called on `m_password.isNull()` because this aborts the current PAM session? If this is correct, patch looks good to me.

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. In D23849#532568 , @zzag wrote: > @jfranklin Ping me if you don't get any feedback in a day or two. Hey there @zzag, haven't seen any activity here. Just pinging you per your request. Thanks! REPOSITORY R13

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. Friendly ping concerning this issue. Has anyone related to the screen locker project had some time to take a quick look at this? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag Cc: plasma-de

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. I also didn't point this out in my original post, but I fixed a misuse of `pam_end()`. The status passed to `pam_end()` should be the returned status of the last PAM library call. This is noted in the documentation for Linux-PAM. REPOSITORY R133 KScreenLocker

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

minimal impact on the code. I think this patch accomplishes this, and it certainly fixes my immediate problem. It also does not seem to introduce any regressions. I hope testing will reveal these if they are there. Thanks, Jason Franklin TEST PLAN I need all the help testing/reviewin

D23734: Remove the "fail_delay()" function

jfranklin abandoned this revision. jfranklin added a comment. Problem exists in linux-pam. I will fix the issue there. Abandoning revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23734 To: jfranklin, #plasma, #kwin, zzag Cc: zzag, plasma-devel, LeGa

D23734: Remove the "fail_delay()" function

jfranklin added a comment. I investigated this further in the linux-pam repository, and I ended up creating this issue . The developers there acknowledged that the documentation was not correct and have asked for a PR to fix it. Thus,

D23734: Remove the "fail_delay()" function

jfranklin added a comment. In D23734#526285 , @zzag wrote: > Hmm, "Unlocking failed" doesn't show up immediately if I type wrong password. "Unlocking failed" shows up immediately when I type in the wrong password with the change in place

D23734: Remove the "fail_delay()" function

jfranklin added a comment. In D23734#526274 , @zzag wrote: > We want to notify the user as soon as possible about authentication failure. This makes complete sense! You definitely want the user to be notified immediately. However, the s

D23734: Remove the "fail_delay()" function

jfranklin created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jfranklin requested review of this revision. REVISION SUMMARY I'm a new contributor to kscreenlocker, so I thought I'd start with something very simple to see how the process goes. I hope

D4785: Add a small test application for kcheckpass

ass effectively? Would you point me in the right direction? I'm having great difficulty finding any discussion of how to proceed here. Thanks, Jason Franklin REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4785 To: graesslin, #plasma, sebas Cc: jfr