janmulder added a comment.
Ah stupid. It appears that @mart pushed the same fix as part of commit
https://phabricator.kde.org/R169:63a7f75a79c16852683f3edaf89229e174aacca0. So
this one can be reverted. Sorry. Well, that happens when stuff is sitting
around for 6 weeks.
REPOSITORY
R169 Kir
janmulder added a comment.
Ok, accepted within 7 minutes after creation, but not merged since then (19
november). Do I need to do something? Maybe I just do not understand the
development model, merge rights etc?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8896
adding it to the .qrc file was forgotten. Breaking Subsurface mobile.
Signed-off-by: Jan Mulder
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8896
AFFECTED FILES
kirigami.qrc
To: janmulder, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein
janmulder added a comment.
No commit access for me. Not needed, as I do not expect a huge amount of work
on the repo. It is perfectly fine when mart commits it.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8291
To: janmulder, mart
Cc: davidedmundson, plasma-deve
janmulder created this revision.
janmulder added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Settings.isMobile is in the Kirigami import.
Signed-off-by: Jan Mulder
TEST PLAN
Check that the
