jamesl updated this revision to Diff 13213.
jamesl added a comment.
build.sh: Use C locale when rounding new cursor size xhot and yhot
values with printf.
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5250?vs=12997&id=13213
BRANCH
master
REVISION DETAI
jamesl marked 2 inline comments as done.
jamesl added a comment.
@subdiff, can you try running:
LC_ALL=C ./build.sh
If that works I'll update the script. Otherwise, do you have a better
suggestion on how to perform the calculations around line 44:
newxhot=$(printf '%.0f' $(
jamesl updated this revision to Diff 12997.
jamesl added a comment.
cursor build.sh: Remove execute bit; add 36 px size
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5250?vs=12994&id=12997
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5250
jamesl added a comment.
This is what you should see when you run the build script:
> ./build.sh
Checking requirements... DONE
Preprocessing cursor configs... DONE
Generating Breeze...
Making folders... DONE
Generating simple cursor pixmaps... DONE
Generating
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #14 from James Lee ---
For what it's worth, this page
https://community.kde.org/Infrastructure/Github_Mirror, and probably
Phabricator, didn't exist when I submitted this bug report and patch.
I tried uploading the patch with Ar
jamesl created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Breeze ships with 24 and 48 px cursors, and recently added 36 px in
https://phabricator.kde.org/D4358. However, with modern screen resolution
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #12 from James Lee ---
Created attachment 104804
--> https://bugs.kde.org/attachment.cgi?id=104804&action=edit
Phabricator Error on Patch Upload
I literally can't upload this patch to Phabricator. Because it contains new
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #10 from James Lee ---
So that's how it's going to be. Guess I won't be contributing to KDE anymore.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #8 from James Lee ---
Dominik, I tried, but due to the binary data in this patch, it was too large
for Phabricator, by an order of magnitude.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #6 from James Lee ---
I have rebased the patch on the current master HEAD and added your 36 px size.
Again, it's at:
https://github.com/iamjamestl/breeze/compare/master...iamjamestl:cursor-build-multiple-sizes.patch
You have no e
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #5 from James Lee ---
Created attachment 103739
--> https://bugs.kde.org/attachment.cgi?id=103739&action=edit
Breeze @ 40 px on properly-scaled WQHD display
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #4 from James Lee ---
Created attachment 103738
--> https://bugs.kde.org/attachment.cgi?id=103738&action=edit
Breeze @ 36 px on properly-scaled WQHD display
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=363147
--- Comment #3 from James Lee ---
36 px isn't good enough and here's why:
You have a whole class of laptops with 14" 2560x1440 (WQHD) displays, such as
the Lenovo ThinkPad T4*0/X* line of laptops that are very popular in the Linux
co
https://bugs.kde.org/show_bug.cgi?id=363147
James Lee changed:
What|Removed |Added
Version|5.6.4 |5.8.4
--- Comment #1 from James Lee ---
I&#x
https://bugs.kde.org/show_bug.cgi?id=363147
Bug ID: 363147
Summary: Breeze cursors should have more sizes (patch included)
Product: Breeze
Version: 5.6.4
Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
15 matches
Mail list logo
