Re: Quicklaunch QML porting questions

Hi! On 01/19/2012 12:35 PM, Sebastian Kügler wrote: > You can create a dynamically loaded import in C++ as well, and this might > even be the cleanest solution […] I've had a glance at the work Martin did for porting kickoff to QML and it seems like this is a good template for how to register you

Quicklaunch QML porting questions

Hi! I'm about to start porting the quicklaunch applet to QML. Since I'm just getting started with QML and the JavaScript API, I'm still unsure as to what's possible, so please bear with me if I'm missing something that's completely obvious. Judging from what I've read and tried so far, there seem

Re: Review Request: Tasks applet: Make order independent of whether the row count is forced.

p://svn.reviewboard.kde.org/r/5776/#review8528 ------- On 2010-11-06 20:58:47, Ingomar Wesp wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request: Tasks applet: Make order independent of whether the row count is forced.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5776/ --- (Updated 2010-11-06 20:58:47.857921) Review request for Plasma. Changes --

Re: Review Request: Tasks applet: Make order independent of whether the row count is forced.

enerated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5776/#review8522 --- On 2010-11-06 13:09:53, Ingomar Wesp wrote: > > --- > This is an automatically generated

Re: Review Request: Tasks applet: Make order independent of whether the row count is forced.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5776/ --- (Updated 2010-11-06 13:09:53.119264) Review request for Plasma. Changes --

Review Request: Tasks applet: Make order independent of whether the row count is forced.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5776/ --- Review request for Plasma. Summary --- This should fix

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

cks whether the passed element is non-empty anyways. - Ingomar --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8437 -------

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-28 23:30:24.052034) Review request for Plasma. Changes --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

viewboard.kde.org/r/5689/#review8411 --- On 2010-10-27 22:05:50, Ingomar Wesp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://svn.review

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-27 22:05:50.543676) Review request for Plasma. Changes --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-27 13:23:04.568859) Review request for Plasma. Changes --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

he is avoid to create renderers this is not > > good > > Manuel Mommertz wrote: > Right, but this is solvable by inserting the size hints in > SvgPrivate::localRectCache. > > Ingomar Wesp wrote: > > Right, but this is solvable by inserting the size hints

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

he is avoid to create renderers this is not > > good > > Manuel Mommertz wrote: > Right, but this is solvable by inserting the size hints in > SvgPrivate::localRectCache. > > Ingomar Wesp wrote: > > Right, but this is solvable by inserting the size hints

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-25 23:54:14.696262) Review request for Plasma. Changes --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

atically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8349 --- On 2010-10-25 15:29:32, Ingomar Wesp wrote: > > --- &g

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-25 15:29:32.167235) Review request for Plasma. Summary --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

w8338 ------- On 2010-10-25 00:17:45, Ingomar Wesp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5689/ > -

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-25 00:17:45.081898) Review request for Plasma. Summary --

Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- Review request for Plasma. Summary --- Previously, if an SVG contained

Re: Review Request: Adding filename as tooltip for frame applet

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/#review8275 --- I'm not the maintainer of the applet, so I'm sorry that I can only

Re: Review Request: Adding filename as tooltip for frame applet

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/#review8253 --- Since the ToolTipContent is copied in ToolTipManager::setContent a

Re: Review Request: Plasma::IconWidget: Add support for constrained size hints

> On 2010-10-12 20:19:23, Marco Martin wrote: > > just looking at the code seems sensible so far, did you tested it > > extensively? did you find any misbehaviour? > > (will do it tomorrow anyways) > > if it appear to behave well i think it could be tried to make

Review Request: System Tray: Use unhider arrows from arrows.svg

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5618/ --- Review request for Plasma. Summary --- As discussed on plasma-devel (h

Re: Review Request: Plasma::IconWidget: Add support for constrained size hints

/svn.reviewboard.kde.org/r/5580/#review8102 ------- On 2010-10-11 13:06:24, Ingomar Wesp wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request: Plasma::IconWidget: Add support for constrained size hints

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5580/ --- (Updated 2010-10-11 13:06:24.092922) Review request for Plasma. Changes --

Re: Review Request: Plasma::IconWidget: Add support for constrained size hints

s and that it apparently even uses the previously given constraint for that... - Ingomar --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5580/#review8073 -

Review Request: Plasma::IconWidget: Add support for constrained size hints

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5580/ --- Review request for Plasma. Summary --- I poked around the IconWidget cl

Re: Plasma theming: Re-using existing widget SVGs

Marco Martin wrote: > the theme itself will be able to pick the proper ones optimized for a > certain resolution if present, not something one has to worry about :) Nifty. I knew something like this worked for KIcon, but it never occurred to me that Plasma::Theme / Plasma::SVG could do that as we

Re: Plasma theming: Re-using existing widget SVGs

Marco Martin wrote: > [...] we could do the following: > > use arrows.svg for the systray (so old themes wouldn't be completely > broken, they would have the arrows) > then provide smaller versions with like a 16-16-left element and so forth, > so the arrows would look nice also with sizes as lit

Re: Scrollbars in add widget ui

> I have been playing a bit with the Add Widget UI on the plane back from > Akademy and replaced the scroll buttons with a scrollbar. Attached patch > is a first step at it, largely unfinished as I would like to know if you > are interested in getting this integrated before I finish it. > > [...] >

Re: Plasma theming: Re-using existing widget SVGs

Marco Martin wrote: > i'm not sure the systray one would be the best choice as opposed to > the arrows svg [...] Ah, completely overlooked that one. I guess going for the more generic arrows is the better choice then. Unfortunately, this also adds a bit of visual inconsistency for users that h

Plasma theming: Re-using existing widget SVGs

Hi, just a quick question regarding theming: The quicklaunch applet currently uses a KIcon for displaying the arrow that triggers/hides its popup, which obviously isn't theme aware and might look bad in some themes due to contrast issues. Since the graphics for a nice extender arrow are alread

Review Request: [Lock/Logout] Add "switch user" button

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4618/ --- Review request for Plasma, Frederik Gladhorn and Alexis Menard. Summary ---

Re: Quicklaunch: Migrating storage to kio bookmarks

Ingomar Wesp wrote: > Aaron J. Seigo wrote: >> my first reaction is to be concerned that this will decrease the general >> simplicity and elegance of this widget in terms of usage. but i'm >> prepared to be stunned and converted to the new idea :) > > Alright,

Re: Quicklaunch: Migrating storage to kio bookmarks

Aaron J. Seigo wrote: > my first reaction is to be concerned that this will decrease the general > simplicity and elegance of this widget in terms of usage. but i'm prepared > to be stunned and converted to the new idea :) Alright, I'll give my best ;) No, seriously: I understand and share your c

Quicklaunch: Migrating storage to kio bookmarks

Hi there, since you are probably all rather busy with fixing RC bugs, I'll make it short ;) One of the things I'd like to work on for the 4.6 version of the quicklaunch applet is getting rid of the "more icons" popup in favor a more modular concept like folders. Since I need some way to stor

Re: Review Request: [Quicklaunch] Fix handling of plain paths and auto-hide popup

t; > Lukas Thanks! Committing now. - Ingomar --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4271/#review6064 ------- On 2010-06-09 19:06:31, Ingomar Wesp wrote: > > -

Review Request: [Quicklaunch] Fix handling of plain paths and auto-hide popup

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4271/ --- Review request for Plasma. Summary --- Not sure if it's already too late fo

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

Lukas Appelhans wrote: > It's just as easy as changing the .desktop file and putting your name into > it instead of mine :) Oh, well, I should manage to do that ;) > And of course taking care of it... :) I'll treat it gently ;) > (You'll also need an SVN-Account) I've already got one, so that

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

Lukas Appelhans wrote: > Can you make the configuration of the rows first and then have the force > setting (aka swap the place of them), that'd make more sense to me as the > user reads the options from top to bottom, not knowing that there are any > row/column settings... :) That's a good idea,

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3786/ --- (Updated 2010-04-27 09:56:42.272687) Review request for Plasma. Changes --

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

>>> And I think the column setting is unnecessary... no? :) >> >> I'm afraid I'm not sure what you are referring to. >> Do you mean the ability to set the maximum number of columns in vertical >> formfactors? > > No, in horizontal formfactors there's an option to force the number of > columns, it

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

Thanks a lot! Best regards, Ingo - Ingomar --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3786/#review5224 --- On 2010-04-23 19:08:34, Ingoma

Re: Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

Lukas Appelhans wrote: > For keeping the history we usually use svn copy and then change the files > :) svn move only works with svn paths, not with local paths... Please correct me if I'm wrong, but as far as I know "svn move" *does* work for working copy paths and yields the same result as "svn

Review Request: [Quicklaunch] Refactoring of the Quicklaunch applet

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3786/ --- Review request for Plasma. Summary --- This is my proposed patch for the re

Re: Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

Lukas Appelhans wrote: > Am Montag 05 April 2010 17:00:29 schrieb Ingomar Wesp: >> This suggestion would remove the need (and the ability) to set the icon >> size altogether. We would have to define some default row height at which >> wrapping takes place, but the user woul

Re: Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

You wrote: >>> ! And I noticed that multiple row support is gone at the moment it seems >>> :/ >> >> Multiple row support should work (unless you ran into a bug), but new >> rows are created only when there is enough space to fit the >> user-configurable icon size for each row. For an icon size of

RE: Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

Sorry for the form of this reply (I'm writing this from my phone)... ! And I noticed that multiple row support is gone at the moment it seems :/ Multiple row support should work (unless you ran into a bug), but new rows are created only when there is enough space to fit the user-configurable ico

Re: Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3358/ --- (Updated 2010-04-02 19:05:06.237279) Review request for Plasma. Changes --

Re: Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

... Well, actually we do have to care, as we need to check whether the current row/column wrapping is still valid after a resize, change of orientation or a change to the icon size hint. - Ingomar ------- This is a

Re: Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3358/ --- (Updated 2010-04-01 20:01:41.294461) Review request for Plasma. Changes --

Re: Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

Hi! Thanks for your ongoing support. I really appreciate it. Lukas Appelhans wrote: > First of all, I agree with pretty much all the points you noted! :) I also > have or better had some ideas about how to make the configuration of > icon-size/icon-rows cleaner and easier to use (the original ide

Review Request: [Quicklaunch] Refactoring, layout fixes and a drag & drop marker.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3358/ --- Review request for Plasma. Summary --- Ok, this is a biggie (and still a wo

Re: Review Request: Quicklaunch applet: Change icon order

ally generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3254/#review4461 ------- On 2010-03-10 22:32:10, Ingomar Wesp wrote: > > --- > This is an automatically generated e-mail.

Review Request: Quicklaunch applet: Change icon order

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3254/ --- Review request for Plasma. Summary --- Since there were no objections on pl

Quicklaunch applet: Proposed change to the ordering of icons

Hi, Before I submit a corresponding patch, I'd like to ask for feedback on the following proposal for the quicklaunch applet: Currently, icons are arranged in column major order. Thus, when 5 icons are displayed in two rows, the indices are distributed as follows: +---+---+---+ | 0 | 2 | 4 | +

Re: Quicklaunch: Getting started with contributing...

Marco Martin wrote: > > Hello, there. >> >> I'd like to get involved with plasma development, but I'm still a bit > > welcome aboard :) Thanks :) > depends from the sze of the patches and how much they're interconnected, > maybe post one for each issue... Ok, thanks. I'll try to separate them

Re: Quicklaunch: Getting started with contributing...

Lukas Appelhans wrote: > Great! You're very welcome to take over the Quicklaunch Applet as I have > not too much time recently... :/ Well, thanks. I look forward to working on the remaining issues as my spare time permits. > If you need any help just ask me :) Let's hope you won't regret that

Re: Review Request: Quicklaunch applet: Partial fix for drag&drop to main layout.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3214/ --- (Updated 2010-03-08 21:32:38.241293) Review request for Plasma. Summary --

Review Request: Quicklaunch applet: Partial fix for drag&drop to main layout.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3214/ --- Review request for Plasma. Summary --- This patch changes the computation o

Quicklaunch: Getting started with contributing...

Hello, there. I'd like to get involved with plasma development, but I'm still a bit unsure about a few details regarding the process of submitting patches. Since the quicklaunch applet still suffers from a number of issues and is pretty easy to understand, I thought it might be the right target