D17571: Fix pixmap scaling on HiDPI screens

2018-12-14 Thread Emirald Mateli
emateli added a comment. The only difference in the process list is that the plasmashell icon becomes smaller. Aren't the charts and process list handled by libksysguard instead of this repository? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D17571 To: emateli

D17571: Fix pixmap scaling on HiDPI screens

2018-12-13 Thread Emirald Mateli
emateli added a comment. There are no side effects from what I can tell. REPOSITORY R106 KSysguard BRANCH hidpi REVISION DETAIL https://phabricator.kde.org/D17571 To: emateli, mlaurent, davidedmundson Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mo

D17571: Fix pixmap scaling on HiDPI screens

2018-12-13 Thread Emirald Mateli
emateli created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. emateli requested review of this revision. REVISION SUMMARY Adds the usual flag needed for HiDPI screens. REPOSITORY R106 KSysguard BRANCH hidpi REVISION DETAIL https://phabricator.kd

D15862: option to specify icons spacing for systray

2018-11-23 Thread Emirald Mateli
emateli added a comment. FWIW I agree with @mart. Just give it a default value and leave it at that. More configuration doesn't necessarily mean better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15862 To: mvourlakos, #plasma, davidedmundson, #vdg Cc:

D16968: [Folder View] improve label contrast against challenging backgrounds

2018-11-23 Thread Emirald Mateli
emateli added a comment. The classical solution to these problems is always a white text with black outline. Works well for both light and dark backgrounds. Some image from the internet: https://i.imgur.com/pQjoQ.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator

D13346: Use more contextual strings for some button labels

2018-06-05 Thread Emirald Mateli
emateli added a comment. > In D13346#274446 , @abetts wrote: > Could we have a button that enables/disables bluetooth instead? We can show the warning message only if it doesn't seem to be working? or for example, if it runs into an error when ena

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-12-18 Thread Emirald Mateli
emateli abandoned this revision. emateli added a comment. Closing this since we're unable to reach a consensus. None of the proposed changes are how I envision the patch to work. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel,

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-12-15 Thread Emirald Mateli
emateli added a comment. In https://phabricator.kde.org/D8564#179707, @ngraham wrote: > I found at least one user during my triaging of Task Manager bug who was sufficiently motivated to file a bug that this would resolve: https://bugs.kde.org/show_bug.cgi?id=361984 I don't think

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-11-02 Thread Emirald Mateli
emateli added a comment. > To be honest - dropping the patch. I feel as that's the easy part. > Sure. The URL to the .desktop file is the exchange-ready representation for an app, which the task item is a delegate for. I don't see a good reason not to be able to drag one, considerin

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-11-01 Thread Emirald Mateli
emateli added a comment. > Task Manager items are not widgets, it's content, and the widget mutability state should not affect content drags. I don't see why it can't. Task manager items can be aware of the panel state if that's needed. > "If widgets are locked, stop adding a certai

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-11-01 Thread Emirald Mateli
emateli added a comment. I feel like the long press can mess with the manual ordering of task manager icons. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: subdiff, hein, plasma-devel, ZrenBot, progwolff, lesliezha

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-11-01 Thread Emirald Mateli
emateli added a comment. Hi @hein, thanks for your input and I understand that this might break some functionality that I'm unaware of (such as the drop of task manager icons into the pager widget). The current revision allows drop into the pager widget and other plasma widgets(needs mo

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-11-01 Thread Emirald Mateli
emateli updated this revision to Diff 21689. emateli added a comment. Remove empty line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8564?vs=21688&id=21689 BRANCH disable-drop REVISION DETAIL https://phabricator.kde.org/D8564 AFFECTED FILES

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-11-01 Thread Emirald Mateli
emateli updated this revision to Diff 21688. emateli added a comment. Allow task items to be dropped onto other widgets REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8564?vs=21606&id=21688 BRANCH disable-drop REVISION DETAIL https://phabricato

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-11-01 Thread Emirald Mateli
emateli added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-10-31 Thread Emirald Mateli
emateli added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

2017-10-31 Thread Emirald Mateli
emateli retitled this revision from "Disallow drop of task manager widgets outside of plasmoid when locked" to "Disallow drop of task manager icons outside of plasmoid when widgets are locked". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, pl

D8564: Disallow drop of task manager widgets outside of plasmoid when locked

2017-10-31 Thread Emirald Mateli
emateli created this revision. emateli added a reviewer: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY This patch disallows dropping task manager items outside of the plasmoid when widgets are locked. As a user whose primary device is a laptop (with a touch sc

D8362: Added setting to toggle drawing of title bar separator

2017-10-18 Thread Emirald Mateli
emateli retitled this revision from "added setting to toggle drawing of title bar separator" to "Added setting to toggle drawing of title bar separator". emateli edited the summary of this revision. emateli added a subscriber: Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator

D8362: added setting to toggle drawing of title bar separator

2017-10-18 Thread Emirald Mateli
emateli edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8362 To: emateli, #breeze, #vdg Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8362: added setting to toggle drawing of title bar separator

2017-10-18 Thread Emirald Mateli
emateli added a reviewer: VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8362 To: emateli, #breeze, #vdg Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8362: added setting to toggle drawing of title bar separator

2017-10-18 Thread Emirald Mateli
emateli added a reviewer: Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8362 To: emateli, #breeze Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8362: added setting to toggle drawing of title bar separator

2017-10-18 Thread Emirald Mateli
emateli created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Adds a new settings on Breeze theme which allows the user to turn off the title bar separator drawn TEST PLAN 1. Use default breeze theme