D4939: Get rid of KDELibs4Support

denisshienkov added a comment. Thanks REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas, broulik, graesslin, davidedmundson, #plasma Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, j

D4939: Get rid of KDELibs4Support

denisshienkov added a comment. ping REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas, broulik, graesslin, davidedmundson, #plasma Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jen

D4939: Get rid of KDELibs4Support

denisshienkov added a comment. Who can do push this patch? As I have not rigths and have not a developer account. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas, broulik, graesslin, davidedmundson, #plasma Cc: graesslin,

D4939: Get rid of KDELibs4Support

denisshienkov added a reviewer: Plasma. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas, broulik, graesslin, davidedmundson, #plasma Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jen

D4939: Get rid of KDELibs4Support

denisshienkov added a comment. ping REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas, broulik, graesslin, davidedmundson Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterbe

D4939: Get rid of KDELibs4Support

denisshienkov added reviewers: graesslin, davidedmundson. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas, broulik, graesslin, davidedmundson Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-moh

D4939: Get rid of KDELibs4Support

denisshienkov added a reviewer: broulik. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas, broulik Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4939: Get rid of KDELibs4Support

denisshienkov updated this revision to Diff 12510. denisshienkov edited the summary of this revision. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4939?vs=12509&id=12510 REVISION DETAIL https://phabricator.kde.org/D4939 AFFECTED FILES CMakeLists.txt

D4939: Get rid of KDELibs4Support

denisshienkov added a comment. What to do with HybridSuspendState ? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D4939: Get rid of KDELibs4Support

denisshienkov marked an inline comment as done. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4939: Get rid of KDELibs4Support

denisshienkov updated this revision to Diff 12509. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4939?vs=12476&id=12509 REVISION DETAIL https://phabricator.kde.org/D4939 AFFECTED FILES CMakeLists.txt daemon/CMakeLists.txt daemon/actions/bundled/CM

D4939: Get rid of KDELibs4Support

denisshienkov added inline comments. INLINE COMMENTS > volkov wrote in CMakeLists.txt:111 > Where do they come from in /usr/share/dbus-1/interfaces/ ? Oops, from KDELibs4Support :). REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afi

D4939: Get rid of KDELibs4Support

denisshienkov marked an inline comment as done. denisshienkov added inline comments. INLINE COMMENTS > volkov wrote in CMakeLists.txt:111 > Copy them here. Are you sure that I need to copy a files as kf5_org.freedesktop.PowerManagement.xml and kf5_org.freedesktop.PowerManagement.Inhibit.xml f

D4939: Get rid of KDELibs4Support

denisshienkov updated this revision to Diff 12476. denisshienkov edited the summary of this revision. denisshienkov set the repository for this revision to R122 Powerdevil. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4939?vs=12475&id=12476 REVISION DETAI

D4939: Get rid of KDELibs4Support

denisshienkov updated this revision to Diff 12475. denisshienkov edited the summary of this revision. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4939?vs=12250&id=12475 REVISION DETAIL https://phabricator.kde.org/D4939 AFFECTED FILES CMakeLists.txt daemon/CMakeLists.txt daem

D4970: Get rid of QWeakPointer

denisshienkov added a comment. Can I get a "commit access"? If yes, then how? I have read many WiKi's pages about KDE commit policy and so on.. But I did not understand how it works with KDE? Could you please recommend for me some appropriate wiki? PS: I know how to work with Qt's JIRA,

D4970: Get rid of QWeakPointer

denisshienkov added a comment. What is next steps from my side? REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson Cc: davidedmundson, plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4970: Get rid of QWeakPointer

denisshienkov updated this revision to Diff 12331. denisshienkov edited the summary of this revision. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4970?vs=12270&id=12331 REVISION DETAIL https://phabricator.kde.org/D4970 AFFECTED FILES kcmodule/activities/activitypage.cpp kcmodu

D4970: Get rid of QWeakPointer

denisshienkov added a comment. It can happens only if an object lives in a different thread. But the ErrorOverlay - is a widget, which should live in a main thread. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, afiestas, ltoscano, volkov

D4939: Get rid of KDELibs4Support

denisshienkov added inline comments. INLINE COMMENTS > denisshienkov wrote in activitypage.cpp:76 > > Why don't make QWeakPointer -> QPointer > > > > 1. Then, I suggest do not use QPointer at all, as it is overhead for this > case. I suggest to use the pointers directly.. > > > commit first

D4970: Get rid of QWeakPointer

denisshienkov added a reviewer: ltoscano. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, volkov, afiestas, ltoscano Cc: plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4970: Get rid of QWeakPointer

denisshienkov added a reviewer: afiestas. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, volkov, afiestas Cc: plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4970: Get rid of QWeakPointer

denisshienkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As it is overhead to use QWeakPointer and QPointer in this simple code. Also, now we delete the ErrorOverlay objects directly instead of

D4970: Get rid of QWeakPointer

denisshienkov added a reviewer: volkov. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, volkov Cc: plasma-devel, volkov, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4939: Get rid of KDELibs4Support

denisshienkov added inline comments. INLINE COMMENTS > volkov wrote in powerdevilcore.cpp:102 > Yes, powermanagement.{h, cpp} from kscreenlocker is what you need. > The question is whether to create a library from it? > The question is whether to create a library from it? I don't know. It is no

D4939: Get rid of KDELibs4Support

denisshienkov added inline comments. INLINE COMMENTS > volkov wrote in CMakeLists.txt:111 > I guess it can be just removed. These kf5_org.* files were dropped from solid > three years ago. Where I need to take an appropriate XML files then? > volkov wrote in CMakeLists.txt:22 > Is it necessary

D4939: Get rid of KDELibs4Support

denisshienkov edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4939: Get rid of KDELibs4Support

denisshienkov updated this revision to Diff 12250. denisshienkov added a comment. How about this? :) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4939?vs=12179&id=12250 REVISION DETAIL https://phabricator.kde.org/D4939 AFFECTED FILES CMakeLists.txt daemon/CMakeLists.txt d

D4939: Get rid of KDELibs4Support

denisshienkov added a comment. So, what is final decision? Should I "abandon" it? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas Cc: davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterber

D4939: Get rid of KDELibs4Support

denisshienkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - Replace QWeakPointer with QPointer. - Remove Solid::PowerManagement code, as it is not ported yet to Solid. REPOSITORY R122 Powerd