Re: Review Request 106978: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting

2014-07-29 Thread David Narváez
activities Before this patch, the activity bar in the panel with a task bar shrinks or enlarges with every activity change; while the size of the activity bar in the second panel remains constant. After this patch, the size of the activity bar in both panels remains constant. Thanks, David

Re: Review Request 118583: Fix Comic Strip Installation

2014-06-06 Thread David Narváez
/comic/comic.knsrc e7a78b9 Diff: https://git.reviewboard.kde.org/r/118583/diff/ Testing --- Repeated the steps in bug 325028 Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118583: Fix Comic Strip Installation

2014-06-05 Thread David Narváez
--- Repeated the steps in bug 325028 Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 108641: Refactor of the Signing Code in Microbloggin Plugin

2013-01-28 Thread David Narváez
equivalent to the previous code, but wanted to make sure this won't break anything. Diffs - dataengines/microblog/tweetjob.cpp ba8104a Diff: http://git.reviewboard.kde.org/r/108641/diff/ Testing --- Tested if I was still able to dent with the new code. Thanks, David Na

Review Request 108640: Check for Valid Wallet Pointer

2013-01-28 Thread David Narváez
desktop does not have "Allow Always" in your kwallet 2. Add a microblogging plasmoid 3. Configure your plasmoid with an identi.ca account 4. Deny any kwallet prompt Before this path it would crash trying to store the access tokens. Thanks, Dav

Re: Review Request: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting

2012-10-27 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106978/#review20847 --- On Oct. 22, 2012, 2:27 a.m., David Narváez wrote: > > -

Re: Review Request: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting

2012-10-21 Thread David Narváez
this patch, the activity bar in the panel with a task bar shrinks or enlarges with every activity change; while the size of the activity bar in the second panel remains constant. After this patch, the size of the activity bar in both panels remains constant. Thanks, David Narváez

Review Request: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting

2012-10-21 Thread David Narváez
the second panel remains constant. After this patch, the size of the activity bar in both panels remains constant. Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Avoid Calling setFailedToLaunch from Microblog Plasmoid

2012-10-10 Thread David Narváez
functionallity and with a label saying it failed to load the engine. Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Avoid Calling setFailedToLaunch from Microblog Plasmoid

2012-09-28 Thread David Narváez
, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Use Config to Provide Activity Icons

2012-05-24 Thread David Narváez
? - David Narváez On May 22, 2012, 3:12 a.m., David Narváez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Use Config to Provide Activity Icons

2012-05-22 Thread David Narváez
n the information stays with the activities. if they > > are stored outside of nepomuk, then when we want to do things like migrate > > activities it becomes messier and we lose visibility on the connection > > between the image and the activity. > > David Narváez wrote

Re: Review Request: Use Config to Provide Activity Icons

2012-05-22 Thread David Narváez
ync'ed later in the code once Nepomuk is available. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105008/#review14047 -------

Review Request: Use Config to Provide Activity Icons

2012-05-21 Thread David Narváez
a1d8a Diff: http://git.reviewboard.kde.org/r/105008/diff/ Testing --- Log out and back in. Before this patch, icons would probably load later, or not load at all. Now icons are displayed right away when desktop is loaded. Thanks, David Na

Re: Review Request: Wait for All Ignored Windows to Close in Controller

2012-02-08 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103858/#review10419 --- Ping - David Narváez On Feb. 3, 2012, 1 p.m., David Narváez

Review Request: Wait for All Ignored Windows to Close in Controller

2012-02-03 Thread David Narváez
e) and the icon wouldn't change. I think I remember being able to set a PNG file before, so please let me know if this is a problem caused by this patch. Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde

Re: Review Request: Drop InvisibleCollectionFetch Fetch Strategy in Favor of KDescendantsProxyModel

2011-11-19 Thread David Narváez
able to replicate bug 279322 without this patch and this patch should fix the situation described there. Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Drop InvisibleCollectionFetch Fetch Strategy in Favor of KDescendantsProxyModel

2011-11-19 Thread David Narváez
llectionsModel->addMimeTypeExclusionFilter( > > > Akonadi::Collection::mimeType() ); > > > > Otherwise you have the model flattened, with the collections still in. > > No idea if it is relevant for this case, but with the > > EntityMimeTypeFilterModel you would get exa

Re: Review Request: Drop InvisibleCollectionFetch Fetch Strategy in Favor of KDescendantsProxyModel

2011-11-19 Thread David Narváez
nerated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103088/#review8314 ----------- On Nov. 10, 2011, 6:12 a.m., David Narváez wrote: > > --- > This is

Review Request: Don't set Icon if iconName is Empty in ActivityBar

2011-11-15 Thread David Narváez
would look a bit flushed right. After this patch the names look centered properly. Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Adjust TimeSpecs in the Calendar Dataengine to Reflect Local Time

2011-11-10 Thread David Narváez
local time zone Without this patch, the Calendar plasmoid will show times in UTC. After this patch, both events (and the recurrences of the second test) should have correct local start and end times. Thanks, David Narváez ___ Plasma-devel mailing list

Review Request: Drop InvisibleCollectionFetch Fetch Strategy in Favor of KDescendantsProxyModel

2011-11-09 Thread David Narváez
hanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Adjust TimeSpecs in the Calendar Dataengine to Reflect Local Time

2011-11-09 Thread David Narváez
(and the recurrences of the second test) should have correct local start and end times. Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-09 Thread David Narváez
, I'm assuming everyone is OK with it so I'll commit this patch. - David Narváez On Nov. 8, 2011, 9:14 a.m., David Narváez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-08 Thread David Narváez
end times of the event in the calendar Not sure how to test changing timezones from Plasma, so proposed patch is based on what I think we should do in such a case. Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-06 Thread David Narváez
onverting to > > the local timezone there ( KSystemTimeZones::local() ) > > David Narváez wrote: > What would be the purpose of sending a TimeSpec to the CalendarModel then? To pick up on this review again, notice that moving the timezone logic to the Calendar Applet (the prese

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-01 Thread David Narváez
p://git.reviewboard.kde.org/r/102997/#review7834 ----------- On Oct. 31, 2011, 6:57 a.m., David Narváez wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-10-30 Thread David Narváez
in the calendar Not sure how to test changing timezones from Plasma, so proposed patch is based on what I think we should do in such a case. Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-10-29 Thread David Narváez
based on what I think we should do in such a case. Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Escape Text in Microblogging Post Widget

2011-10-26 Thread David Narváez
73/#review7661 --- On Oct. 26, 2011, 1:04 p.m., David Narváez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.re

Review Request: Escape Text in Microblogging Post Widget

2011-10-26 Thread David Narváez
h cleans "<" as "<" and you should see "I <3 KDE" in the widget. Thanks, David Narváez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel