Re: Review Request 127616: Digital clock applet re-write

2017-02-08 Thread Daniel Faust
dialog https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/8ca78bd7-f82d-4cfa-b919-60b713d5c557__clock-config-old.png New config dialog https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/a69b5256-9353-40c8-989b-05575f07c15b__clock-config-new.png Thanks, Daniel Faust

Re: Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
-re-write.patch Thanks, Daniel Faust ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
tps://git.reviewboard.kde.org/r/127616/diff/1/?file=455806#file455806line141> > > > > Don't use PlasmaComponents in widget-style dialogs I wanted to show a clear button, but I get your point. - Daniel --- This is an autom

Re: Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
d.kde.org/media/uploaded/files/2016/04/09/1623ed2a-a8c2-49f4-86d4-d404909dd426__0001-Digital-clock-applet-re-write.patch Thanks, Daniel Faust ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127616: Digital clock applet re-write

2016-04-09 Thread Daniel Faust
/media/uploaded/files/2016/04/09/8ca78bd7-f82d-4cfa-b919-60b713d5c557__clock-config-old.png New config dialog https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/a69b5256-9353-40c8-989b-05575f07c15b__clock-config-new.png Thanks, Daniel Faust ___

Re: Review Request 127102: Use fixed width for digital clock applet

2016-03-19 Thread Daniel Faust
marked as submitted. Review request for kde-workspace and Plasma. Changes --- Submitted with commit e7f09ba1eb976c4f282145016d34fe87de515a25 by Daniel Faust to branch master. Bugs: 347724 https://bugs.kde.org/show_bug.cgi?id=347724 Repository: plasma-workspace Description

Re: Review Request 127102: Use fixed width for digital clock applet

2016-03-19 Thread Daniel Faust
quot;A" and "P" width's and use that? Would spare > > creating two Date objects and two calls to Qt.formatTime > > Daniel Faust wrote: > No, because eg. in german the strings for am and pm are "vorm." and > "nachm.". > > Martin K

Re: Review Request 127102: Use fixed width for digital clock applet

2016-03-19 Thread Daniel Faust
0001-Use-fixed-width-for-digital-clock-applet.patch https://git.reviewboard.kde.org/media/uploaded/files/2016/03/16/81b4a902-1454-4155-9fda-552b8acba1a8__0001-Use-fixed-width-for-digital-clock-applet.patch Thanks, Daniel Faust ___ Plasma-d

Re: Review Request 127102: Use fixed width for digital clock applet

2016-03-15 Thread Daniel Faust
thing. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/#review93561 --- On März 8, 2016, 6:53 nachm., Daniel F

Re: Review Request 127102: Use fixed width for digital clock applet

2016-03-08 Thread Daniel Faust
) - applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 Diff: https://git.reviewboard.kde.org/r/127102/diff/ Testing --- Works with horizontal and vertical panel. Also displaying different combinations of "seconds", "date" and "timezone"

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-26 Thread Daniel Faust
ontMetric's maximumCharacterWidth > > > > * numChars. > > > > Then we could kill sizeHelper competely (FontMetric's didn't exist when > > this was written) > > Marco Martin wrote: > hoping maximumCharacterWidth is reliable fo

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-19 Thread Daniel Faust
: https://git.reviewboard.kde.org/r/127102/diff/ Testing --- Works with horizontal and vertical panel. Also displaying different combinations of "seconds", "date" and "timezone" works. Thanks, Daniel Faust ___ Pl

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-19 Thread Daniel Faust
ontMetric's maximumCharacterWidth > > > > * numChars. > > > > Then we could kill sizeHelper competely (FontMetric's didn't exist when > > this was written) > > Marco Martin wrote: > hoping maximumCharacterWidth is reliable fo

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-19 Thread Daniel Faust
ontMetric's maximumCharacterWidth > > > > * numChars. > > > > Then we could kill sizeHelper competely (FontMetric's didn't exist when > > this was written) > > Marco Martin wrote: > hoping maximumCharacterWidth is reliable fo

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-18 Thread Daniel Faust
ontMetric's maximumCharacterWidth > > > > * numChars. > > > > Then we could kill sizeHelper competely (FontMetric's didn't exist when > > this was written) > > Marco Martin wrote: > hoping maximumCharacterWidth is reliable fo

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-18 Thread Daniel Faust
ontMetric's maximumCharacterWidth > > > > * numChars. > > > > Then we could kill sizeHelper competely (FontMetric's didn't exist when > > this was written) > > Marco Martin wrote: > hoping maximumCharacterWidth is reliable fo

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-18 Thread Daniel Faust
test and maximumCharacterWidth returned about twice the width actually needed. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/#review92514 ---------

Review Request 127102: Use fixed width for digital clock applet

2016-02-17 Thread Daniel Faust
displaying different combinations of "seconds", "date" and "timezone" works. Thanks, Daniel Faust ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-27 Thread Daniel Faust
marked as submitted. Review request for kde-workspace and Plasma. Changes --- Submitted with commit 8bedfde2894a60dc72a0bd40589dfb900776dace by Daniel Faust to branch master. Repository: plasma-workspace Description --- I wrote a qml applet using the places data engine and noticed

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Daniel Faust
" and "Teardown Device" operations of the service. The operations "Show" and "Hide" don't seem to work anyway and the others were not tested. Thanks, Daniel Faust ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Daniel Faust
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126851/#review91476 ------- On Jan. 23, 2016, 2:14 p.m., Daniel Faust wrote: > > ---

Review Request 126851: Places data engine: Rename model role name "index" to "id"

2016-01-23 Thread Daniel Faust
t;Hide" don't seem to work anyway and the others were not tested. Thanks, Daniel Faust ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel