Change in plasma-framework[master]: Fix build on Qt 5.2

2015-06-10 Thread Code Review
Jan Kundrát has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/462 Change subject: Fix build on Qt 5.2 .. Fix build on Qt 5.2 The QJsonArray::operator<<(const QJsonValue &) is a 5.3 thing. Change-Id: I

Change in plasma-framework[master]: Consider visualParent rotation in popupPosition

2015-04-02 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/438 Change subject: Consider visualParent rotation in popupPosition .. Consider visualParent rotation in popupPosition if there are transf

Change in plasma-framework[master]: Simplify code flow

2015-03-13 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/419 Change subject: Simplify code flow .. Simplify code flow return immediately rather than wrapping an entire function inside an if C

Change in plasma-framework[master]: Disconnect connections to d->mainItem when it has changed

2015-03-13 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/418 Change subject: Disconnect connections to d->mainItem when it has changed .. Disconnect connections to d->mainItem when it has chang

Change in plasma-framework[master]: Fix segfault in KWin when all screens disappear

2015-03-11 Thread Code Review
Jan Kundrát has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/415 Change subject: Fix segfault in KWin when all screens disappear .. Fix segfault in KWin when all screens disappear This is due to chang

Change in plasma-framework[master]: support for C++ applets

2015-02-12 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/374 Change subject: support for C++ applets .. support for C++ applets make possible for an applet to be implemented in c++ but still have

Change in plasma-framework[master]: Put all non tiled frame textures in the atlas

2015-02-11 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/370 Change subject: Put all non tiled frame textures in the atlas .. Put all non tiled frame textures in the atlas Change-Id: I2525998a

Change in plasma-framework[master]: Port to kpackage::package

2015-02-11 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/367 Change subject: Port to kpackage::package .. Port to kpackage::package Change-Id: Id52b8d6bf76ab964c02cec9f0bba1dcdf3950d76 --- M s

Change in plasma-framework[master]: Fix leak in ContainmentActions

2015-02-11 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/366 Change subject: Fix leak in ContainmentActions .. Fix leak in ContainmentActions Change-Id: I41c9b9c224b36b045034755b07a92f2bdfe9f4

Change in plasma-framework[master]: Unify when tooltips are shown and kept alive.

2015-02-10 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/365 Change subject: Unify when tooltips are shown and kept alive. .. Unify when tooltips are shown and kept alive. A new tooltip would

Change in plasma-framework[master]: restore hint-apply-color-scheme support

2015-01-28 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/346 Change subject: restore hint-apply-color-scheme support .. restore hint-apply-color-scheme support make hint-apply-color-scheme work (

Change in plasma-framework[master]: export textFormat for the tooltip

2015-01-27 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/345 Change subject: export textFormat for the tooltip .. export textFormat for the tooltip in some cases richtext in the tooltip is not de

Change in plasma-framework[master]: Make keyboard shortcuts work

2015-01-23 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/342 Change subject: Make keyboard shortcuts work .. Make keyboard shortcuts work QAction keyboard shortcuts cannot work with QML2 (and pro

Change in plasma-framework[master]: don't animate icons when they get resized

2015-01-16 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/336 Change subject: don't animate icons when they get resized .. don't animate icons when they get resized simplify a bit logic ans make s

Change in plasma-framework[master]: never resize a dialog bigger than the screen

2015-01-16 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/334 Change subject: never resize a dialog bigger than the screen .. never resize a dialog bigger than the screen in cases screen resolutio

Change in plasma-framework[master]: Hack: silence failing test on Qt 5.2

2015-01-14 Thread Code Review
Jan Kundrát has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/324 Change subject: Hack: silence failing test on Qt 5.2 .. Hack: silence failing test on Qt 5.2 I guess nobody cares enough to debug why t

Change in plasma-framework[master]: Change string from non-existing %2 to %1.

2015-01-12 Thread Xuetian Weng (Code Review)
Xuetian Weng has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/318 Change subject: Change string from non-existing %2 to %1. .. Change string from non-existing %2 to %1. Change-Id: I52b69a7bd65118c5d0a

Change in plasma-framework[master]: Add HiddenAction in Plasma::Types::ActionType

2015-01-02 Thread Bhushan Shah (Code Review)
Bhushan Shah has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/301 Change subject: Add HiddenAction in Plasma::Types::ActionType .. Add HiddenAction in Plasma::Types::ActionType This is to hide actions

Change in plasma-framework[master]: Set visibility on mainItem to match Dialog

2014-12-28 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/282 Change subject: Set visibility on mainItem to match Dialog .. Set visibility on mainItem to match Dialog Otherwise we can have an i

Change in plasma-framework[master]: migrate to KPackage

2014-12-23 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/260 Change subject: migrate to KPackage .. migrate to KPackage Plasma::Package internally uses KPackage, being a pure wrapper. old client

Change in plasma-framework[master]: Add a plotter component

2014-12-16 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/244 Change subject: Add a plotter component .. Add a plotter component a Plotter can draw a graph of values arriving from an arbitrary num

Change in plasma-framework[master]: save some CPU cycle when busy indicator is not visible.

2014-12-14 Thread Xuetian Weng (Code Review)
Xuetian Weng has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/240 Change subject: save some CPU cycle when busy indicator is not visible. .. save some CPU cycle when busy indicator is not visible. Cha

Change in plasma-framework[master]: Use the same text colour for comboboxes as buttons

2014-12-11 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/219 Change subject: Use the same text colour for comboboxes as buttons .. Use the same text colour for comboboxes as buttons Given comb

Change in plasma-framework[master]: Different themes between desktop and dialogs

2014-12-11 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/218 Change subject: Different themes between desktop and dialogs .. Different themes between desktop and dialogs different themes betwee

Change in plasma-framework[master]: Use a shared config in tooltip

2014-12-10 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/216 Change subject: Use a shared config in tooltip .. Use a shared config in tooltip Change-Id: I68521f9066114a265c3f3444332e5e67016207

Change in plasma-framework[master]: Reparse settings when they change

2014-12-10 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/217 Change subject: Reparse settings when they change .. Reparse settings when they change Change-Id: Ibb13077943330417fa08d23ce1ea60f2

Change in plasma-framework[master]: Save SVGs only when a theme is unloaded, not on each theme p...

2014-12-10 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/215 Change subject: Save SVGs only when a theme is unloaded, not on each theme proxy .. Save SVGs only when a theme is unloaded, not on

Change in plasma-framework[master]: Do not keep reparsing plasmarc configuration

2014-12-10 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/214 Change subject: Do not keep reparsing plasmarc configuration .. Do not keep reparsing plasmarc configuration KConfig->reparseConfig

Change in plasma-framework[master]: roundToIconSize(0) should return 0

2014-12-10 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/213 Change subject: roundToIconSize(0) should return 0 .. roundToIconSize(0) should return 0 If an invalid icon size is passed to round

Change in plasma-framework[master]: plasma_containmentactions_test: Link to KI18n

2014-12-09 Thread Heiko Becker (Code Review)
Heiko Becker has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/210 Change subject: plasma_containmentactions_test: Link to KI18n .. plasma_containmentactions_test: Link to KI18n I get "CMakeFiles/plasm

Change in plasma-framework[master]: Testing the CI integration, ignore this

2014-12-09 Thread Code Review
Jan Kundrát has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/209 Change subject: Testing the CI integration, ignore this .. Testing the CI integration, ignore this Checking whether a CI tooling can ve

Change in plasma-framework[master]: Make tooltipEnabledGlobally public property

2014-12-08 Thread Bhushan Shah (Code Review)
Bhushan Shah has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/207 Change subject: Make tooltipEnabledGlobally public property .. Make tooltipEnabledGlobally public property This is case when some user

Change in plasma-framework[master]: Fix the platformstatus kded module

2014-12-02 Thread Martin Klapetek (Code Review)
Martin Klapetek has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/197 Change subject: Fix the platformstatus kded module .. Fix the platformstatus kded module The module .desktop file has a typo in the

Change in plasma-framework[master]: fix typo height -> width

2014-12-02 Thread Xuetian Weng (Code Review)
Xuetian Weng has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/196 Change subject: fix typo height -> width .. fix typo height -> width updateMinimumWidth and updateMaximumWidth wrongly set the updated

Change in plasma-framework[master]: export a plasma version number in themes

2014-12-02 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/195 Change subject: export a plasma version number in themes .. export a plasma version number in themes some of the behavior of the theme

Change in plasma-framework[master]: use PlasmaCore.ColorScope when suitable

2014-11-25 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/177 Change subject: use PlasmaCore.ColorScope when suitable .. use PlasmaCore.ColorScope when suitable It is possible to put a PlasmaCore.

Change in plasma-framework[master]: workaround on textarea input breaking

2014-11-04 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/145 Change subject: workaround on textarea input breaking .. workaround on textarea input breaking this makes sure if there is an item wit