D28066: Remove the STATIC_LIBRARY option to fix static builds

bartoc updated this revision to Diff 79439. bartoc added a comment. rebased on master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28066?vs=78262&id=79439 REVISION DETAIL https://phabricator.kde.org/D28066 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt To: bartoc, #kirig

D28066: Remove the STATIC_LIBRARY option to fix static builds

bartoc added a comment. Can I get any more feedback on this? what do I have to do to get it merged? REVISION DETAIL https://phabricator.kde.org/D28066 To: bartoc, #kirigami Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, ahiemstra, davidedmundson, mart

D28066: Remove the STATIC_LIBRARY option to fix static builds

bartoc updated this revision to Diff 78262. bartoc added a comment. Made setting STATIC_LIBRARY a fatal error. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28066?vs=77694&id=78262 REVISION DETAIL https://phabricator.kde.org/D28066 AFFECTED FILES CMakeLists.txt src/CMakeList

D28066: Remove the STATIC_LIBRARY option to fix static builds

bartoc added a comment. In D28066#628195 , @apol wrote: > Makes sense to me. +1 > > Since most people who did static builds will be using STATIC_LIBRARY, can you set a fatal error if it's on, so the devs know to use BUILD_SHARED_LIBS instead

D28066: Remove the STATIC_LIBRARY option to fix static builds

bartoc created this revision. bartoc added a reviewer: Kirigami. bartoc added a project: Kirigami. Herald added a subscriber: plasma-devel. bartoc requested review of this revision. REVISION SUMMARY Previously static builds were broken because GenerateExportHeader used: get_property(type TAR