D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

bosimonsen added a comment. In D14011#290076 , @ngraham wrote: > Does this really resolve all of https://bugs.kde.org/show_bug.cgi?id=366451? I see several issues described in there... Nate, can you maybe help getting this patch landed?

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

bosimonsen added a comment. @broulik what to do from here? I do not have commit access. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D14011 To: bosimonsen, davidedmundson Cc: davidedmundson, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

bosimonsen added a comment. In D14011#290076 , @ngraham wrote: > Does this really resolve all of https://bugs.kde.org/show_bug.cgi?id=366451? I see several issues described in there... I believe, most issues are resolved (the splash scre

D14011: Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM

bosimonsen updated this revision to Diff 37517. bosimonsen retitled this revision from "Use PlasmaComponents for Label" to "Use QtQuick.Controls 2.0 Label in energy and fileindexmonitor KCM". bosimonsen edited the summary of this revision. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D14011: Use PlasmaComponents for Label

bosimonsen added a comment. In D14011#289661 , @broulik wrote: > You can mix the two, just import it with a namespace > > import QtQuick.Controls 2.0 as QQC2 > > > and then `QQC2.Label`. I think it's still fine for 5.12 even this way.

D14011: Use PlasmaComponents for Label

bosimonsen added a comment. In D14011#289654 , @broulik wrote: > -1 > > Don't use Plasma components in "widget" Ui. Use `QtQuick.Controls 2` instead ScrollView is not available in QtQuick.Controls 2.0 appears to be at a later version.

D14011: Use PlasmaComponents for Label

bosimonsen updated this revision to Diff 37481. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14011?vs=37477&id=37481 REVISION DETAIL https://phabricator.kde.org/D14011 AFFECTED FILES Modules/energy/package/contents/ui/main.qml Modules/fileindexerm

D14011: Use PlasmaComponents for Label

bosimonsen created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bosimonsen requested review of this revision. REVISION SUMMARY The Label in QtQuick.Controls is only using renderType Text.QtRendering for mobile devices. T