On 2021-09-16 12:51, David Edmundson wrote:
We said in that meeting that you could ask on this thread for an
exemption (that was on the 6th).
Waiting until literally the release day and then asking for the
exemption and then merging within minutes of each other is absolutely
not ok!
David
Aft
On 2021-09-16 12:51, David Edmundson wrote:
We said in that meeting that you could ask on this thread for an
exemption (that was on the 6th).
Waiting until literally the release day and then asking for the
exemption and then merging within minutes of each other is absolutely
not ok!
David
Urg
On 2021-08-31 19:53, David Edmundson wrote:
Soft feature freeze is nearly here.
Soft freeze takes effect on Thursday the 2nd September. After that we
are to avoid any ridiculously big changes and huge refactors.
If there are any major things stuck in review, please respond to this
email so the
Git commit 4759737aa3635b8611b8ac3f31c6816cc9c68998 by Bhushan Shah.
Committed on 13/05/2021 at 12:11.
Pushed by bshah into branch 'master'.
ksystemstats should be in kde/workspace
It does not need to go through playground because it was split from
plasma/ repo already.
CCMAIL: pl
My fault
[2021-05-05T08:09:59.342Z] /home/jenkins/workspace/Plasma/plasma-workspace/
kf5-qt5 SUSEQt5.15/kcms/notifications/kcm.cpp:48:10: fatal error:
notificationmanager/badgesettings.h: No such file or directory
Potential fix for this,
https://invent.kde.org/plasma/plasma-workspace/-/merge_re
Plasma 5.21.5 is now released https://kde.org/announcements/plasma/5/5.21.5
signature.asc
Description: This is a digitally signed message part.
On Thursday, 29 April, 2021 4:40:35 PM IST David Edmundson wrote:
> At the end of the day is the soft freeze for Plasma 5.22, with the
> beta out on the 13th of May.
>
> After this point we should avoid any huge refactors and big features
> until we split the branch.
>
> Small features and change
public thread
at all.
- Is qqc2-breeze-style better choice for the Plasma Desktop?
I do not know and I personally have no stakes here, Marco has raised
perfectly valid technical points in his email, and I think those should
be discussed/solved.
Regards.
--
Bhushan Shah
http://blog.bshah.in
IRC Nick
a.yml
> CC0-1.0
> Jonathan
>
> test/plasma-tag-test-test.rb
> GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
> Jonathan
>
> test/translationunit_test.rb
> GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
> Jonathan, Harald
>
> test/plasma-webpages_test.rb
> GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
> Jonathan, Harald, Bhushan, Carl
>
> plasma/plasma-webpages
> GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
> Harald, Jonathan, Carl
>
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
Plasma 5.19.90 is now released
https://www.kde.org/announcements/plasma-5.19.90.php
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
bshah accepted this revision as: bshah.
bshah added a comment.
This revision is now accepted and ready to land.
I guess it would be nice to have this fixed somewhere else down the stack,
but would be nice to have this merged anyway as at least interim solution
REPOSITORY
R97 Bluedevil
BRAN
ayershell/
I am not sure how much active it is but it is definitely worth trying
out. Drew had worked on it during one of Plasma Sprint in Berlin:
https://drewdevault.com/2018/04/28/KDE-Sprint-retrospective.html
>
> HTH,
> Aleix
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Fr
On Wed, Jul 29, 2020 at 05:47:02PM +0530, Bhushan Shah wrote:
> If you have any ack/nack regarding this, please reply to this thread.
Personally speaking I'd say it makes sense to enable this so we do not
miss any merge requests and/or tasks discussions. Currently this mailing
list i
should discuss this with-in
mailing list and if no objections are raised within 72 hours. We can
enable it.
If you have any ack/nack regarding this, please reply to this thread.
[2] https://invent.kde.org/sysadmin/activityfilter#mailing-list-rules
--
Bhushan Shah
http://blog.bshah.in
IRC Nick
wonder if we should document this somewhere as a policy item?
To make this somewhat easier, what I have done is, added a label
"cherry-pick" which can be used with the merge request to categorize the
merge requests which should be cherry-picked to stable branch.
Thanks!
--
e change, though we can still discuss
> things here first.
What I meant was, test-drive this for small amount of one or two plasma
repositories and if that works better, we can then ask people for
adapting changes across KDE giving example.
>
> David
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
, but
that needs discussions in kde-devel/kde-core-devel separately.
Thoughts?
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
write up a blog post.
Thanks
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
mode (or for who uses tiling on desktop)
- reach out the developers of the big kwin tiling script
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
to do things
- documentation is fragmented
- investigate kdesrc-build env driver vs thing in plasma-workspace
- improve dependency list in kdesrc-build --initial-setup
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411
ever?
* install desktop file or wahtever for all watchers so we can enumerate for
settings and identify watchers
Other
* maybe increase maximum screen popup fill percentage
* "timeout" hint?
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
mers grow
> professionally and hopefully give them a reason to continue contributing to
> KDE. :-)
+1, I would be happy to provide such tutorial / personal guide if people
want help with it.
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7
/filtering take them as one entity.
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
!
Thanks
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
ay.
# Questions?
If you have any questions, please feel free to ping me here or on
#plasma channel.
[1] https://framadate.org/3zkUv4wGkWkOey8f
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
have nice summary of
major changes done for specific release, and what needs to be
merged/finished before release.
Cheers!
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description
backend and
verify that it still works with sysfs interface.
https://invent.kde.org/plasma/powerdevil/snippets/935
> (We're super early in the 5.20 cycle, so if we rip it out now, we still have
> four months to ignore any requests to put it back in ;)
I agree with this.
--
Bhus
e[]=VDG
https://invent.kde.org/dashboard/issues/?scope=all&utf8=%E2%9C%93&state=opened&label_name[]=VDG
This lists every MR and issues in instance which is tagged with VDG. I
*think* this covers your use-case. Any thoughts?
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenod
On Tue, May 19, 2020 at 07:08:59AM +0530, Bhushan Shah wrote:
> > - Do we want to keep issues enabled and use them for "tasks"?
> > - Do we want to have separate "tasks" boards under invent.kde.org/teams ?
> > Nico: vote for 2
> > Marco: vote for
t the issue in one dummy repository called "tasks"
I will send my opinion of which option is better IMO in separate email,
to keep this email as overview of options.
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
one.
Stay safe!
[1] https://community.kde.org/Sprints/Plasma/2020
[2] https://community.kde.org/Sprints/Plasma/2020Virtual
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2357e6f2e134: [libnotificationmanager] introduce the
WatchedNotificationsModel (authored by bshah).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28509?vs
bshah updated this revision to Diff 82489.
bshah added a comment.
rebase on master
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28509?vs=80990&id=82489
BRANCH
bshah/notification-watcher
REVISION DETAIL
https://phabricator.kde.org/D28509
AF
Git commit 53d913c3af459024d359c13def87db8913d8ed6b by Bhushan Shah.
Committed on 29/04/2020 at 11:09.
Pushed by bshah into branch 'master'.
projects: move new wayland repos to their final place
- plasma-wayland-protocols -> frameworks
- kwayland-server -> kde/workspace
Ref: T13
a.git/tree/projects-invent?h=bshah/invent
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
nclude any
namespace.
[url "https://invent.kde.org/";]
insteadOf = invent:
[url "g...@invent.kde.org:"]
pushInsteadOf = invent:
> (That said, bigflatlistofrepositories.kde.org .. or maybe call it
> cgit.kde.org
> .. could be a particular view onto gitlab wh
n it was projects.kde.org (chiliproject
installation).
[1] https://blog.bshah.in/2013/09/01/hello-planet/
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
sitories but they are instead offered the empty page. One
have to click on Shared repositories tab to actually see the list.
https://invent.kde.org/groups/sysadmin/test/test2/-/shared
This defeats the purpose of the creating subgroups (offering easy
reachability).
--
Bhushan Shah
http://blog.bshah.in
IR
ma" and
> "Frameworks", and so on).
As explained above, while grouping repositories is trying to solve the
merge requests/issue organization, it is not sole purpose of the
suggested grouping, discoverability and reachability is the main issue
we are trying to solve here.
[1] https://
refer when I don't have to guess this kind of things when
> fetching a repository.
[*] Ironically, in your case search would be helpful as you know you are
looking for knetwalk so you can just add it and search it
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
lement this next
week and move projects to https://invent.kde.org.
Thanks!
Bhushan for sysadmin team
[1]
https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D
bshah updated this revision to Diff 80990.
bshah edited the test plan for this revision.
bshah added a comment.
- watch for notification expiry and closing
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28509?vs=80847&id=80990
BRANCH
bshah/notif
bshah accepted this revision.
bshah added a comment.
Sorry for delay in testing this, works fine!
REPOSITORY
R120 Plasma Workspace
BRANCH
wider-notification-popu-when-on-top-or-bottom (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28989
To: ngraham, #vdg, #plasma,
bshah updated this revision to Diff 80847.
bshah added a comment.
- pass raw body data to the watcher
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28509?vs=80833&id=80847
BRANCH
bshah/notification-watcher
REVISION DETAIL
https://phabricator
bshah added a comment.
One last todo is fixing summary so it is not processed twice.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28509
To: bshah, #plasma, broulik, davidedmundson
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
bshah updated this revision to Diff 80833.
bshah added a comment.
rebase to master
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28509?vs=80832&id=80833
BRANCH
bshah/notification-watcher
REVISION DETAIL
https://phabricator.kde.org/D28509
AF
bshah added inline comments.
INLINE COMMENTS
> broulik wrote in notification.h:128
> Maybe add a new `rawHints() const`?
>
> Not a fan of ref return
I avoided using "raw" word in the function name, because when we process hints
we don't actually modify it. We just process rest of notifications
bshah updated this revision to Diff 80832.
bshah marked 15 inline comments as done.
bshah added a comment.
address various comments
- adhere to interface name when registering watcher
- remove unused code
- use qdbusservicewatcher
- add valid property
REPOSITORY
R120 Plasma Worksp
bshah added a comment.
Great! Since phab ate my nice commit message here we go,
I've re-worked previous revision of patch little bit differently,
- Instead of originally planned Watcher class, now there is
WatchedNotificationsModel
- Most if not all of original NotificationsModel c
bshah updated this revision to Diff 80391.
bshah marked 3 inline comments as done.
bshah added a comment.
- kill separate watcher class
- introduce AbstractNotificationsModel
- introduce WatchedNotificationsModel
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabr
bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.
LGTM, Please wait for @romangg to approve.
I am fine with behavior change of the,
- method rename of lock -> set/getAutoRotate
- all panels being considered for value of autorotate.
lt using the debos recipies at
https://invent.kde.org/bshah/devices. You can read more about debos at
https://github.com/go-debos/debos.
If you have any questions, feel free to join matrix room
#plasmamobile:kde.org or @plasmamobile telegram room.
> Thanks in advance
Cheers!
--
Bhushan Shah
bshah created this revision.
bshah added reviewers: Plasma, broulik, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
This allows one to subscribe to notifications from notification server.
Curren
need a bit more fleshing out of the lib to accommodate that.
Kai had some reservation about API/lib changes (check the backlog of
#plasma IRC channel today, alternatively Kai can explain this best).
>
> David
Cheers!
--
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
signature.asc
Description: PGP signature
I can add very simple QAIM/QALM in the greeter
source code, but that would essentially mean adding API for theme
developers, and I am hesistent to commit to API since it is a) not
future complete and b) there's better solution possible.
Any feedback on all of this?
--
Bhushan Shah
http://bl
bshah updated this revision to Diff 79013.
bshah added a comment.
- change signal name, notify caused confusion with notify of QObj
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28455?vs=78978&id=79013
BRANCH
bshah/ksld-dbus-notify
REVISION DETAI
bshah updated this revision to Diff 78978.
bshah added a comment.
- proper object instead of QMetaObject invokeMethod
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28455?vs=78968&id=78978
BRANCH
bshah/ksld-dbus-notify
REVISION DETAIL
https://ph
bshah planned changes to this revision.
bshah added a comment.
I need to add methods for the communicating the actions back to notification
server.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D28455
To: bshah
Cc: davidedmundson, plasma-devel, Orage, LeGast0
bshah abandoned this revision.
bshah added a comment.
Closed in favor of the more simpler version.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D28428
To: bshah, davidedmundson
Cc: davidedmundson, nicolasfella, plasma-devel, Orage, LeGast00n,
The-Feren-OS-De
bshah added inline comments.
INLINE COMMENTS
> davidedmundson wrote in greeterapp.cpp:497
> This pattern of fetching and poking the root object of a scene isn't one I
> like, it's better to expose an object to the view that then has normal
> signals and slots - but this does follow the conventi
bshah updated this revision to Diff 78968.
bshah added a comment.
- fixup comments mentioned by David
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28455?vs=78952&id=78968
BRANCH
bshah/ksld-dbus-notify
REVISION DETAIL
https://phabricator.kde.or
bshah added a subscriber: broulik.
bshah added a comment.
> +1 to using global and per-notification blacklists rather than a
per-notification whitelist
Plan is to change this in future, but for now to keep code simple I and
@broulik agreed on this solution.
(Also I am closing this d
bshah added inline comments.
INLINE COMMENTS
> davidedmundson wrote in server_p.cpp:234
> "This" will lack any context when someone is actually debugging this.
"This" debug statement should be removed :P
> davidedmundson wrote in server_p.cpp:245
> I assume you forgot to have an
>
> iface.Clos
bshah updated this revision to Diff 78961.
bshah marked 2 inline comments as done.
bshah added a comment.
- fix comments by David
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28454?vs=78951&id=78961
BRANCH
bshah/greeter-notify
REVISION DETAIL
bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
Currently this dbus interface allows the notification server to pass the
notifications, which then are forwarded to greeter theme by c
bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
This is alternative to previous revision which talks to ksldapp and then
ksldapp talks to the greeter over private wayland server inte
bshah updated this revision to Diff 78904.
bshah added a comment.
- properly wire up the protocol for ksldapp to greeter
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28428?vs=78883&id=78904
BRANCH
bshah/ksld-notifications
REVISION DETAIL
https
bshah updated this revision to Diff 78884.
bshah added a comment.
- adapt to changes in the kscreenlocker
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28427?vs=78871&id=78884
BRANCH
bshah/ksld-notify
REVISION DETAIL
https://phabricator.kde.
bshah updated this revision to Diff 78883.
bshah added a comment.
- add argument for the notification id in dbus service
- add wayland protocol stanza for passing notification data to greeter
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28428?vs=7
bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
This will allow notification manager to forward the notifications that
are meant to be shown on the lockscreen, currently it requires
bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
This is currently WIP, and doesn't fully work, requires patches on both
kscreenlocker and lockscreen theme.
TEST PLAN
tested that d
bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.
Makes sense
REPOSITORY
R104 KScreen
BRANCH
control-watching-fix
REVISION DETAIL
https://phabricator.kde.org/D28386
To: romangg, #plasma, bshah
Cc: bshah, plasma-devel, Orage, LeGast00
bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
bshah requested review of this revision.
REVISION SUMMARY
Previously it was totally not-functional
TEST PLAN
currently still need to actually connect to APN
bshah requested changes to this revision.
bshah added a comment.
Currently I am working on making this actually functional, so let's drop this
diff, my patch already uses the ScrollViewKCM.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D1839
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:7e98fd7c1b29: feat(kded): add a dbus method to lock
current rotation (authored by bshah).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28115?vs=78233&id=78234
RE
bshah updated this revision to Diff 78233.
bshah added a comment.
whitespace
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28115?vs=78232&id=78233
BRANCH
arcpatch-D28115
REVISION DETAIL
https://phabricator.kde.org/D28115
AFFECTED FILES
kded/config
bshah updated this revision to Diff 78232.
bshah added a comment.
- rename methods to AutoRotate
- write control file after change, thanks @romangg for suggestion
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28115?vs=77896&id=78232
BRANCH
arcpatch-D2
bshah added a comment.
This works as expected API wise and functionality wise, but internally
control config is not written at all. :/
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D28115
To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbla
bshah updated this revision to Diff 77896.
bshah added a comment.
- rename method to lock rotation
- disconnect/connect orientation sensor when we want to lock/unlock rotation
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28115?vs=77879&id=77896
BRANCH
bshah added a comment.
Maybe it would be sensible idea to instead connect/disconnect orientation
sensor, and replace method name with "inhibitAutoRotation"?
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D28115
To: bshah, romangg
Cc: plasma-devel, Orage, LeGast00n,
bshah updated this revision to Diff 77879.
bshah added a comment.
update branch
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28115?vs=77878&id=77879
BRANCH
arcpatch-D28115
REVISION DETAIL
https://phabricator.kde.org/D28115
AFFECTED FILES
kded/con
bshah created this revision.
bshah added a reviewer: romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
This allows to toggle the auto-rotation or temporary inhibit it on
mobile.
TEST PLAN
it works part
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3609f66a98bc: notifications: on mobile align popup to top
center (authored by bshah).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27968?vs=77346&id=7734
bshah created this revision.
bshah added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
any other position doesn't really make sense on mobile, so ignore popup
location
settings
REPOSITOR
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:624ff86e4766: fix: consider DSI display to be embedded
panel (authored by bshah).
REPOSITORY
R110 KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27806?vs=76857&id=76859
RE
bshah created this revision.
bshah added a reviewer: romangg.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
DSI connector type is widely used in mobile and tablet devices. Consider
them embedded so auto-rotati
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:98da04c657a0: globalaccel: allow sleep and hibernate
keyboard shortcuts (authored by bshah).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27721?vs=76618&id=
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:65585290f109: feat(kwayland): enable the auto-rotation
and tablet mode (authored by bshah).
REPOSITORY
R110 KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27723?vs=76640&id
bshah created this revision.
bshah added reviewers: romangg, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
Related kwin_wayland patches have been landed for rotation, so enable
the relevant fea
bshah created this revision.
bshah added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
This is useful for the phone specially. You can quickly turn on-off your
phone from lockscreen without
bshah added a comment.
> he said he'll figure it out.
(I have plan on how to handle that).
REPOSITORY
R122 Powerdevil
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27193
To: apol, #plasma, bshah, broulik
Cc: z3ntu, broulik, PureTryOut, plasma-devel, Orage, LeGast00n,
bshah added a comment.
This doesn't work on neon dev unstable and actually breaks the wallpaper.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D26972
To: ngraham, davidedmundson, #plasma, ognarb
Cc: bshah, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, za
bshah updated this revision to Diff 74417.
bshah added a comment.
add ::unloadModule which takes Module* parameter
REPOSITORY
R994 Pulseaudio Qt Bindings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26935?vs=74414&id=74417
BRANCH
add-load-unload-module
REVISION DETAIL
http
bshah added a comment.
> unloadModule should work with a Module* given the rest of the API deals
with them rather than their index I think
Yes, it does indeed make sense, maybe I can add a another signature of
unloadModule which takes Module* as argument.
> I was about to say someth
bshah created this revision.
bshah added reviewers: sitter, nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
Current usecase is dialer wanting to load the loopback modules
during runtime.
REPOSITOR
bshah requested changes to this revision.
bshah added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:33
>
> +option(ENABLE_QML_PROFILING "Enable QML profiler support" OFF)
> +
Commit description and code doesn't match :)
REPOSITORY
R1014 Kir
bshah accepted this revision.
bshah added inline comments.
INLINE COMMENTS
> bshah wrote in main.cpp:93
> I am bit unsure about this. We can simply write a configuration file in
> /etc/xdg using the plasma-phone-settings package.
On second thought, scratch all this.
REPOSITORY
R120 Plasma Wo
bshah added inline comments.
INLINE COMMENTS
> main.cpp:93
> KConfigGroup startupConfGroup(startupConf, "Shell");
> -const QString defaultShell = startupConfGroup.readEntry("ShellPackage",
> "org.kde.plasma.desktop");
> +const QString defaultShell = startupConfGroup.readEntry("Shell
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:243d0b6d4ea3: kcm/fonts: set initial settings correctly
(authored by bshah).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25140?vs=69258&id=70038
REVISION
bshah updated this revision to Diff 69258.
bshah added a comment.
update based on fvogt comment
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25140?vs=69255&id=69258
BRANCH
bshah/fonts
REVISION DETAIL
https://phabricator.kde.org/D25140
AFFECT
1 - 100 of 1141 matches
Mail list logo
