---
Everything is working fine except that after successful login, user has to
press back to view all the albums.
Thanks,
Ashish Bansal
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
[0] http://blog.davidedmundson.co.uk/node/89
--
*Regards,*
*Ashish Bansal*
*http://ashish-bansal.in <http://ashish-bansal.in>*
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
t.me/lydia.pintscher
> > KDE e.V. Board of Directors / KDE Community Working Group
> > http://kde.org - http://open-advice.org
> >
> >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscrib
d by the search engines.
[0] https://quickgit.kde.org/robots.txt
--
*Regards,*
*Ashish Bansal*
*http://ashish-bansal.in <http://ashish-bansal.in>*
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
ImageFetcher::setupImageFetcher ?
libs/mediacenter/medialibrary.h (line 59)
<https://git.reviewboard.kde.org/r/125993/#comment61657>
mediaUpdated still sounds wrong, although I am not sure what it should be
named. Anyway replace it with more logically correct name.
- Ashish Bansal
On Dec.
cate the media in the view ? Check
PmcMetadataModel::signalUpdate
libs/mediacenter/pmcmetadatamodel.cpp (line 87)
<https://git.reviewboard.kde.org/r/125993/#comment60835>
Remove White space error.
- Ashish Bansal
On Nov. 23,
> On Nov. 13, 2015, 9:23 a.m., Ashish Bansal wrote:
> > libs/mediacenter/lastfmimagefetcher.cpp, line 158
> > <https://git.reviewboard.kde.org/r/125993/diff/2-3/?file=416650#file416650line158>
> >
> > As imageFetcher is a signal, append "emit" wo
tps://git.reviewboard.kde.org/r/125993/#comment60563>
As imageFetcher is a signal, append "emit" word in the beginning. Although
it is an empty macro, but it helps in understanding code better.
- Ashish Bansal
On Nov. 12, 2015, 7:21 p.m., Aditya
n connect function.
- Ashish Bansal
On Nov. 12, 2015, 4:23 p.m., Aditya Dev Sharma wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://gi
marked as submitted.
Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK.
Changes
---
Submitted with commit c806f88e4ea65330719fa1721cdf15ea5cbddb5a by Ashish Bansal
to branch master.
Bugs: 341773
https://bugs.kde.org/show_bug.cgi?id=341773
Repository: kio
name: filename-1.6 (1).tar.gz
Diffs (updated)
-
autotests/globaltest.cpp ff8725d
src/core/global.cpp f18ac10
Diff: https://git.reviewboard.kde.org/r/123224/diff/
Testing
---
Works fine!
Thanks,
Ashish Bansal
___
Plasma-devel
Do we even need this special case, with the way the code is now? It
> > seems to me that removing this first if() branch would work just the same.
>
> Ashish Bansal wrote:
> The first if() has been used for getting ". (1).txt" instead of ".txt (1)&
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79629
-----------
On April 30, 2015, 9:05 a.m., Ashish Bansal wrote:
>
> -
).
Expected name: filename-1.6 (1).tar.gz
Diffs (updated)
-
autotests/globaltest.cpp ff8725d
src/core/global.cpp f18ac10
Diff: https://git.reviewboard.kde.org/r/123224/diff/
Testing
---
Works fine!
Thanks,
Ashish Bansal
___
Plasma-devel
gests wrong
name(something like filename-1 2.6.tar.gz).
Expected name: filename-1.6 (1).tar.gz
Diffs
-
autotests/globaltest.cpp ff8725d
src/core/global.cpp f18ac10
Diff: https://git.reviewboard.kde.org/r/123224/diff/
Testing
---
Works fine!
Thanks,
Ashish B
> On April 6, 2015, 1:12 p.m., Martin Klapetek wrote:
> > autotests/globaltest.cpp, line 96
> > <https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96>
> >
> > This should be (1).txt?
>
> Ashish Bansal wrote:
> imho if
e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79509
-------
On April 26, 2015, 12:19 p.m., Ashish Bansal wrote:
>
> ---
> This is an aut
/globaltest.cpp ff8725d
src/core/global.cpp f18ac10
Diff: https://git.reviewboard.kde.org/r/123224/diff/
Testing
---
Works fine!
Thanks,
Ashish Bansal
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo
ted e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review78559
-------
On April 4, 2015, 1:15 p.m., Ashish Bansal wrote:
>
> ---
> This is an
f18ac10
Diff: https://git.reviewboard.kde.org/r/123224/diff/
Testing
---
Works fine!
Thanks,
Ashish Bansal
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
> On Nov. 3, 2014, 3:48 a.m., Shantanu Tushar wrote:
> > browsingbackends/onlineservices/picasa/picasamodel.h, lines 60-61
> > <https://git.reviewboard.kde.org/r/120855/diff/3/?file=324518#file324518line60>
> >
> > where do you get these from?
>
>
https://git.reviewboard.kde.org/r/120855/#review69698
-------
On Nov. 2, 2014, 3:34 p.m., Ashish Bansal wrote:
>
> ---
> This is an automatically generated e-ma
---
Everything is working fine except that after successful login, user has to
press back to view all the albums.
Thanks,
Ashish Bansal
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
Everything is working fine except that after successful login, user has to
press back to view all the albums.
Thanks,
Ashish Bansal
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
r hardcode locations. Instead
> > use find_package.. See L25 of plasma-mediacenter/CMakeLists.txt for example
>
> Ashish Bansal wrote:
> Like this -> find_package(LibKGAPI2_LIBRARY REQUIRED). If it is correct
> then it's okay because cmake is unable to find its path fo
for me that's why I
hardcoded its path.
- Ashish
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120855/#review69671
---------
/120855/diff/
Testing
---
Everything is working fine except that after successful login, user has to
press back to view all the albums.
Thanks,
Ashish Bansal
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo
----
On Oct. 28, 2014, 5:14 p.m., Ashish Bansal wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120855/
> --
view all the albums.
Thanks,
Ashish Bansal
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
29 matches
Mail list logo
