D17706: Fix lock screen focus

2019-02-07 Thread Andrey Bychkov
andreyby added a comment. mrd...@altlinux.org REVISION DETAIL https://phabricator.kde.org/D17706 To: andreyby, davidedmundson Cc: ngraham, graesslin, abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17706: Fix lock screen focus

2019-02-06 Thread Andrey Bychkov
andreyby added a comment. When we use the X11BypassWindowManagerHint flag with a call to the showFullScreen() function on the x11 platform, requestActivate does not make the desired window active. For correct work, on x11 we have to call the show() function. But when the focus is set on a wi

D17706: Fix lock screen focus

2019-02-05 Thread Andrey Bychkov
andreyby updated this revision to Diff 50911. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17706?vs=50543&id=50911 REVISION DETAIL https://phabricator.kde.org/D17706 AFFECTED FILES greeter/greeterapp.cpp greeter/greeterapp.h To: andreyby, davidedmundson Cc: ngraham, graesslin,

D17706: Fix lock screen focus

2019-01-30 Thread Andrey Bychkov
andreyby added a comment. On x11 flag removal does not affect the created window, we can use this to put the focus. INLINE COMMENTS > graesslin wrote in greeterapp.cpp:460 > David already said it: we cannot do this. Changing the > X11BypassWindowManagerHint flag after the window is created

D17706: Fix lock screen focus

2019-01-30 Thread Andrey Bychkov
andreyby updated this revision to Diff 50543. andreyby added a comment. It's works for x11 platform. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17706?vs=49444&id=50543 REVISION DETAIL https://phabricator.kde.org/D17706 AFFECTED FILES greeter/greeterapp.cpp To: andreyby, da

D17706: Fix lock screen focus

2019-01-14 Thread Andrey Bychkov
andreyby updated this revision to Diff 49444. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17706?vs=47933&id=49444 REVISION DETAIL https://phabricator.kde.org/D17706 AFFECTED FILES greeter/greeterapp.cpp To: andreyby, davidedmundson Cc: graesslin, abetts, davidedmundson, plasma-

D17706: Fix lock screen focus

2019-01-09 Thread Andrey Bychkov
andreyby added a comment. What do you think? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D17706 To: andreyby, davidedmundson Cc: abetts, davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D17706: Fix lock screen focus

2018-12-20 Thread Andrey Bychkov
andreyby added a comment. **davidedmundson ** //we don't want to cursor grab in testing mode, this change is lost//yes, did not notice //This is still relevant A cursor can be in none.//I think this is superfluous, because the default focus is on the first screen. //why are we c

D17706: Fix lock screen focus

2018-12-20 Thread Andrey Bychkov
andreyby updated this revision to Diff 47933. REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17706?vs=47879&id=47933 REVISION DETAIL https://phabricator.kde.org/D17706 AFFECTED FILES greeter/greeterapp.cpp To: andreyby, davidedmundson Cc: abetts, d

D17706: Fix lock screen focus

2018-12-20 Thread Andrey Bychkov
andreyby created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. andreyby requested review of this revision. REVISION SUMMARY When the screen is locked, the focus always remains on the main screen, this patch fixes the problem. Now the focus is on the scr