D5093: Add ~/.local/share/icons to icons search paths

2017-09-03 Thread Andrey Bondrov
abondrov added a comment. In https://phabricator.kde.org/D5093#142799, @rkflx wrote: > Pushing or landing might not work if you use the wrong prefix as the push target. It should be `g...@git.kde.org:`. You can check with `git remote -v`. Thanx for your help! After adding these l

D5093: Add ~/.local/share/icons to icons search paths

2017-09-03 Thread Andrey Bondrov
This revision was automatically updated to reflect the committed changes. Closed by commit R135:f9e5b852faa7: Add ~/.local/share/icons to icons search paths (authored by abondrov). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D5093: Add ~/.local/share/icons to icons search paths

2017-09-01 Thread Andrey Bondrov
abondrov added a comment. In https://phabricator.kde.org/D5093#142156, @rkflx wrote: > At [2] you can find more information. Please report back if this is missing any information, which questions you still have after reading it or any issues you encounter when getting to know Arcanist. O

D5093: Add ~/.local/share/icons to icons search paths

2017-09-01 Thread Andrey Bondrov
abondrov added a comment. In https://phabricator.kde.org/D5093#142069, @davidedmundson wrote: > Do you have commit access? I guess I should still have it. But I don't know how to make commit message look like this one (with phabricator info): https://cgit.kde.org/plasma-integrati

D5093: Add ~/.local/share/icons to icons search paths

2017-09-01 Thread Andrey Bondrov
abondrov updated this revision to Diff 19048. abondrov added a comment. Remove XDG_DATA_DIRS stuff. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5093?vs=18417&id=19048 REVISION DETAIL https://phabricator.kde.org/D5093

D5093: Add ~/.local/share/icons to icons search paths

2017-08-19 Thread Andrey Bondrov
abondrov updated this revision to Diff 18417. abondrov added a comment. Re-create diff against Plasma/5.10 branch. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5093?vs=18416&id=18417 REVISION DETAIL https://phabricator

D5093: Add ~/.local/share/icons to icons search paths

2017-08-19 Thread Andrey Bondrov
abondrov updated this revision to Diff 18416. abondrov added a comment. Use QStandardPaths wtih GenericDataLocation to include ~/.local/share/icons if it exists. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5093?vs=12578

D5093: Add ~/.local/share/icons to icons search paths

2017-03-20 Thread Andrey Bondrov
abondrov added a comment. In https://phabricator.kde.org/D5093#96405, @broulik wrote: > I have various icons in ~/.local/share/icons/hicolor and .desktop files referencing them just by name and that works fine. Likely KF5 application running from KDE 4 Workspace with icon theme se

D5093: Add ~/.local/share/icons to icons search paths

2017-03-20 Thread Andrey Bondrov
abondrov added a comment. In https://phabricator.kde.org/D5093#96379, @broulik wrote: > Why? Also, shouldn't it use `QStandardPaths` as XDG locations can change. At least some users expect it to be user's path for /usr/share/icons and place icons there. BTW, shouldn't plasma

D5093: Add ~/.local/share/icons to icons search paths

2017-03-17 Thread Andrey Bondrov
abondrov created this revision. abondrov added a project: Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We need to add ~/.local/share/icons to icons search paths in

Re: Review Request 128392: [kickoff] kickoff should use icons from icon theme

2017-02-08 Thread Andrey Bondrov
in #365204) 5. Applied the patch 6. Rebooted 7. All Kickoff icons are properly set to Oxygen Thanks, Andrey Bondrov

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

2016-07-27 Thread Andrey Bondrov
> On Июнь 24, 2016, 2:52 п.п., Andrey Bondrov wrote: > > Looks like this plasmoid doesn't accept keyboard shortcuts. Testing done: > > 1. KF 5.23.0 > > 2. Plasma 5.6.5 > > 3. MiminizeAll applet latest snapshot from github (May 31, 2016) > > 4. ShowDeskto

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-27 Thread abondrov (Andrey Bondrov)
abondrov added a comment. In https://phabricator.kde.org/D2283#42745, @mart wrote: > can you add the BT to that report? Surely. I added it earlier today. REVISION DETAIL https://phabricator.kde.org/D2283 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Updated] D2301: [Kicker] Add missing config-workspace.h include to appentry.cpp

2016-07-27 Thread abondrov (Andrey Bondrov)
abondrov removed reviewers: ivan, mart. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2301 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: abondrov, hein, sebas Cc: plasma-devel, jensreuterberg, abetts, sebas _

[Differential] [Request, 1 line] D2301: [Kicker] Add missing config-workspace.h include to appentry.cpp

2016-07-27 Thread abondrov (Andrey Bondrov)
abondrov created this revision. abondrov added reviewers: hein, mart, ivan. abondrov set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Kicker uses "#ifde

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-27 Thread abondrov (Andrey Bondrov)
abondrov added a comment. In https://phabricator.kde.org/D2283#42693, @abondrov wrote: > I'll ask our QA engineer to give it more testing and let you know if we find anything interesting related to this issue. QA engineer confirms that Plasma doesn't crash with these changes. I'll

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-26 Thread abondrov (Andrey Bondrov)
abondrov added a comment. @ivan, @mart I confirm, this way it seems to work. 1. plasma-workspace: https://abf.rosalinux.ru/abondrov/plasma5-workspace/tree/rosa2014.1 2. plasma-config: https://abf.rosalinux.ru/abondrov/plasma5-config-fresh/tree/rosa2014.1 3. plasma-lnf: https://

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-26 Thread abondrov (Andrey Bondrov)
abondrov added a comment. @ivan, @mart > Since you are really helpful and active, I have a couple of things for you to test :) (please do not kill me) I'll test it tomorrow. It takes some time to build patched plasma-workspace package and then build ISO with it. Thanx for worki

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-26 Thread abondrov (Andrey Bondrov)
abondrov added a comment. In https://phabricator.kde.org/D2283#42598, @ivan wrote: > This one needs to go away, along with making kactivitymanagerd a hard runtime requirement: > > > https://abf.rosalinux.ru/import/plasma5-workspace/blob/rosa2014.1/plasma-workspace-5.7.2-layout-initia

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-25 Thread abondrov (Andrey Bondrov)
abondrov added a comment. In https://phabricator.kde.org/D2283#42565, @ivan wrote: > @abondrov > > Have you applied any patch other than this one to plasma? Another question, do you have a repository of what changes your distro is doing during packaging - maybe we are missing somethi

[Differential] [Commented On] D2283: patch from https://bugs.kde.org/show_bug.cgi?id=365989

2016-07-25 Thread abondrov (Andrey Bondrov)
abondrov added a comment. > I have no idea whatsoever, i'm just reporting a patch that the distro maintainer says it's working, but I don't know why. putting it there to discuss and trying to understand It's working because with this patch Plasma doesn't try to delete the activity it's

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

2016-07-21 Thread Andrey Bondrov
> On June 24, 2016, 2:52 p.m., Andrey Bondrov wrote: > > Looks like this plasmoid doesn't accept keyboard shortcuts. Testing done: > > 1. KF 5.23.0 > > 2. Plasma 5.6.5 > > 3. MiminizeAll applet latest snapshot from github (May 31, 2016) > > 4. ShowDeskto

Review Request 128392: [kickoff] kickoff should use icons from icon theme

2016-07-07 Thread Andrey Bondrov
, Andrey Bondrov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

2016-06-24 Thread Andrey Bondrov
while MinimizeAll doesn't. - Andrey Bondrov On Апрель 28, 2016, 8:11 д.п., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

2016-06-23 Thread Andrey Bondrov
> On Апрель 28, 2016, 8:35 д.п., Thomas Pfeiffer wrote: > > Thank you for providing a screenshot! > > > > Now I just need to understand what problem this applet is supposed to solve. > > The original problem Sebas wanted to solve was that "Show Desktop" hid the > > panel. That has been fixed in

Re: Review Request 105319: DBus-interface for changing wallpapers

2015-03-31 Thread Andrey Bondrov
> On Фев. 8, 2013, 9:48 п.п., Albert Astals Cid wrote: > > Varun, it seems Aaron had some comments, can you have a look at them? > > Varun Herale wrote: > Yes, I am looking at it right now. > > Andrey Bondrov wrote: > My patch, based on yours and code from

Re: Review Request 122934: Fix tests (replace removed upower_interface with freedesktop_interface)

2015-03-22 Thread Andrey Bondrov
MakeLists.txt 528eaa8 Diff: https://git.reviewboard.kde.org/r/122934/diff/ Testing --- Thanks, Andrey Bondrov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122934: Fix tests (replace removed upower_interface with freedesktop_interface)

2015-03-13 Thread Andrey Bondrov
---- Thanks, Andrey Bondrov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 105319: DBus-interface for changing wallpapers

2014-02-20 Thread Andrey Bondrov
> On Feb. 8, 2013, 9:48 p.m., Albert Astals Cid wrote: > > Varun, it seems Aaron had some comments, can you have a look at them? > > Varun Herale wrote: > Yes, I am looking at it right now. My patch, based on yours and code from kdeplasma-addons/applets/frame/frame.cpp: https://bugs.kde.org