D13694: Fix wrong availability of profiles and ports.

2018-06-27 Thread Andreas Krutzler
akrutzler added a comment. Good. :) I don't have commit rights yet so I think I can't do it there. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13694 To: akrutzler, nicolasfella, broulik, drosca Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliez

D13694: Fix wrong availability of profiles and ports.

2018-06-26 Thread Andreas Krutzler
akrutzler updated this revision to Diff 36728. akrutzler added a comment. Implement `setInfo` function for each, the `Port` and `Profile` class. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13694?vs=36717&id=36728 BRANCH fix_wrong_av

D13694: Fix wrong availability of profiles and ports.

2018-06-26 Thread Andreas Krutzler
akrutzler added a comment. My patched version of the plugin for the KCM wasn't loaded correctly, that's why I saw the same results. I'm still struggling developing KDE libs/plugins but it's getting better :) I solved the problem by implementing the `setInfo` function for each, the `Port

D13694: Fix wrong availability of profiles and ports.

2018-06-26 Thread Andreas Krutzler
akrutzler updated this revision to Diff 36717. akrutzler added a comment. Accept profiles which are not unavailable. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13694?vs=36558&id=36717 BRANCH fix_wrong_availability REVISION DETAIL

D13694: Fix wrong availability of profiles and ports.

2018-06-26 Thread Andreas Krutzler
akrutzler added a comment. In D13694#282499 , @nicolasfella wrote: > This breaks the profile selection Combobox in the KCM. I'm sorry to hear that, on my system I get the same results as in the released kcm. In D13694#282499

D13694: Fix wrong availability of profiles and ports.

2018-06-23 Thread Andreas Krutzler
akrutzler created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. akrutzler requested review of this revision. REVISION SUMMARY Fixed bug where available ports are displayed as unavailable/unplugged and vice versa. It seems

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

2018-02-21 Thread Andreas Krutzler
akrutzler updated this revision to Diff 27724. akrutzler added a comment. Rebase to origin/Plasma/5.12. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10701?vs=27642&id=27724 BRANCH diffD10701 REVISION DETAIL https://phabricator.kde.or

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

2018-02-20 Thread Andreas Krutzler
akrutzler added a comment. Not yet, @ngraham did all the commits for me so far. Just in case, my email is andreas.krutz...@gmx.net :) REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_softw

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

2018-02-20 Thread Andreas Krutzler
akrutzler added a comment. The gifs were the hardest part :) REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

2018-02-20 Thread Andreas Krutzler
akrutzler edited the summary of this revision. akrutzler added reviewers: apol, ngraham. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

2018-02-20 Thread Andreas Krutzler
akrutzler created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. akrutzler requested review of this revision. REVISION SUMMARY If you're using Breeze Dark or probably any other dark theme, the screenshot shadow-gradient wi