abalaji added inline comments.
INLINE COMMENTS
> avaldes wrote in suspendsessionconfig.cpp:45
> something like this?
>
> : ActionConfig(parent),
> m_suspendThenHibernateEnabled(nullptr)
Yeah exactly. So a subtle detail of C++ constructors is any data members which
are not primitive (like
abalaji added inline comments.
INLINE COMMENTS
> suspendsessionconfig.cpp:45
> {
> -
> +m_suspendThenHibernateEnabled = nullptr;
> }
Move this to the initializer
REPOSITORY
R122 Powerdevil
BRANCH
arcpatch-D16425_1
REVISION DETAIL
https://phabricator.kde.org/D16425
To: avaldes, br
abalaji added inline comments.
INLINE COMMENTS
> suspendsessionconfig.cpp:122
> +int comboBoxMaxWidth = 300;
> +if (m_suspendThenHibernateEnabled) {
> +comboBoxMaxWidth = qMax(comboBoxMaxWidth,
> m_suspendThenHibernateEnabled->sizeHint().width());
After doing the above, this if
abalaji added inline comments.
INLINE COMMENTS
> suspendsession.cpp:137
> Q_EMIT aboutToSuspend();
> -suspendJob =
> backend()->suspend(PowerDevil::BackendInterface::ToRam);
> +if (m_suspendThenHibernateEnabled) {
> +suspendJob =
> backend()-
abalaji added a comment.
@davidedmundson awesome! I've been running around in circles trying to find
this, glad that you fixed it! Although I'm the future we should support this
properly.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D15942
To: davidedmundson, #plas
