D28487: Redesign of system monitor plasmoids

alexde added a comment. Not sure, if this is part of the scope of this work, but do you also plan to add some meaningful labels and ticks to the axis? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28487 To: mart, #plasma Cc: alexde, ngraham, ksmanis, davi

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

alexde added a comment. In D27198#607110 , @ngraham wrote: > I tried 1.4 but it looked a bit too small to me, and not sufficiently differentiated from the level 2 and 3 headings in content areas: When looking at the screenshots, 1.4 looks

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

alexde added a comment. Looks way better, thanks Nate! Since case 1 to 3 are steps of 0.1 and from case 3 to 4 is a step of 0.2, how would it looke like with 1.40 instead of 1.50? Would it be too small? Would you like attach another screenshot please? :-) REPOSITORY R169 Kirigami BR

D15418: Dim application icon when it is not playing anything

alexde added a comment. In D15418#604200 , @broulik wrote: > > Can't we dim label instead? > > I quite like that. Also not very obvious what it means, I guess.. Not sure if it was already discussed, but what about adding an overlay mu

D26392: Add option to easily configure and start a hotspot

alexde added a comment. > UI-wise, this would probably be better off as a button than a checkbox. Personally, I'm more inclined to a checkbox. Why is "turn wifi on/off" not an action? Right now, I don't see the big difference. (I assume "hotspot" and "shared wifi" are equivalent.)

D21273: Add support for newer linux kernel power_supply API

alexde added a comment. In D21273#586877 , @luc4 wrote: > Probably the consequence of not reviewing changes? This one can probably be abandoned. What a shame! As you are familiar with the code, you could probably review the other patch

D21273: Add support for newer linux kernel power_supply API

alexde added a comment. This patch looks pretty similar to the already merged one https://phabricator.kde.org/D25018. How are they related? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson, broulik, hein Cc: alexde, meven, alexeymin,

D20569: RFC: Use more compact OSD

alexde added a comment. Since the most common problem that people have is "the OSD gets in the way when I change the volume while playing a video", how about only changing those OSD styles for the "volume" and "brightness" and leave the rest as it is with their characteristic appearance and

D14949: Add option for whether to show the volume change OSD

alexde added a comment. Personally I am in favour of the current Windows 10 style, a compact version in the top left corner. I tried to to create a mockup to demonstrate how it could look like: F7825127: Mockup.png To make hopefully everyone happy

D25018: Move ACPI battery information from /proc/acpi to /sys

alexde added a comment. In D25018#561268 , @jjorge wrote: > > Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100? > > Yes : this is a percentage. States out of this value are bad ha

D25018: Move ACPI battery information from /proc/acpi to /sys

alexde added inline comments. INLINE COMMENTS > acpi.c:129 > +} else if (state < 0) { > +state = 0; /* prevent insane numbers with bad hardware */ > } Are states > 100 or < 0 really well defined? Is it save to assume that a state > 100 can be associated with 100? > acpi.c:161

D24379: [energy kcm] Fix Technology values

alexde added a comment. As this it not in the scope of this patch, those values look suspicious to me too: switch(model.battery.type) { case 3: return i18n("Internal battery") case 2: return i18n("UPS battery") case 9: return i18n("Monitor battery") case 4: return i18n("

D24036: Fix the last fix of the max y-range computation

alexde updated this revision to Diff 66344. alexde added a comment. The next loop starts with index+1. This rare case with index out of bounds should not happen, but just in case ... REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24036?vs=66343&id=6634

D24036: Fix the last fix of the max y-range computation

alexde added a comment. This range check should definitely be included. The other error, I don't know right away. If no one else spots it, I will check it on the weekend. Regards REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D24036 To: alexde, #vdg, ngraha

D24036: Fix the last fix of the max y-range computation

alexde updated this revision to Diff 66343. alexde added a comment. Add range check for index variable REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24036?vs=66340&id=66343 BRANCH ymax_again (branched from master) REVISION DETAIL https://phabrica

D24036: Fix the last fix of the max y-range computation

alexde added a comment. In D24036#533557 , @ngraham wrote: > I still get: > > file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined > file:///home/nate

D24036: Fix the last fix of the max y-range computation

alexde created this revision. alexde added reviewers: VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY The last fixed was not correct. This version should serve better. REPOSITORY R102 KInfoCenter

D24029: Fix maximum y-value-range computation

alexde created this revision. alexde added reviewers: VDG, Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY Rounding to the next 10 did not work if the maximum value was something like y_max = 30

D23520: Add time line to X axis

alexde updated this revision to Diff 66063. alexde added a comment. Remove redundant and now wrong comment REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66062&id=66063 BRANCH energy-timeline (branched from master) REVISION DETAIL https:/

D23520: Add time line to X axis

alexde updated this revision to Diff 66062. alexde added a comment. Fix offset calculation for the one hour graph REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66055&id=66062 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde added a comment. In D23520#531168 , @ngraham wrote: > Thanks, that's fixed now. However the "Last hour" graph still looks a little odd... > > F7350933: Screenshot_20190914_084935.png Mm,

D23520: Add time line to X axis

alexde updated this revision to Diff 66055. alexde added a comment. Fix typo in variable and by that make all X axis labels appear again. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66044&id=66055 BRANCH energy-timeline (branched from mas

D23520: Add time line to X axis

alexde updated this revision to Diff 66044. alexde added a comment. The former scaling of the x-Positions of the data points did not fit to the time axis. Now the x-values of the points, i. e. their timestamps, are correctly aligned. For some unknown reasons, all data points, which come

D23520: Add time line to X axis

alexde updated this revision to Diff 66034. alexde added a comment. Remove redundant semicolons and move comment about unit (ms) to the declaration of the var REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66031&id=66034 BRANCH energy-timel

D23520: Add time line to X axis

alexde updated this revision to Diff 66031. alexde added a comment. Use a switch statement for xTicksAt REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65457&id=66031 BRANCH energy-timeline (branched from master) REVISION DETAIL https://ph

D23520: Add time line to X axis

alexde added a comment. *Friendly ping to the reviewers.* REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23520 To: alexde, #vdg, ngraham, #plasma Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, hi

D23746: Set a minimum window size to reasonable 800x600 px.

alexde created this revision. alexde added reviewers: VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REPOSITORY R102 KInfoCenter BRANCH minimum-window-size (branched from master) REVISION DETAIL https://phabr

D23520: Add time line to X axis

alexde updated this revision to Diff 65457. alexde added a comment. Set correct right border for the grid lines and ticks. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65428&id=65457 BRANCH energy-timeline (branched from master) REVISION

D23520: Add time line to X axis

alexde updated this revision to Diff 65428. alexde added a comment. Move stroke() out of the loop. Reduce line with by pixel. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65423&id=65428 BRANCH energy-timeline (branched from master) REVI

D23520: Add time line to X axis

alexde updated this revision to Diff 65423. alexde added a comment. Shrink plotWidth a little bit so the earliest date on the right side may fit. Change the way the division widths are defined to hopefully make the code easier to understand and to maintain. REPOSITORY R102 KInfoCenter

D23520: Add time line to X axis

alexde added a comment. For some reason the xGridOffset seems sometimes to be wrong, and I have no explanation why. It especially happens for 1 hour graphs. F7320671: Screenshot_20190905_132313.png REPOSITORY R102 KInfoCenter REVISION DETAIL https:

D23520: Add time line to X axis

alexde requested review of this revision. alexde added a comment. I have changed some stuff, can you please review it again. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23520 To: alexde, #vdg, ngraham, #plasma Cc: bcooksley, plasma-devel, LeGast00n, The-Feren

D23520: Add time line to X axis

alexde updated this revision to Diff 65413. alexde added a comment. Rename variables to make their function clearer. Decrease the lower loop border by 1 to make sure that all possible grid lines are drawn. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D23520: Add time line to X axis

alexde updated this revision to Diff 65410. alexde added a comment. Fix issue that a date may be displayed unintentionally. Shrink right margin for grid lines and try to add an additional grid line on the right side if reasonable. Add more divisions for 2h and 24h graphs. REPOSITORY R1

D23520: Add time line to X axis

alexde updated this revision to Diff 65409. alexde added a comment. Use dashed grid lines instead of solid lines. Grid lines with tick labels are less faint. Rename variable to make its function clearer. Show grid lines at all five minutes for the 1 hour graph. REPOSITORY R102 KInfoCent

D23520: Add time line to X axis

alexde updated this revision to Diff 65407. alexde added a comment. Align grid to 10 minutes for the 1h graph. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65321&id=65407 BRANCH energy-timeline (branched from master) REVISION DETAIL htt

D23520: Add time line to X axis

alexde updated this revision to Diff 65320. alexde added a comment. - Set valid defaults. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64920&id=65320 BRANCH energy-timeline (branched from master) REVISION DETAIL https://phabricator.kde.

D23520: Add time line to X axis

alexde updated this revision to Diff 65321. alexde added a comment. Set valid defaults. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65320&id=65321 BRANCH energy-timeline (branched from master) REVISION DETAIL https://phabricator.kde.or

D23542: Promote KCM to top level and rename accordingly

agurenko added a comment. In D23542#523723 , @ngraham wrote: > In D23542#523306 , @agurenko wrote: > > > Can you still re-order devices to set priority of input/output devices? > > > That's not

D23542: Promote KCM to top level and rename accordingly

agurenko added a comment. Can you still re-order devices to set priority of input/output devices? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23542 To: ngraham, #vdg, #plasma, drosca, nicolasfella, sitter Cc: agurenko, ndavis, plasma-devel, LeG

D23520: Add time line to X axis

alexde added a comment. Right now I only display the date under the tick mark if the date has changed and the tickmark number is odd, which I think is already good enough for this graph. However, indicating a date change at midnight (12 pm / 0 am) would make sense as well. If you prefer th

D23520: Add time line to X axis

alexde updated this revision to Diff 64920. alexde added a comment. Fix displaying wrong variable. Add postfix "Str" to indicate that those vars are explicitely strings. Make sure that the date is only displayed when date has changed for <= 24h graphs. REPOSITORY R102 KInfoCenter CHANG

D23520: Add time line to X axis

alexde updated this revision to Diff 64896. alexde added a comment. Improve the formatting's consistancy REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64892&id=64896 BRANCH energy-timeline (branched from master) REVISION DETAIL https://p

D23520: Add time line to X axis

alexde updated this revision to Diff 64892. alexde added a comment. Update comment REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64890&id=64892 BRANCH energy-timeline (branched from master) REVISION DETAIL https://phabricator.kde.org/D23

D23520: Add time line to X axis

alexde updated this revision to Diff 64890. alexde added a comment. Omit the date if date equals today and the graph does not range over 24 hours. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64889&id=64890 BRANCH energy-timeline (branched

D23520: Add time line to X axis

alexde updated this revision to Diff 64889. alexde added a comment. Resolve formatting issues - remove semicolons - replace tab indention by 4 spaces - add space between operator and arguments REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2352

D23520: Add time line to X axis

alexde added a comment. > As you can see, it's kind of funny that only one of the labels has a date under it. This is fine for the multi-day graphs, but for the graphs that are entirely within the current day, I would recommend omitting the date. There's actually not such thing as a "sin

D23520: Add time line to X axis

alexde updated this revision to Diff 64840. alexde added a comment. Set more sane left/right margins REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64805&id=64840 BRANCH energy-timeline (branched from master) REVISION DETAIL https://phabr

D23520: Add time line to X axis

alexde updated this revision to Diff 64805. alexde added a comment. Set correct default value for a tick position REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=64803&id=64805 BRANCH energy-timeline (branched from master) REVISION DETAIL

D23520: Add time line to X axis

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY The current energy plot does not display any time line. This patch adds a grid and time stamps to the X

D23389: Use "Make default" buttons to switch the default device

alexde added a comment. > for various technical reasons that are not yet fixable Can you please point me to those? Is there ongoing work? I'm curious. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca, #plasma, #vdg Cc:

D23389: Use "Make default" buttons to switch the default device

alexde added a comment. > DnD is not very intuitive for things that don't look inherently draggable That's why I draw a frame around the entries and also the mouse pointer could change to a hand. Otherwise I neither really like 1) or 2). How do other systems handle this? REPOSITORY R1

D23389: Use "Make default" buttons to switch the default device

alexde added a comment. Just brainstorming: What about two sections, 1) "default" with a single entry and 2) "others". The user could drag and drop the speaker to default place and the current default one would move downwards with an animation.F7276701: Screenshot_20190824_201127.png

D23237: Do not display vendor, Product and capacity in network plasmoid

alexde added a comment. In D23237#514325 , @broulik wrote: > It literally says in the commit message that this will be moved exactly there. I definitely need more coffee, sorry. O:-) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23237: Do not display vendor, Product and capacity in network plasmoid

alexde added a comment. In which GUI do I find "Vendor" and "Model" now? There's the "Energy Information" in KInfocenter, which has a section "manufacturer" (in screenshot "Herstller"), but only lists the serial number. Maby it could go there? F7259918: Screenshot_20190819_105414.png

D22493: [Notifications] Move history items' icons over to the left a bit

alexde added a comment. Friendly ping. :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22493 To: ngraham, broulik, #vdg, #plasma Cc: alexde, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, al

D22493: [Notifications] Move history items' icons over to the left a bit

alexde added a comment. In D22493#496764 , @ngraham wrote: > Yeah, this patch touches only the history items, not the popups. I can do that too, if you'd like. Are you sure? When I applied this patch (+ units.iconSizes.medium) it looked

D22605: Set notifications entry icon size to medium

alexde added a comment. > For pictures (like people's faces in messenger notifications) I would still prefer the lager icons, though. I have to admit, that I'm not very much satisfied myself with the size. It could be a bit larger, something between medium and large. Maby we should disc

D22605: Set notifications entry icon size to medium

alexde added a comment. > You must run cmake for the whole repository; once done that, you can cd to the applets/notifications/ subdirectory of the builddir, and build only that part. What I also needed to install is kdesignerplugin then So the procedure is as follows:

D22605: Set notifications entry icon size to medium

alexde added a comment. I would like to test it and post a screenshot, however I am not able to compile it: 1. I cloned the source from the git repository 2. mkdir plasma-workspace/applets/notifications/build 3. cd plasma-workspace/applets/notifications/build 4. cmake .. This r

D22605: Set plasma-nm history entry icon size to medium

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY The current history entry icon is rather large and therefore hits the bottom of the entry in the list.

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

alexde added a comment. In D18809#408482 , @davidre wrote: > Do you mean the Controls on the top? (...) Please correct me if I'm wrong. Exactly, but let's wait for the expertise of Nate and the rest of the VDG team as I am not sure mysel

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

alexde added a comment. Great work! Currently you have a very long folder list object. However, in my experience most users only have a few folders, where they store their wallpapers. So, what about saving space by positioning the folder list to the right of the controls? As we now dis

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

alexde added a comment. In D17354#372274 , @ngraham wrote: > Changing the style just here would introduce inconsistency at a time when we're trying to make everything more consistent. The current FormLayout style is what we've decided on for the

D17354: [Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout

alexde added a comment. Thank you Nate! I am just curious if you considered to structure titles and options vertically, where the options are indeted by a tab: General [ ] Show week number Available plugins [ ] Plugin A [ ] Plugin B That's would I personally

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

alexde added a comment. I would like to introduce another suggestion, which has not yet came up: If you don't want to blur everything, how about to only blur an rectangle underneath the login controls. That means a combination of early Plasma 5 > The early Plasma 5 login screen put a dar

D15683: Add lock icon to desktop context menu

anemeth added a comment. My arcanist is still borked. Could someone please push this? Thank you. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 To: anemeth, ngraham, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D15683: Add lock icon to context menu

anemeth created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15683 AFFECTED FILES containments/desktop/plugins/

D15435: Add translucent background attribute to desktop icon popup menu

anemeth added a comment. I'm having problems with my arcanist. Could someone please land this for me? REPOSITORY R119 Plasma Desktop BRANCH fix_desktop_menu_tp REVISION DETAIL https://phabricator.kde.org/D15435 To: anemeth, hein, davidedmundson, #plasma Cc: ngraham, plasma-devel, ra

D15435: Add translucent background attribute to popup menu

anemeth updated this revision to Diff 41432. anemeth added a comment. Add translucent background attribute to popup menu REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15435?vs=41431&id=41432 BRANCH fix_desktop_menu_tp REVISION DETAIL https://p

D15435: Add translucent background attribute to popup menu

anemeth created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH fix_desktop_menu_tp REVISION DETAIL https://phabricator.kde.org/D15435 AFFECTED FILES containments/des

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

arichardson added a comment. +1 LGTM. Thanks! REVISION DETAIL https://phabricator.kde.org/D14440 To: dfaure, arichardson, anthonyfieroni, elvisangelaccio, plasma-devel, broulik

D14444: Use nullptr/override

al1xz updated this revision to Diff 38762. al1xz marked an inline comment as done. al1xz added a comment. Update REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=38674&id=38762 BRANCH arcpatch-D1 REVISION DETAIL https://phabricator.kde.or

D14444: Use nullptr/override

al1xz updated this revision to Diff 38674. al1xz added a comment. Update REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=38665&id=38674 BRANCH arcpatch-D1 REVISION DETAIL https://phabricator.kde.org/D1 AFFECTED FILES gui/SensorBro

D14444: Use nullptr/override

al1xz created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. al1xz requested review of this revision. REPOSITORY R106 KSysguard BRANCH new (branched from master) REVISION DETAIL https://phabricator.kde.org/D1 AFF

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

arichardson added a comment. Does this mean for Qt < 5.12 (or .13?) pressing open in kwrite will select the cwd again? I now have almost all my source directories NFS mounted rather than having to use sftp so it is no longer such a big issue for me. However, I do wonder if it makes sens

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. F6100511: breeze2x.PNG REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12804 To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, Zre

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. As others said the dpi scaling should normally be dealt with `QImage::setDevicePixelRatio()` As far as I can tell this is not working with Breeze for the following reason: The decoration rendering starts here: https://github.com/KDE/kwin/blob/master/decorations

D12804: Fix window frame rounding when scaling is used

anemeth updated this revision to Diff 37718. anemeth added a comment. Rebase on master REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12804?vs=33941&id=37718 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12804 AFFECTED FILES kdecoration/

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. Here is Breeze close button modified to use `QPainter::drawRoundedRect()` and uses the same radius (3) as the titlebar: F5848210: aa.PNG This scales well, so I don't think it is a bug in Qt. REPOSITORY R31 Breeze REV

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. In D12804#262333 , @zzag wrote: > Also, what session it is? (X11 or Wayland) > > I think you're facing one of X11 issues. X11 On Wayland it scales right REPOSITORY R31 Breeze REVISION DETAIL https://pha

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. In D12804#260610 , @hpereiradacosta wrote: > Also: how does it work with multiple monitors ? (I see you get the info from ::primaryScreen, not for the screen the window is actually on ? As far as I know KWin does

D12804: Fix window frame rounding when scaling is used

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R31 Breeze BRANCH titlebar-round-scaling (branched from master) REVISION DETAIL https://phabricator.

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson added a comment. In D4193#242444 , @fvogt wrote: > What about `Plasma/5.12`? It has a minimum of Qt 5.9 as well. Good point. Any objections against me cherry-picking it to the 5.12 branch? REPOSITORY R135 Integration for Qt a

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

This revision was automatically updated to reflect the committed changes. Closed by commit R135:bfd41a95530f: KDEPlatformFileDialog: Fix initial directory selection for remote files (authored by arichardson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson updated this revision to Diff 31284. arichardson edited the summary of this revision. arichardson added a comment. - Removed version check since we now depend on Qt 5.9 - Updated commit message REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

arichardson added a comment. I'll update and test this again when I get back to my work computer on Tuesday. Should I just remove the code or add a comment that since qt 5.8 it is no longer necessary to set the directory as well? REPOSITORY R135 Integration for Qt applications in Plasma R

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. In D9848#234268 , @zzag wrote: > > `GLRenderTarget::attachTexture` This was not changed. It was used by old blur and simple blur. Looks like it's not used anymore. > `GLRenderTarget::detachTextur

D10878: Changed default context menu entries on the desktop

anemeth abandoned this revision. anemeth added a comment. This is not removing settings, just disabling them by default. These could be enabled in the standard right click menu settings again. F5732210: Képkivágás.PNG I'll abandon this revision

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Alex Barrero changed: What|Removed |Added CC||alex.brrsc...@gmail.com --- Comment #18 from

D10878: Changed default context menu entries on the desktop

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Plasma, VDG. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10878 To: anemeth, #plasma, #vdg Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed

D10878: Changed default context menu entries on the desktop

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D10878 AFFECTED FIL

D10837: bad textarea width for rename file if filename too short

anemeth added a comment. works great REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma Cc: anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10522: Added vertical separator

anemeth abandoned this revision. anemeth added a comment. This change was submitted to supplement D10438 Because it was reverted in D10530 this change is not needed anymore. REPOSITORY R31 Breeze REVISION DETAIL

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. @hpereiradacosta I don't have commit access. Could you please commit it for me? REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, co

D10522: Added vertical separator

anemeth added a comment. The best looking solution would be that menu entries that have checkbox/radiobutton, do not get an icon and then we can show the icon and the checkbox/radiobutton on the left column. Like you see in the Windows 7 pic in the test plan. Or maybe I'm just used to tha

D10522: Added vertical separator

anemeth updated this revision to Diff 27202. anemeth added a comment. Reduced the width of the horizontal line so it doesn't intersect with the vertical line. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10522?vs=27201&id=27202 BRANCH master REVISION D

D10522: Added vertical separator

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: ngraham, hpereiradacosta, Breeze, VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10522 To: anemeth, ngraham, hpereiradacosta, #breeze, #vdg Cc: plasm

D10522: Added vertical separator

anemeth created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. anemeth requested review of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D10522 AFFECTED FILES kstyle

D10521: Accidental diff. Sorry.

anemeth removed R31 Breeze as the repository for this revision. anemeth removed a project: Plasma. anemeth removed a subscriber: plasma-devel. REVISION DETAIL https://phabricator.kde.org/D10521 To: anemeth Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

  1   2   3   4   5   6   7   8   >