D16425: Added new Suspend then Hibernate option

avaldes added a comment. In D16425#488963 , @davidedmundson wrote: > I'd quite like to get this in as I'll end up moving part of this - and we've got too much bikeshedding here. > > > i18n("While asleep, hibernate after 3 hours") > > If

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 60926. avaldes added a comment. Summary: See bug 399727 for a good description of what this code is for. The new ui will show a new option like the following image F6349860: screenshot.png

D16425: Added new Suspend then Hibernate option

avaldes marked 3 inline comments as done. avaldes added a comment. In D16425#475148 , @ericadams wrote: > I apologize if this is the wrong place to add this comment but I have a laptop where this applies and would benefit me. I am happy to help

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 59241. avaldes added a comment. Summary: See bug 399727 for a good description of what this code is for. The new ui will show a new option like the following image F6349860: screenshot.png

D16425: Added new Suspend then Hibernate option

avaldes added inline comments. INLINE COMMENTS > abalaji wrote in suspendsessionconfig.cpp:45 > Move this to the initializer something like this? : ActionConfig(parent), m_suspendThenHibernateEnabled(nullptr) REPOSITORY R122 Powerdevil BRANCH arcpatch-D16425_1 REVISION DETAIL htt

D16425: Added new Suspend then Hibernate option

avaldes marked 5 inline comments as done. avaldes added a comment. Sorry for the constant spam of the original commit message, I cannot make arcanist to pick up a new commit for this differential without deleting the old one. Added changes based on code review comments REPOSITORY R122

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 59170. avaldes marked 2 inline comments as done. avaldes added a comment. Added new Suspend then Hibernate option Summary: See bug 399727 for a good description of what this code is for. The new ui

D16425: Added new Suspend then Hibernate option

avaldes marked 5 inline comments as done. avaldes added a comment. Added changes based on recent comments. INLINE COMMENTS > abalaji wrote in suspendsessionconfig.cpp:106 > Stray line swap Done on purpose to change the UI: F6822188: suspendThenHibernate.png

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 58969. avaldes added a comment. Added new Suspend then Hibernate option Summary: See bug 399727 for a good description of what this code is for. The new ui will show a new option like the following

D16425: Added new Suspend then Hibernate option

avaldes marked 3 inline comments as done. avaldes added a comment. Updated with latest comments. Please land, I don't have permissions. REPOSITORY R122 Powerdevil BRANCH arcpatch-D16425_1 REVISION DETAIL https://phabricator.kde.org/D16425 To: avaldes, broulik, ngraham Cc: reveren

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 58273. avaldes added a comment. Added new Suspend then Hibernate option Summary: See bug 399727 for a good description of what this code is for. The new ui will show a new option like th

D16425: Added new Suspend then Hibernate option

avaldes added a comment. > This patch doesn't seem to work for me. I have Arch Linux, powerdevil-5.15.5-1 and your patch applied. After clicking the check-box the "Apply" button doesn't get active. Therefore, this setting is not being saved. Did you enable the Suspend Session option too?

D16425: Added new Suspend then Hibernate option

avaldes added a comment. In D16425#465321 , @ngraham wrote: > UI looks good enough for now. But is this the full diff? It seems like something got lost. The whole patch should include the changes from all commits in your branch, not just the las

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 58091. avaldes added a comment. Added new Suspend then Hibernate option Summary: See bug 399727 for a good description of what this code is for. The new ui will show a new option like the f

D16425: Added new Suspend then Hibernate option

avaldes added a comment. This is how it looks now @ngraham : F6822188: suspendThenHibernate.png REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16425 To: avaldes, broulik, ngraham Cc: meven, soriano, abalaji, graesslin,

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 58044. avaldes added a comment. Improved messages for suspend session REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16425?vs=56024&id=58044 BRANCH arcpatch-D16425_1 REVISION DETAIL https://phabricator.kde.org/

D16425: Added new Suspend then Hibernate option

avaldes added a comment. In D16425#464381 , @ngraham wrote: > This thing's UI really needs to be rewritten in QML. Once we do that and give it a proper FormLayout style, the string can be shorter, but for now, seeing it in context, I feel like

D21111: Added new option to use GlobalProtect with openconnect

avaldes added a comment. I can't land it, please merge @jgrulich REPOSITORY R116 Plasma Network Management Applet BRANCH globalprotect (branched from master) REVISION DETAIL https://phabricator.kde.org/D2 To: avaldes, jgrulich Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zren

D21111: Added new option to use GlobalProtect with openconnect

avaldes added a comment. In D2#463270 , @jgrulich wrote: > In D2#463216 , @avaldes wrote: > > > networkmanager-openconnect has added support in master for global protect

D21111: Added new option to use GlobalProtect with openconnect

avaldes updated this revision to Diff 57861. avaldes added a comment. - Changes based on code review REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=57837&id=57861 BRANCH globalprotect (branched from master) REVISION DET

D21111: Added new option to use GlobalProtect with openconnect

avaldes added a comment. networkmanager-openconnect has added support in master for global protect , so now we can use it from plasma. This was tested in my machine with Plasma 5.15

D21111: Added new option to use GlobalProtect with openconnect

avaldes created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. avaldes requested review of this revision. REVISION SUMMARY This adds a new option to the dropdown and a new desktop file to create a connection to a Palo A

D16425: Added new Suspend then Hibernate option

avaldes added a comment. In D16425#449026 , @meven wrote: > In D16425#448999 , @avaldes wrote: > > > I applied this patch to v5.15.4 tag and tested with that and it works (my machine is running plas

D16425: Added new Suspend then Hibernate option

avaldes added a comment. In D16425#448828 , @ngraham wrote: > In D16425#448822 , @avaldes wrote: > > > In D16425#448820 , @ngraham wrote: > > > > > So

D16425: Added new Suspend then Hibernate option

avaldes added a comment. In D16425#448820 , @ngraham wrote: > So is everything now working for you, or not? No, I can't use my keyboard to change brightness, but it might be related on how I test my changes. I need guidance on how can I t

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 56024. avaldes added a comment. Removed CMakeList change REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16425?vs=56023&id=56024 BRANCH suspend-then-hibernate (branched from master) REVISION DETAIL https://phabr

D16425: Added new Suspend then Hibernate option

avaldes added a comment. @ngraham I updated the patch with the comments, I'm not sure if I'm updating it corrrectly, I have tested it on my machine and it can suspend, but for some reason the dedicated keys to change the brightness are not working on my laptop. I'm still checking if this is

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 56023. avaldes edited the summary of this revision. avaldes added a comment. Rebasing changes to master, adding latest comments REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16425?vs=44950&id=56023 BRANCH suspend

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 44950. avaldes added a comment. I have changed the message. Also, if anyone can help me, I'm having a segmentation fault with these changes when an application inhibits power saving. This does happen with or without having available hibernation in th

D16425: Added new Suspend then Hibernate option

avaldes added a comment. In D16425#349588 , @ngraham wrote: > We'll need a spinbox to display time options for the amount of delay before hibernating if this is the UI we go with. But I kinda like Martin's idea and present this in the form of an

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 44294. avaldes added a comment. I have added a new checkbox inside the suspend session delay and in button event handling. I wasn't able to make it work with the button event handling, but the checkbox does work with the logic when Suspend Session is

D16425: Added new Suspend then Hibernate option

avaldes added a comment. @ngraham afaik powerdevil asks logind for system capabilites, with the CanSuspend, CanHibernate, etc. defined here . I added a new option if logind reports yes for CanSuspendThenHib

D16425: Added new Suspend then Hibernate option

avaldes created this revision. avaldes added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. avaldes requested review of this revision. REVISION SUMMARY See bug 399727 for a good description of what this