On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote:
>
> Good morning Community,
>
> I'm pleased to report that this week we reached a major milestone,
> with all the necessary technical components now being in place on our
> side for our migration to Gitlab to take place.
Regarding this: is the
albertvaka accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
arcpatch-D4545
REVISION DETAIL
https://phabricator.kde.org/D4545
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #plasma,
albertvaka requested changes to this revision.
albertvaka added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> NotificationDelegate.qml:32
> -property int layoutSpacing: units.smallSpacing
> -property int toolIconSize: units.iconSizes.smallMedium
> -
to
albertvaka added inline comments.
INLINE COMMENTS
> NotificationDelegate.qml:36-37
>
> -enabled: true
> -checked: notificationItem.containsMouse
> -
This was there so they highlight on hover. Is it not needed anymore?
> NotificationItem.qml:70
> +action("default")
> +
albertvaka added a comment.
What? This shouldn't have been pushed! It still has the old behaviour...
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4215
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: albertvaka, #plasm
albertvaka added a comment.
I still have to make the change to not close the notification if there is no
action. As soon as I change it I will push it. I agree it's good to have this
early in master, so we can have feedback and see if we need any tweak before
the next release.
REPOSITORY
albertvaka added a comment.
In https://phabricator.kde.org/D4215#79400, @mck182 wrote:
> Fair enough.
>
> Let's make a step back then. Since you've mentioned "Plasma is the only
notification system that does close-on-activate instead of executing some
action", can you actually list w
albertvaka added a comment.
In https://phabricator.kde.org/D4215#79153, @mck182 wrote:
> Well there you go then. Just implement the default action to be always the
top-most button in our actions list and make clicking the popup always execute
the first action in the list. That way, if th
albertvaka added a comment.
In https://phabricator.kde.org/D4215#79036, @mck182 wrote:
> Plasma might also be the only system that uses buttons for actions
Nope: http://imgur.com/a/Tfen4
We are not inventing the wheel here. Current, modern notifications are
something that has
albertvaka added a comment.
In https://phabricator.kde.org/D4215#79036, @mck182 wrote:
> Thinking about it a bit more, not doing anything when you click the
notification without default action is again a guess game - "will clicking this
popup do anything? how do I know?".
KDE app
albertvaka added a comment.
In https://phabricator.kde.org/D4215#79072, @colomar wrote:
> Since there does not seem a clear "best solution", isn't this something
that should be decided on a cross-desktop level?
> After all, it's not just about what users expect, but also what app
deve
albertvaka added a comment.
I think Plasma is the only notification system that does close-on-activate
instead of executing some action. Until now it wasn't even possible to add a
default action, but now that it is possible I think we all agree this is
something good that apps should adopt.
albertvaka added a comment.
It looks like the explanation on the commit message lead to confusion about
the "two different behaviours" thing. Let me explain it a bit more.
First of all, note that notifications always close when you click them, in
both cases. The notification disappears b
albertvaka added a reviewer: Plasma.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4215
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: albertvaka, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
albertvaka created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This uses the feature introduced here [1] on KNotifications, so default
actions don't appear as a regular action button. Instead, they are
https://bugs.kde.org/show_bug.cgi?id=366795
Albert Vaca changed:
What|Removed |Added
CC||albertv...@gmail.com
--- Comment #11 from Albert
https://bugs.kde.org/show_bug.cgi?id=347138
Albert Vaca changed:
What|Removed |Added
Ever confirmed|0 |1
Resolution|WAITINGFORINFO
/applets/tasks/tasks.cpp 0a86dcf
plasma/desktop/applets/tasks/tasksConfig.ui 6f3ff18
plasma/desktop/applets/tasks/windowtaskitem.cpp f840076
Diff: http://git.reviewboard.kde.org/r/110430/diff/
Testing
---
Manual testing.
Thanks,
Albert Vaca Cintora
> > collapse groups (a fairly hidden feature I also was not particularly happy
> > with tbh).
>
> Albert Vaca Cintora wrote:
> Hello Aaron and thank for your reply.
>
> Let me defend the inclusion of this patch from the problems you mention:
>
> - D
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110430/#review32545
-------
On May 14, 2013, 10:35 p.m., Albert Vaca Cintora wrote:
>
> --
20 matches
Mail list logo
