D13717: Implement Seek() and Seeked()

mokhtari marked 3 inline comments as done. mokhtari added inline comments. INLINE COMMENTS > broulik wrote in content-script.js:177 > Please avoid negating a longer statement, this makes the code hard to > understand at a glance: > > if (activePlayer.seekable.length === 0) Good point. Fixed.

D13717: Implement Seek() and Seeked()

mokhtari updated this revision to Diff 36902. mokhtari added a comment. Clean things up a bit: - use signal auto-relaying to clean up mprisplugin logic - use more readable test in content-script.js REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabric

D13717: Implement Seek() and Seeked()

mokhtari added a comment. Regarding loops with the Media Player widget, I haven't noticed any (using KDE Neon, 5.13.1). What test would catch this? INLINE COMMENTS > broulik wrote in content-script.js:177 > The `seekable` property isn't an int but a `TimeRanges` object that tells you > whic

D13717: Implement Seek() and Seeked()

mokhtari updated this revision to Diff 36854. mokhtari added a comment. Fixed seekable check. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13717?vs=36634&id=36854 REVISION DETAIL https://phabricator.kde.org/D13717 AFFECTED FILES e

D13717: Implement Seek() and Seeked()

mokhtari created this revision. mokhtari added a reviewer: KDE Connect. mokhtari added a project: KDE Connect. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mokhtari requested review of this revision. REVISION SUMMARY Implementing Seek()