Debian - and if a distro does
> still want to package these, they will still have the option of
> building the Plasma 5.18 tarball for Qt4 even after Plasma moves to a
> new revision.
>
> CC'ing packagers to give them a chance to shout.
>
> David
FWIW, we haven't shi
awilcox created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
awilcox requested review of this revision.
REVISION SUMMARY
In a strict POSIX compilation environment, pipe2 is not defined. Use the
_GNU_SOURCE FTM to expose it.
Fixes a failure to bui
awilcox abandoned this revision.
awilcox added a comment.
Since
https://phabricator.kde.org/R133:a9c44a10b6a60777bf8ca997d3618e66bbd44baa
conv_legacy is no longer an option for kscreenlocker. This patch is no longer
necessary as of Plasma 5.10.
REPOSITORY
R133 KScreenLocker
REVISION DET
awilcox added a comment.
I just wanted to add that after a convoluted process (ripping all the Wayland
checks out of CMakeLists.txt, and only building the kcheckpass target, since
the screen locker itself does not even build at all...), I have tested that
this change *does* work correctly on
awilcox added a comment.
> Out of interest: how did you stumble on that code?
Using the musl libc, getpass is not defined unless you enable _GNU_SOURCE:
[ 75%] Building C object kcheckpass/CMakeFiles/kcheckpass.dir/kcheckpass.c.o
cd
/usr/src/kde-plasma/kscreenlocker-5.8.5/work/
awilcox updated this revision to Diff 10782.
awilcox added a comment.
I have fixed the style issue with no space between if and bracket.
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4376?vs=10779&id=10782
REVISION DETAIL
https://phabricator.kde.o
awilcox created this revision.
awilcox set the repository for this revision to R133 KScreenLocker.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This modernises the kcheckpass utility to stop using the getpass(3) call,
