D26675: [sddm-theme] Don't have a broken reveal password button

2021-10-01 Thread Bharadwaj Raju
bharadwaj-raju added a comment. I see. So the bug is seen only if Breeze icons aren't installed? Because I read that it happened only on some systems, but I didn't know which exactly. Doesn't/shouldn't PC3 fall back to other icon themes if Breeze isn't installed? REPOSITORY R120 Plasm

D26675: [sddm-theme] Don't have a broken reveal password button

2021-10-01 Thread Ahmad Samir
ahmadsamir added a comment. One was to fix this is if sddm have copies of the needed password buttons, then it should work regardless of the installed icon themes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26675 To: davidedmundson, #plasma Cc: ahmadsa

D26675: [sddm-theme] Don't have a broken reveal password button

2021-10-01 Thread Ahmad Samir
ahmadsamir added a comment. In D26675#678811 , @bharadwaj-raju wrote: > Is there an SDDM issue to track this? Because I edited the file to make `revealPasswordButtonShown` true, and the button shows up just fine. Which makes me think this might

D26032: feat: add Control API for auto rotation

2021-10-01 Thread Alexander Volkov
volkov added inline comments. INLINE COMMENTS > control.cpp:266 > +const auto val = info[QStringLiteral("autorotate")]; > +return !val.canConvert() || val.toBool(); > +} Why treat an inconvertible value as true and not false? REPOSITORY R104 KScreen REVISION D

D26675: [sddm-theme] Don't have a broken reveal password button

2021-10-01 Thread Bharadwaj Raju
bharadwaj-raju added a comment. Is there an SDDM issue to track this? Because I edited the file to make `revealPasswordButtonShown` true, and the button shows up just fine. Which makes me think this might've been fixed in SDDM. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://ph