D4135: Split implementation of keyboard layout handling into a dedicated class

2020-12-10 Thread Andrey Butirsky
bam added inline comments. INLINE COMMENTS > bam wrote in keyboard_input.cpp:709 > I'm not quite follow the check here and whole processModifiers() method: > it's occurs after client gets the modifiers event, right? > But at this moment, the modifiers are already updated on server, isn't it? > So

D4135: Split implementation of keyboard layout handling into a dedicated class

2020-12-10 Thread Andrey Butirsky
bam added inline comments. INLINE COMMENTS > keyboard_input.cpp:709 > m_modifiersChangedSpy->updateModifiers(modifiers()); > +m_keyboardLayout->checkLayoutChange(); > } I'm not quite follow the check here and whole processModifiers() method: it's occurs after client gets the modifiers

Re: Alternate calendar in plasma - feature request discussion

2020-12-10 Thread David Edmundson
> Ialso found KCalendarSystem is pretty > well designed but it's in kdelibs4support and I can't found the successor. > I also write down my thoughts here and feel free to check it out and let > me know what you think. ( To provide some background. KCalendarSystem was what we had, whilst Qt had no