D23518: Disable media controls and tabsrunner in Firefox again

rgeorgiev added a comment. I think media controls should be enabled by default in private mode in Firefox. The reason why I think so is that Firefox has an option which allows the user to enable or disable each individual extension in incognito mode. It even asks the user about this explic

Re: Monday meeting notes for 9/11/2020

Am Montag, 9. November 2020, 15:22:51 CET schrieb Nate Graham: > On 11/9/20 5:18 AM, Marco Martin wrote: > > Missing form David Redondo: > > * I made a simple patch so QMenus are polished before creating the > > platform window > > * https://codereview.qt-project.org/c/qt/qtbase/+/320154 > >

D6628: Fix and normalize license in .desktop files

maspons added inline comments. INLINE COMMENTS > metadata.desktop:49 > X-KDE-PluginInfo-Depends= > -X-KDE-PluginInfo-License=GPL > X-KDE-PluginInfo-EnabledByDefault=true Are the changes from GPL to LGPL intended? > metadata.desktop:60 > X-KDE-PluginInfo-Depends= > -X-KDE-PluginInfo-License=G

Re: Monday meeting notes for 9/11/2020

On 11/9/20 5:18 AM, Marco Martin wrote: Missing form David Redondo: * I made a simple patch so QMenus are polished before creating the platform window * https://codereview.qt-project.org/c/qt/qtbase/+/320154 *  Which was the cause for ug

Re: Fix 'Connections' warnings in QML

One big fix is fine IMO. Nate On 11/9/20 6:53 AM, Konrad Materka wrote: Aleix, Yes, I know frameworks have lower dependencies - I just wanted to fix QML warnings in Plasma Workspace. The question is: Is it OK to do this in one bug change, or should I split it into smaller? Konrad pon., 9

D6628: Fix and normalize license in .desktop files

mak added a comment. In D6628#676722 , @bam wrote: > Thanks for clarifying. > > In D6628#676721 , @mak wrote: > > > So, this change looks fine to me now, as it is :-) > > > And yet it was chan

Re: Fix 'Connections' warnings in QML

Aleix, Yes, I know frameworks have lower dependencies - I just wanted to fix QML warnings in Plasma Workspace. The question is: Is it OK to do this in one bug change, or should I split it into smaller? Konrad pon., 9 lis 2020 o 14:23 Aleix Pol napisał(a): > Hi Konrad, > It's okay to fix them i

Re: Fix 'Connections' warnings in QML

Hi Konrad, It's okay to fix them in Plasma. Most of the ones we still have though are in frameworks that still depend on Qt 5.12 and it's not trivial to address this problem over there. Aleix On Mon, Nov 9, 2020 at 10:25 AM Konrad Materka wrote: > > Hi, > > With Qt 5.15 we have tons of warnings

D6628: Fix and normalize license in .desktop files

bam added a comment. Thanks for clarifying. In D6628#676721 , @mak wrote: > So, this change looks fine to me now, as it is :-) And yet it was changed again! :-D https://github.com/KDE/plasma-desktop/commit/05c230733a1b9d16c0e52eb549

D6628: Fix and normalize license in .desktop files

mak added a comment. In D6628#676720 , @sitter wrote: > These aren't SPDX identifiers but kaboutlicense keywords https://api.kde.org/frameworks/kcoreaddons/html/kaboutdata_8cpp_source.html#l00397 Makes sense. @bam As far as the "legacy s

D6628: Fix and normalize license in .desktop files

sitter added a comment. These aren't SPDX identifiers but kaboutlicense keywords https://api.kde.org/frameworks/kcoreaddons/html/kaboutdata_8cpp_source.html#l00397 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6628 To: sebas, #plasma, sitter, mart, broulik

Re: Monday meeting notes for 9/11/2020

Missing form David Redondo: * I made a simple patch so QMenus are polished before creating the platform window * https://codereview.qt-project.org/c/qt/qtbase/+/320154 * Which was the cause for ugly menus appearing in some places On Mon, Nov 9, 2020 at 1:16 PM Marco Martin wrote: > David E > *

Monday meeting notes for 9/11/2020

David E * First thing to discuss - there's a KDE community ML thread that says we didn't follow procedures wrt telemetry policy * There's a line that says "must have two reviewers" and then suggests two mailing lists * what should be done? a thread on kde-community for each place? [krop]: the purp

D6628: Fix and normalize license in .desktop files

bam added a comment. > Starting version 2.0, it is no longer valid to use the + operator in a license identifier should we address it? https://en.wikipedia.org/wiki/Software_Package_Data_Exchange#Deprecated_syntax REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.

Fix 'Connections' warnings in QML

Hi, With Qt 5.15 we have tons of warnings like: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Qt 5.15 is now a minimum requirement for Plasma Workspace, so nothing is blokcking to migrate to new syntax. Is it OK to fix them in one massive MR or better to do