D28904: Cleanup dependencies

2020-05-28 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. I've noticed I accidentally removed compiling a few things, that also depend on KIO, so maybe not as lean as I hoped REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D28904 To: broulik, #plasma Cc:

D28544: RecentDocuments Runner: Cleanup and formatting

2020-05-28 Thread Méven Car
meven added a comment. To rebase after https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 lands REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28544 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n,

D26111: Runner: make recentdocument use KActivityStats data

2020-05-28 Thread Méven Car
meven abandoned this revision. meven marked an inline comment as done. meven added a comment. Moved to https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 INLINE COMMENTS > meven wrote in recentdocuments.cpp:78 > It is needed for QString coming from KActivitiesStats, they can b

D29603: Adds custom spacing between task manager icons

2020-05-28 Thread Jacopo Martellini
martellini added a comment. In D29603#673942 , @ngraham wrote: > Thanks! And sorry for the long delay before reviewing. However this doesn't seem to be working for me; no matter what value I enter, my vertical icons-only-task manager's icon spac

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 111 - Still Failing!

2020-05-28 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/111/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 28 May 2020 18:53:01 + Build duration: 3 min 7 sec and counting CONSOLE OUTPUT [...tru

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-28 Thread Nathaniel Graham
ngraham added a comment. Overall it works very well given the current plumbing here! I'll accept it after one little change: INLINE COMMENTS > touchpad.qml:294 > + > +Controls.SpinBox { > +id: accelSpeedSpinbox Can you set `Layouts.Layout.minimumWidth: Kirigami.U

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

2020-05-28 Thread Alexander Volkov
volkov abandoned this revision. volkov added a comment. Moved to https://invent.kde.org/plasma/breeze/-/merge_requests/7 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11573 To: volkov, #breeze Cc: graesslin, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, T

D20562: Use (better) path to libICE when doing check_library_exists.

2020-05-28 Thread Adriaan de Groot
adridg closed this revision. adridg added a comment. Pushed via invent in 0c4ad7f1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20562 To: adridg, davidedmundson Cc: plasma-devel,

Re: Gitlab and plasma dev

2020-05-28 Thread Marco Martin
On Wed, May 27, 2020 at 11:36 PM Kai Uwe Broulik wrote: > > > > The thing that I found annoying is that only one person can be assigned to > > review. One thing that I was on the verge of doing is to @people that I'd > > like > > to notice the review in the comment to the MR. > > Yeah, I'm annoye