Re: Gitlab and plasma dev

2020-05-27 Thread Kai Uwe Broulik
The thing that I found annoying is that only one person can be assigned to review. One thing that I was on the verge of doing is to @people that I'd like to notice the review in the comment to the MR. Yeah, I'm annoyed by that, too. The problem with a pure mention is that there's no overview

Re: Gitlab and plasma dev

2020-05-27 Thread Ivan Čukić
> Somehow it's possible to create a label that covers all of Plasma as the > VDG have one already. > > Would that workflow work for other devs? Sounds cool. The thing that I found annoying is that only one person can be assigned to review. One thing that I was on the verge of doing is to @peopl

D29395: Refactor MediaController

2020-05-27 Thread Konrad Materka
kmaterka added a comment. Any update on this? I really like the idea. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: kmaterka, iasensio, broulik, trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jralei

Re: Gitlab and plasma dev

2020-05-27 Thread Kai Uwe Broulik
Hi, > I think this could be achieved with a label, that reviewers can set and authors can clear when they're ready. > Somehow it's possible to create a label that covers all of Plasma as the VDG have one already. Good idea! I think having a "Needs changes" label would be very useful, even on

Re: Gitlab and plasma dev

2020-05-27 Thread David Edmundson
One thing I'm missing when I'm doing reviews is I don't have a nice way to separate merge requests that need review, and merge requests that are awaiting changes. I think this could be achieved with a label, that reviewers can set and authors can clear when they're ready. Somehow it's possible to

D29326: Bookmarks Runner: Fix extraction of firefox profile

2020-05-27 Thread Alexander Lohnau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:a960c028c71d: Bookmarks Runner: Fix extraction of firefox profile (authored by alex). REPOSITORY R120 Plasma Workspa

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 110 - Still Failing!

2020-05-27 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/110/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 27 May 2020 13:41:59 + Build duration: 1 min 12 sec and counting CONSOLE OUTPUT [...tr

D29820: Correction when displaying "badger counter" icons using software rendering

2020-05-27 Thread Marco Martin
mart added a comment. yes please on gitlab. are you sure you don't get double painting on opengl now? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29820 To: brunogoncalves, ngraham Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jralei

Re: Sunsetting PowerDevil's XRandrBrightness

2020-05-27 Thread Martin Steigerwald
Martin Steigerwald - 26.05.20, 14:35:39 CEST: > Hi Kai. > > Kai Uwe Broulik - 20.05.20, 21:31:07 CEST: > > PowerDevil has two (three, if you count DDC) means of controlling > > screen brightness: > > > > * Writing to sysfs (/sys/class/backlight and /sys/class/leds) > > * Using XRandr output prope