D29807: WIP: Change Chrome API design

alex updated this revision to Diff 83029. alex marked an inline comment as done. alex added a comment. Create test cases REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29807?vs=83028&id=83029 BRANCH api_inconsistencies (branched from master) RE

D29781: Fix importing key-direction from *.ovpn files

ouwerkerk abandoned this revision. ouwerkerk added a comment. With the move to gitlab/invent.kde.org it seems better to abandon this in favour of a straightforward MR using the new shiny :) See: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/1 REPOSITORY R116 Plasma Network Man

D29807: WIP: Change Chrome API design

alex updated this revision to Diff 83028. alex added a comment. Make constructor private REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29807?vs=83019&id=83028 BRANCH api_inconsistencies (branched from master) REVISION DETAIL https://phabrica

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 17 May 2020 17:05:57 + Build duration: 19 min and counting JUnit Tests Name: projectroo

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

dkorth created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dkorth requested review of this revision. REVISION SUMMARY std::regex is slow, so use fixed-field parsing instead. This is an initial version that I've been using for a while with no major

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.14 - Build # 9 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 17 May 2020 17:05:57 + Build duration: 7 min 13 sec and counting JUnit Tests Name: (root) Fail

D28154: Add users KCM

ngraham added a comment. Now that D29394 has landed, you can add those images here! REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: ltoscano, mart, yur

D29807: WIP: Change Chrome API design

anthonyfieroni added reviewers: broulik, Plasma. anthonyfieroni added a comment. Commented code should be removed. INLINE COMMENTS > chromeprofile.h:11 > +public: > +ProfileBookmarks(const QString &path, const QString &name); > +static QList findAllProfiles(const QString > &applicati

D29807: WIP: Change Chrome API design

alex created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY - The FindProfile class was only for Chrome implemented => removed - Having ProfileBookmarks and Profile class is unnecessary, especiall

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir updated this revision to Diff 83017. ahmadsamir added a comment. Remove one include REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29687?vs=82943&id=83017 BRANCH l-krun-port (branched from master) REVISION DETAIL https://phabricato

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

dfaure added inline comments. INLINE COMMENTS > iconapplet.cpp:52 > #include > +#include > #include You're not using that class, are you? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29687 To: ahmadsamir, #plasma, broulik, dfaure Cc: dfaure, ngraham,

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

dfaure accepted this revision. dfaure added a comment. KServiceFactory::findServiceByStorageId falls back to "new KService" if it can't find the storageId in ksycoca. So yes it worked, but it's kind of pointless (and confusing) to call it just to go to the new KService fallback, better do th

D29326: Bookmarks Runner: Fix extraction of firefox profile

alex added a comment. Friendly Ping @bruns or may I land this already ? And should this land on `Plasma/5.19`? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29326 To: alex, #plasma, ngraham, bruns, broulik, meven Cc: meven, plasma-devel, Orage, LeGast00n