D29570: Fix some alignments

2020-05-09 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29570 To: niccolove, #vdg, #plasma Cc: abetts, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezh

D29571: [Kickoff] Add emacs/bash style keybindings

2020-05-09 Thread Mariusz Libera
mlibera added a comment. Does the mechanism of standard shortcuts really apply here? Just below the code I added is the code explicitly handling keys like Qt.Key_Up, Qt.Key_Down, Qt.Key_Tab, etc. Seems like it's all hardcoded. Adding those keybinding to standard shortcuts has no effect.

D29571: [Kickoff] Add emacs/bash style keybindings

2020-05-09 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. KDE has a concept of "standard shortcuts". Instead of duplicating this same code everywhere with various combinations for people doing all sorts of crazy bindings,

D29571: [Kickoff] Add emacs/bash style keybindings

2020-05-09 Thread Mariusz Libera
mlibera created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlibera requested review of this revision. REVISION SUMMARY Users used to emacs/bash style of navigation and editing might appreciate a basic support for it in Kickoff, especially Ctrl+n/p fo

D29570: Fix some alignments

2020-05-09 Thread Niccolò Venerandi
niccolove added a comment. For some reason, the heading is still one or two pixels off... still, much better than before REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29570 To: niccolove, #vdg, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29570: Fix some alignments

2020-05-09 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This fixes some wrong alignments REPOSITORY R120 Plasma Workspace BRANCH fixspacing (branched from master) REVISION DETAI

D29359: Add context for "Automatic" strings

2020-05-09 Thread Yuri Chornoivan
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:2bf19bb7c59d: Add context for "Automatic" strings (authored by yurchor). REPOSITORY R116 Plasma Network Management A

D29359: Add context for "Automatic" strings

2020-05-09 Thread Eloy Cuadra
ecuadra accepted this revision. ecuadra added a comment. Yes. Sorry for the delay. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D29359 To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra Cc: ecuadra, plasma-devel, Orage, LeGast

D29359: Add context for "Automatic" strings

2020-05-09 Thread Yuri Chornoivan
yurchor added a comment. @ecuadra Ping? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D29359 To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra Cc: ecuadra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, z

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-09 Thread Mikhail Zolotukhin
gikari added a comment. In D28623#666890 , @trmdi wrote: > Just a question, SierraBreezeEnhanced has a feature called "Unison hovering". Does this support it? Also, I think, that to support that you actually need to do a lot of upstream

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-09 Thread Mikhail Zolotukhin
gikari added a comment. In D28623#666890 , @trmdi wrote: > Just a question, SierraBreezeEnhanced has a feature called "Unison hovering". Does this support it? No. That's because it is the GTK, who is responsible for hovering behavior. I

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-09 Thread Tranter Madi
trmdi added a comment. Just a question, SierraBreezeEnhanced has a feature called "Unison hovering". Does this support it? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28623 To: gikari, #breeze, #plasma, cblack Cc: trmdi, ngraham, plasma-devel,

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-09 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 82365. gikari added a comment. - Add support for aurorae themes - Plastic does not work, but in that case decoration buttons in GTK apps are Breeze REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2862

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-05-09 Thread Niccolò Venerandi
niccolove added a comment. Generic +1 to the idea, but: - I would not go higher than 50 as panel width - The clock is too small, it probably needs a version where there's a new line between hour and minutes - We should check that all widgets work correctly in a vertical panel REPOSIT

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-05-09 Thread Felix Ernst
felixernst added a comment. +1 to this change. Having the exact same panel and buttons on the left instead of at the bottom is a change that IMO even the most computer-illiterate Windows user should have no major trouble adapting to. Anyone else can change the panel position if they want t

D29548: Drag and drop assigning windows to activities in the default switcher

2020-05-09 Thread Ivan Čukić
ivan created this revision. ivan added reviewers: Plasma, mart, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY When dragging a window from the taskbar onto the activity switcher applet,