Re: Information regarding upcoming Gitlab Migration

2020-04-26 Thread Ben Cooksley
On Mon, Apr 27, 2020 at 6:33 PM Rolf Eike Beer wrote: > > Bhushan Shah wrote: > > > I've worked on draft "move" of the current set of the repositories in > > their respective subgroups at the repo-metadata project's branch [1]. > > You can browse the directory structure to get idea of how final >

Re: Information regarding upcoming Gitlab Migration

2020-04-26 Thread Rolf Eike Beer
Bhushan Shah wrote: I've worked on draft "move" of the current set of the repositories in their respective subgroups at the repo-metadata project's branch [1]. You can browse the directory structure to get idea of how final structure on Gitlab would look like. No objection, just a request for

Information regarding upcoming Gitlab Migration

2020-04-26 Thread Bhushan Shah
[Please keep sysad...@kde.org list or bs...@kde.org in the CC for replies] Hello Community members, In view of upcoming Gitlab migration, we sysadmin team wants to share the recommended structuring for the repositories on Gitlab. We had multiple options, - Flat structure: In this option we woul

Re: Type=FSDevice desktop files

2020-04-26 Thread Aleix Pol
On Sun, Apr 26, 2020 at 11:45 PM David Faure wrote: > > Would it be OK if we dropped support for desktop files that represent devices? > This was a KDE1/KDE2/KDE3? feature, you'd write/ship a desktop file with > Type=FSDevice and Dev=/dev/sdc > and this would give you Mount and Unmount in the cont

D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include

2020-04-26 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29215 To: asturmlechner, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include

2020-04-26 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY Otherwise, this does not get the header from Synaptics_INCLUDE_DIRS. TEST PLAN

D29214: [Notifications] Fix typo

2020-04-26 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Fixes notifications of different origins being grouped together when they shouldn't. TEST PLAN

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira
This revision was automatically updated to reflect the committed changes. Closed by commit R169:061a750068a4: Remove unused QtConcurrent from colorutils (authored by patrickelectric). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29202?vs=81262&id=81278 REV

D29209: PlaceholderMessage: Remove Plasma units usage

2020-04-26 Thread Jonah Brüchert
This revision was automatically updated to reflect the committed changes. Closed by commit R169:8473aad62ed4: PlaceholderMessage: Remove Plasma units usage (authored by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29209?vs=81263&id=81274 REVIS

D29209: PlaceholderMessage: Remove Plasma units usage

2020-04-26 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oops, thanks for catching this! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D29209 To: jbbgameich, #kirigami, ngraham Cc: ngraham, plasma-de

D29209: PlaceholderMessage: Remove Plasma units usage

2020-04-26 Thread Jonah Brüchert
jbbgameich created this revision. jbbgameich added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Probably this was forgotten when importing the new component into Kirigami REPOSITOR

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira
patrickelectric updated this revision to Diff 81262. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29202?vs=81260&id=81262 REVISION DETAIL https://phabricator.kde.org/D29202 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/colorutils.cpp To: patrickelectric, apol, mart Cc

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira
patrickelectric added a comment. @apol done. REVISION DETAIL https://phabricator.kde.org/D29202 To: patrickelectric, apol, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira
patrickelectric updated this revision to Diff 81260. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29202?vs=81240&id=81260 REVISION DETAIL https://phabricator.kde.org/D29202 AFFECTED FILES src/colorutils.cpp To: patrickelectric, apol, mart Cc: plasma-devel, fbampaloukas, GB_2, do

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira
patrickelectric added a comment. In D29202#657702 , @patrickelectric wrote: > In D29202#657700 , @apol wrote: > > > Then remove it from CMakeLists.txt as well? > > > Can you point what exactly

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira
patrickelectric added a comment. In D29202#657700 , @apol wrote: > Then remove it from CMakeLists.txt as well? Can you point what exactly should be removed ? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29202

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread Aleix Pol Gonzalez
apol added a comment. Then remove it from CMakeLists.txt as well? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29202 To: patrickelectric, apol, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira
patrickelectric added a comment. It fails to build when QtConcurrent can't be found. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29202 To: patrickelectric, apol, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmu

D29203: kirigami.pri: Add missing includes

2020-04-26 Thread patrick j pereira
patrickelectric created this revision. patrickelectric added reviewers: apol, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29203 AFFECT

D29202: Remove unused QtConcurrent from colorutils

2020-04-26 Thread patrick j pereira
patrickelectric created this revision. patrickelectric added reviewers: apol, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29202 AFFECT

D29142: Add footer support to systray

2020-04-26 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R120:0f28094f584c: Add footer support to systray (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29142?vs=81184&id=81221 REVISION DETAI