D28958: [kcm_nightcolor] Set 2 decimal places precision for coordinates

This revision was automatically updated to reflect the committed changes. Closed by commit R119:35e18420a76a: [kcm_nightcolor] Set 2 decimal places precision for coordinates (authored by shubham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28958?vs=

D26111: Runner: make recentdocument use KActivityStats data

meven updated this revision to Diff 80516. meven added a comment. Rebasing after D28369 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=73087&id=80516 BRANCH arcpatch-D26111_1 REVISION DETAIL https

D28971: Persist state between launches

cblack created this revision. cblack added a reviewer: Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Window geometry and last page will persist between launches. TEST PLAN Change window ge

D28970: [applets/digital clock] Make tooltip spacing and text nicer and more consistent

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN Before, no clocks: F8246116: Without clocks, before.png Aft

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

On Sun, Apr 19, 2020 at 3:13 AM David Faure wrote: > > On Saturday, April 18, 2020 5:06:43 PM CEST Friedrich W. H. Kossebau wrote: > > Am Samstag, 18. April 2020, 16:26:57 CEST schrieb David Faure: > > > On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote: > > > > Hi all, > > > > > > >

D28941: startplasma: Sort environment scripts prior to sourcing

auxym updated this revision to Diff 80511. auxym added a comment. Fix a comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28941?vs=80510&id=80511 REVISION DETAIL https://phabricator.kde.org/D28941 AFFECTED FILES startkde/startplasma.cpp

D28941: startplasma: Sort environment scripts prior to sourcing

auxym updated this revision to Diff 80510. auxym added a comment. Use priority as returned by QStandardPaths::standardLocations and sort in the entryInfoList() call. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28941?vs=80466&id=80510 REVISION

D28965: Support Brave browser

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN With the deb package from their website - Media controls for video in Brave now show Brave log

D28908: Use the same icon mode calculation for comboboxes as for buttons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Ok, it took me a while to fully understand what this patch does, but it seems to be working fine. REPOSITORY R31 Breeze BRANCH combobox (branched from master) REVISION DETAIL https:

D28908: Use the same icon mode calculation for comboboxes as for buttons

ndavis added a comment. In D28908#651314 , @davidre wrote: > In D28908#651078 , @ndavis wrote: > > > Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and t

D28908: Use the same icon mode calculation for comboboxes as for buttons

davidre added a comment. In D28908#651078 , @ndavis wrote: > Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and tools comboboxes are right next to each other and have different behavior. > > This

D28958: [kcm_nightcolor] Set 2 decimal places precision for coordinates

shubham created this revision. shubham added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH coor REVISION DETAIL https://phabricator.kde.org/D28958 AFFECTED FILE

D28686: [Battery Monitor] Choose better wording

shubham added a comment. @broulik Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, broulik, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himces

D27098: Konsole Runner: optimize and simplify

alex updated this revision to Diff 80485. alex added a comment. Minor issue when rebasing REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=80484&id=80485 BRANCH arcpatch-D27098 REVISION DETAIL https://phabricator.kde.org/D27098 AFFECTED

D27098: Konsole Runner: optimize and simplify

alex updated this revision to Diff 80484. alex added a comment. Rebase REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=79560&id=80484 BRANCH arcpatch-D27098 REVISION DETAIL https://phabricator.kde.org/D27098 AFFECTED FILES runners/kon

D28941: startplasma: Sort environment scripts prior to sourcing

auxym added a comment. Good option, I had not noticed that in the QT docs. I felt using startsWith() was a bit hackish anyways. Plus, since entryInfoList() has a sort param, I won't even need the sort call. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28

D28949: Add titlebar colors to Kirigami::PlatformTheme

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This is a prerequisite for implementing the tools area in QML applications, which requires havin

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

On Saturday, April 18, 2020 5:06:43 PM CEST Friedrich W. H. Kossebau wrote: > Am Samstag, 18. April 2020, 16:26:57 CEST schrieb David Faure: > > On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote: > > > Hi all, > > > > > > Please see below - any ideas as to why KHelpCenter no longer >

D28908: Use the same icon mode calculation for comboboxes as for buttons

ndavis added a comment. Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and tools comboboxes are right next to each other and have different behavior. This causes another problem with all monochrome icons on the Breeze colorscheme though: F

D28945: PageRouter autotests fixes

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. TEST PLAN Tests run successfully. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabrica

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote: > Hi all, > > Please see below - any ideas as to why KHelpCenter no longer successfully > builds? > > It doesn't look like KHelpCenter has changed... No, Qt has. This was fixed today by Johnny Jazeix in commit 220a959bf150966f807ed

D28383: Add PageRouter component

dfaure added a comment. The unittest in this commit appears to break in CI. https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kirigami/job/kf5-qt5%20SUSEQt5.12/417/testReport/junit/projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512/autotests/tst

D28941: startplasma: Sort environment scripts prior to sourcing

davidedmundson added a comment. Concept makes sense. QStandardPaths is ordered: "The list of directories is sorted from high to low priority, starting with writableLocation()" so we can cut this code in half by doing some sort of void runEnvironmentScripts() { const a

D28941: startplasma: Sort environment scripts prior to sourcing

auxym created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. auxym requested review of this revision. REVISION SUMMARY Sort environment scripts before they are sourced. User scripts should run after system scripts to ensure that user preferences take pre

D28939: Don't offer sending non-http(s) links and sources via KDE Connect

broulik added a comment. > How did that happen? lol I have no idea > I'd say yes, together with `ftps` it doesn't recognize/allow `ftps`, only `http`, `https`, `file`, and `ftp`, see https://developer.chrome.com/extensions/match_patterns > That sounds weird, none of the tar

D28939: Don't offer sending non-http(s) links and sources via KDE Connect

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. > Repository R120 Plasma Workspace How did that happen? > Should we include "ftp"? I'd say yes, together with `ftps`

D28939: Don't offer sending non-http(s) links and sources via KDE Connect

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `chrome://` and `about:` pages are typically local and browser-specific, and `blob:` pages

D28914: Include the Plasma Vault name in the mount dialog title

ksmanis marked an inline comment as done. ksmanis added inline comments. INLINE COMMENTS > ngraham wrote in mountdialog.cpp:34 > Maybe put the vault name in single quotes? Agreed, I had single quotes initially, but wasn't sure if it was proper. REPOSITORY R845 Plasma Vault BRANCH password-

D28914: Include the Plasma Vault name in the mount dialog title

ksmanis updated this revision to Diff 80455. ksmanis added a comment. - Add single quotes around the vault name REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28914?vs=80374&id=80455 BRANCH password-manager (branched from master) REVISION DETAIL

D28936: Use a Proxy object to detect changes within the MediaMetadata

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY According to spec [1] it is allowed to change properties within the `MediaMetadata` rather