D27857: Port some usage of QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added a reviewer: Plasma. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY [0-9] is \d TEST PLAN make && ctest REPOSITORY R120 Plasma Workspace BRANCH l-qregexp-QRE (branched from master) REVISIO

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

This revision was automatically updated to reflect the committed changes. Closed by commit R116:999f0ad9fb8b: Update L2TP to NetworkManager-l2tp 1.8.0 features (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D277

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

jgrulich added a comment. I would say it's not a big deal as we use groupboxes quite a lot in plasma-nm. We can get rid of them in future when rewriting the KCM to QML. REVISION DETAIL https://phabricator.kde.org/D27764 To: dkosovic, jgrulich Cc: ngraham, plasma-devel, Orage, LeGast00n, Th

D27847: [applet/taskmanager] Remove the launcher items' tooltip icons

ngraham added a comment. In D27847#622409 , @anthonyfieroni wrote: > Why? I think you forgot to read the description section. :) REPOSITORY R119 Plasma Desktop BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL htt

D27847: [applet/taskmanager] Remove the launcher items' tooltip icons

anthonyfieroni added a comment. Why? REPOSITORY R119 Plasma Desktop BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27847 To: ngraham, #vdg, #plasma, niccolove, ognarb Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27856: Improve "write a review" encouragement message

This revision was automatically updated to reflect the committed changes. Closed by commit R134:6d6b7555248b: Improve "write a review" encouragement message (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27856?vs=76984&id=76

D27856: Improve "write a review" encouragement message

apol created this revision. apol added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It's not necessarily apps, it doesnt' really add that much meaning BUG: 418365 REPOSITORY R

D27838: Port to new QML Connections syntax

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Yes, can't be done until 5.14 is required in frameworks. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D27838 To: jbbgameich, #fr

D26718: aggregate text for KRunner in DesktopView

ngraham added a comment. Can confirm the fix when running from the desktop, but not when using the shortcut. So I wouldn't call 416145 fully fixed yet. Are you planning to work on that other part in this patch, or in a separate one? REPOSITORY R120 Plasma Workspace REVISION DETAIL https

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

ngraham added a comment. It's just that in general we're trying to move away from group boxes and towards the use of whitespace to logically group sections. It's not a huge deal, but it would be appreciated. :) REVISION DETAIL https://phabricator.kde.org/D27764 To: dkosovic, jgrulich Cc:

D27849: [applets/digital-clock] Remove the tooltip icon

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY To increase consistency and reduce redundancy, widget tooltip icons are being removed in D2

D27847: [applet/taskmanager] Remove the launcher items' tooltip icons

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY As discussed in T12778 , the icon can never be in a corre

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham updated this revision to Diff 76967. ngraham added a comment. Use 38px as the height, and hardcode it since there's no good way to get there with a multiple of `gridUnit` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27845?vs=76966&id=769

D27792: [Applet]Fix traffic monitor labels width

ngraham added a comment. Yeah, if you want to keep the plotter dimensions constant, then there's no way around measuring the width of the labels. Regarding not opening any new patches, I hope you didn't have a bad experience in KDE that's left a bad taste in your mouth. If anything's gon

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Now to my eyes, 38px is too small. But apparently my tired old eyes and small screen (13.3" FHD) are not representative of other VDG people's views. :) Still it makes me realize that we really need to get https://bugs.kde.org/show_bug.cgi?id=356446 done so that P

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

niccolove added a comment. +1 to 38 Weirdly enough, the plasma icon only looks that big from >40, while the IOTM does not use big icons in 40 yet. I'd like small icons to be used consistently. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraha

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Some folks in the #VDG channel have objected to the panel being 48px tall, so here's how it would look at 38 (the default Windows panel height): F8149938: 38.png Not as touch-frien

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Sounds like a bug we should fix with the `preferred://` schemas then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fba

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

The-Feren-OS-Dev added a comment. `applications:systemsettings.desktop,applications:org.kde.discover.desktop,preferred://filemanager,preferred://browser` There is currently an issue that might make this cumbersome, unless it was fixed very recently as part of the patch work for this, bei

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of, D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it , after further discussion in T12441 . REP

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. One other note: it might make sense to turn on the Digital Clock's date display by default if we go with this, as the clock text is currently rather gigantic and IMO adding the date results in both more information and also a better use of space: F8149908: clock

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch implements the part of T12441 that was virtua

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. I don't plan to make more patches, for now. But if the problem would not exist with layouts, prefer to do it than make quick bugfixes. But can't see how the Layouts would help with that. Everything can be done without Layouts too AFAIK, just more messy. I want to

D27792: [Applet]Fix traffic monitor labels width

ngraham accepted this revision. ngraham added a comment. If you need to measure the width of text, then you're doing it the right way. However this problem wouldn't be happening in the first place if this UI used Layouts, which handle this kind of case more elegantly so you don't need to

D27608: Fixes for applet configuration layout.

gvgeo added a comment. There is a problem, I still try to fix... REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf, ngraham Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n

D27608: Fixes for applet configuration layout.

ngraham added a comment. Yeah, this seems fine to land as-is. :) REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf, ngraham Cc: ngraham, filipf, plasma-devel, Orage, LeGast00n

D27686: Fix connection to invalid signal

aacid added a comment. ping REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D27686 To: aacid Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jen

D26992: [SystemTray] Use unified data model everywhere

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. UI and interaction are good, and a basic code review reveals no issues to me. Still, you may want to wait for a more thorough code review from a #plasma

D27843: Port to new QML Connections syntax

jbbgameich created this revision. jbbgameich added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Can be landed once Frameworks can depend on Qt 5.14 TEST PLAN Everything still wor

[kio-extras] [Bug 345440] SFTP: Internal Error on deleting a folder without having permissions and wich is also mounted

https://bugs.kde.org/show_bug.cgi?id=345440 Harald Sitter changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC|

[kio-extras] [Bug 376301] sftp.so not closing connections when ProxyCommand is configured

https://bugs.kde.org/show_bug.cgi?id=376301 Harald Sitter changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC|

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

ervin created this revision. ervin added reviewers: crossi, hchain, meven, bport, davidedmundson, mart, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. TEST PLAN Has been tested with the three modules mentioned in the co

D27838: Port to new QML Connections syntax

jbbgameich updated this revision to Diff 76950. jbbgameich added a comment. Fix syntax error REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27838?vs=76949&id=76950 BRANCH 5.15-connections-syntax (branched from master) REVISION

D27838: Port to new QML Connections syntax

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Fixes deprecation warnings with Qt 5.15 TEST PLAN No deprecations warnings, everything still works REPOSITORY R858 Qt Qu

D27837: Fix about page with Qt 5.15

jbbgameich created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY UrlButton exists since since org.kde.kirigami 2.6, before the file was resolved from the current directory but doesn't seem

D27824: Use consistent highlight

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Need to adjust the button's right margin in `DeviceItem.qml` as well: F8149546: Screenshot_20200304_084053.png Could be done in another patch.

D27823: Use consistent highlight

ngraham added a comment. This needs a rebase. Also you probably need to delete the existing mouseover highlight effect. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg Cc: ngraham, plasma-devel, Orage, LeG

[kio-extras] [Bug 366488] Too many sftp.so processes, not closing

https://bugs.kde.org/show_bug.cgi?id=366488 Harald Sitter changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED

[kio-extras] [Bug 366488] Too many sftp.so processes, not closing

https://bugs.kde.org/show_bug.cgi?id=366488 Harald Sitter changed: What|Removed |Added CC||sit...@kde.org --- Comment #1 from Harald Sitte

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic added a comment. When I was updating this client's UI, I was pretty conflicted about using group boxes, many of the other VPN clients were using group boxes for their main window and at one stage I was thinking of introducing group boxes for the main window of this client. It was de

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic updated this revision to Diff 76933. dkosovic added a comment. updates based on review comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27764?vs=76731&id=76933 REVISION DETAIL https://phabricator.kde.org/D27764 AFFECTED FILES vpn/l2tp/CMakeLists.txt vpn/l2tp/l

D27832: Fix spacing change

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:eb4235eae1e8: Fix spacing change (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27832: Fix spacing change

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY A accidentally changed spacing with my previous commit REPOSITORY R120 Plasma Workspace BRANCH fixspacing (branched from m

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

ahmadsamir added a comment. FTR, removing setNeedsSave(false) from load(), it seems to work sometimes, and then some other times it doesn't work (i.e. changing anything, Apply doesn't get enabled)... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27785 To:

D27830: [Fonts KCM] Make the font selection dialog highlight the correct style

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, broulik, ervin, meven. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY KConfig will clear the styleName font property for "Regular"-like font styles (so that set

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove added a comment. Uff, I screwed up landing this patch: https://cgit.kde.org/plasma-workspace.git/commit/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26946 To: niccolove, #vdg, #plasma, ngraham Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n

D26946: Changed leftMargins to smallSpacing to be consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R120:149075077b82: Changed leftMargins to smallSpacing to be consistent (authored by niccolove). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26946?vs=76913&id=76923#toc REPOSITORY R120 Plasma

D26945: fix(plasmoid): add smallSpacing to leftMargin

This revision was automatically updated to reflect the committed changes. Closed by commit R104:b0f3fa30d427: fix(plasmoid): add smallSpacing to leftMargin (authored by niccolove). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26945?vs=76025&id=76920 REVISIO

D26945: fix(plasmoid): add smallSpacing to leftMargin

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Depends on if you use in the end arc. Then it's given by the Phab diff title. I changed it some more. See https://github.com/angular/angular/blob/3cf2005a936bec2058610b0786dd0671dae3d

D26945: fix(plasmoid): Added smallSpacing to leftMargin

niccolove added a comment. Is the commit given by the patch title that I just changed, or do I have to change the commit name somewhere else? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D26945 To: niccolove, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-F

D27595: Watch for language change events, and forward those to the QML engine

vkrause added a comment. I can reproduce only if I set a valid translation catalog. Even more surprising since the affected dialog does not seem to contain any qsTr() translations. I don't think this patch is wrong as such, the layouting glitch is a bug elsewhere that we trigger by the ret

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove updated this revision to Diff 76913. niccolove added a comment. Remove spacing changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26946?vs=76024&id=76913 BRANCH smallspacingmargin (branched from master) REVISION DETAIL https://p

D27824: Use consistent highlight

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This uses the PlasmaComponents.Highlight feature to be consistent with other lists REPOSITORY R97 Bluedevil BRANCH highli

D27823: Use consistent highlight

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. niccolove requested review of this revision. REVISION SUMMARY Use the PlasmaComponents.Highlight feature to be consistent with other lists. REPOSITORY R

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo abandoned this revision. gvgeo added a comment. Unfortunately I won't be able to continue with this patch about battery applet. Feel free to use/modify if you want. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davi

D27807: Changed style of pressed list item to be consistent

niccolove abandoned this revision. niccolove added a comment. Actually, there is a proper way to do this. Gimme a sec. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: ngraham, plasma-devel, ndavis, kde-framewo

D27608: Fixes for applet configuration layout.

filipf added a comment. In D27608#621705 , @gvgeo wrote: > Strange, I don't get the resizing problem as it is now, or in master. Only managed to get this space by changing the theme, and was immediately fixed with resize. > > Thanks Filip fo

D27608: Fixes for applet configuration layout.

gvgeo added a comment. Strange, I don't get the resizing problem as it is now, or in master. Only managed to get this space by changing the theme, and was immediately fixed with resize. Thanks Filip for double checking. REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76910. gvgeo added a comment. Cancel button was touching the edge in RTL. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=76908&id=76910 BRANCH configscollcat (branched from master) REVISION DETAIL ht

D27608: Fixes for applet configuration layout.

filipf accepted this revision. filipf added a comment. Fixes the regression. It's still possible to get this when resizing, but it was actually already like that before this patch. F8149023: image.png REPOSITORY R119 Plasma Desktop BRANCH confi

D27645: [KCM]Align volume controls row

This revision was automatically updated to reflect the committed changes. Closed by commit R115:ca15ec82c121: [KCM]Align volume controls row (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76884&id=76909 REVISIO

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76908. gvgeo marked an inline comment as not done. gvgeo added a comment. Fixed margins. Unfortunatly the RTL layout has some issues, had to disable the use of available width for RTL layout, to stop the jumping from the scrollview. REPOSITORY R119 Plas